Re: [PATCH v2 0/5] nvmem: sunxi-sid: add SID controller support for H6

2019-04-04 Thread Srinivas Kandagatla
On 02/04/2019 16:45, Yangtao Li wrote: Add SID support for H6, and do some cleanup. For endianness issue, add a new ref_read func. Yangtao Li (5): nvmem: sunxi-sid: fix wrong description in kernel doc nvmem: sunxi-sid: add binding for H6's SID controller nvmem: sunxi-sid: convert to

Re: [PATCH v2 4/5] nvmem: sunxi-sid: add new reg_read func

2019-04-04 Thread Srinivas Kandagatla
On 02/04/2019 16:45, Yangtao Li wrote: Because there was an endianness issue. It seems that reg_read function which the nvmem the driver currently exposes is wrong. So add the new read function, the new function is used when the native_endian flag is set. Signed-off-by: Yangtao Li This pat

Re: [PATCH 1/3] nvmem: imx-ocotp: use devm_platform_ioremap_resource() to simplify code

2019-04-04 Thread Srinivas Kandagatla
On 01/04/2019 05:59, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Applied series to nvmem-next Thanks, srini

Re: linux-next: manual merge of the char-misc tree with the char-misc.current tree

2019-04-02 Thread Srinivas Kandagatla
On 03/04/2019 04:56, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the char-misc tree got a conflict in: drivers/misc/fastrpc.c between commit: 01b76c32e3f3 ("misc: fastrpc: add checked value for dma_set_mask") from the char-misc.current tree and commit: 977e6c8d1d1

[PATCH] regmap: regmap-irq: fix getting type default values

2019-03-28 Thread Srinivas Kandagatla
did remove the default mask but it forgot to remove the check before reading the default type register. Fixes: 84267d1b18ab ("regmap: regmap-irq: Remove default irq type setting from core") Signed-off-by: Srinivas Kandagatla --- drivers/base/regmap/regmap-irq.c | 3 --- 1 file changed,

Re: [PATCH v0] nvmem: core: Export nvmem cell info to userspace

2019-03-25 Thread Srinivas Kandagatla
On 24/03/2019 15:25, Gaurav Kohli wrote: On 3/22/2019 8:53 PM, Srinivas Kandagatla wrote: On 20/03/2019 05:53, Gaurav Kohli wrote: From: Shiraz Hashim Existing nvmem framework export full register space as nvmem binary, but not exporting child node of nvmem which is nvmem cell. Kernel

Re: [PATCH v0] nvmem: core: Export nvmem cell info to userspace

2019-03-22 Thread Srinivas Kandagatla
On 20/03/2019 05:53, Gaurav Kohli wrote: From: Shiraz Hashim Existing nvmem framework export full register space as nvmem binary, but not exporting child node of nvmem which is nvmem cell. Kernel can read the specific cell by using nvmem_cell_read but userspace don't have such provision. Ad

Re: [PATCH v2] nvmem: core: Set no-read-write provider to avoid userspace read/write

2019-03-22 Thread Srinivas Kandagatla
. --->cut<--- From: Srinivas Kandagatla Date: Wed, 20 Mar 2019 16:15:21 + Subject: [PATCH] nvmem: core: add support to NVMEM_NO_SYSFS_ENTRY Some users might not want to expose nvmem entry to sysfs and only intend to use

Re: [PATCH v2] nvmem: core: Set no-read-write provider to avoid userspace read/write

2019-03-20 Thread Srinivas Kandagatla
On 20/03/2019 15:50, Gaurav Kohli wrote: On 3/20/2019 8:04 PM, Srinivas Kandagatla wrote: On 17/03/2019 14:12, Gaurav Kohli wrote: Current nvmem framework allows user space to read all register space populated by nvmem binary file, In case we don't want to expose value of registe

Re: [PATCH] slimbus: fix a NULL pointer dereference in of_qcom_slim_ngd_register

2019-03-20 Thread Srinivas Kandagatla
On 15/03/2019 06:20, Kangjie Lu wrote: In case platform_device_alloc fails, the fix returns an error code to avoid the NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/slimbus/qcom-ngd-ctrl.c | 4 1 file changed, 4 insertions(+) Thanks Applied. --srini

Re: [PATCH] slimbus: ngd: Fix to avoid potential NULL pointer dereference

2019-03-20 Thread Srinivas Kandagatla
On 19/03/2019 01:25, Aditya Pakki wrote: In of_qcom_slim_ngd_register, of_match_node may fail and return a NULL pointer. This patch avoids such a scenario leading to NULL pointer dereference. Fixes: 458a445deb9c ("slimbus: ngd: Fix build error on x86") Signed-off-by: Aditya Pakki --- drive

Re: [PATCH v2] nvmem: core: Set no-read-write provider to avoid userspace read/write

2019-03-20 Thread Srinivas Kandagatla
On 17/03/2019 14:12, Gaurav Kohli wrote: Current nvmem framework allows user space to read all register space populated by nvmem binary file, In case we don't want to expose value of registers to userspace and only want kernel space to read cell value from nvmem_cell_read_u32. To protect the

Re: [PATCH v2 0/6] Add nvmem support on STM32

2019-03-20 Thread Srinivas Kandagatla
On 28/02/2019 10:19, Fabrice Gasnier wrote: Non volatile memory area is available on STM32. It contains various factory programmed information such as unique device ID, analog calibration... This patchset adds: - NVMEM support to access stm32 data cells - helper to read 16 bits cells. --- Cha

Re: [PATCH v3] PCI: qcom: Use default config space read function

2019-03-18 Thread Srinivas Kandagatla
E_PCI); However, the above has no effect on 8064, thus a fixup is required. Signed-off-by: Marc Gonzalez --- Changes from v2 to v3: Add fixup for 8064 quirk Tested this on IFC6410 which is based of APQ8064. Tested-by: Srinivas Kandagatla Thanks, srini

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-14 Thread Srinivas Kandagatla
On 13/03/2019 22:26, Marc Gonzalez wrote: I needed to see the numeric values, hence the -n flag;-) lspci -vvv -n Here is the output: https://paste.ubuntu.com/p/kFWZ4kXCxT/ Thanks, srini Regards.

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Srinivas Kandagatla
On 13/03/2019 20:39, Marc Gonzalez wrote: working without patch :https://paste.ubuntu.com/p/TJm4hgjGW4/ I have not debugged it any further other than just testing the patch. Let me know if you need any more dumps for more debug. Could you pastebin the output of lspci -vvv -n in the working c

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Srinivas Kandagatla
Hi Marc, On 13/03/2019 11:45, Marc Gonzalez wrote: We don't need to fudge the device class in qcom_pcie_rd_own_conf() because dw_pcie_setup_rc() already does the right thing: /* Program correct class for RC */ dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);

[PATCH 6/8] misc: fastrpc: take into account of overlapping buffers

2019-03-07 Thread Srinivas Kandagatla
crash. Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method") Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 112 +++-- 1 file changed, 98 insertions(+), 14 deletions(-) diff --git a/drivers/misc/fastrpc.c b/dr

[PATCH 7/8] misc: fastrpc: fix remote page size calculation

2019-03-07 Thread Srinivas Kandagatla
ned-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 17bbb017bb08..d0e2e2620087 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -712,6 +712,7

[PATCH 3/8] misc: fastrpc: make sure memory read and writes are visible

2019-03-07 Thread Srinivas Kandagatla
dma_alloc_coherent buffers could have writes queued in store buffers so commit them before sending buffer to DSP using correct dma barriers. Same with vice-versa. Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method") Signed-off-by: Srinivas Kandagatla --- dr

[PATCH 2/8] misc: fastrpc: Fix a possible double free

2019-03-07 Thread Srinivas Kandagatla
(). [srinivas kandagatla]: Cleaned up error path labels and reset init mem to NULL after free Fixes: d73f71c7c6ee("misc: fastrpc: Add support for create remote init process") Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fast

[PATCH 4/8] misc: fastrpc: use correct spinlock variant

2019-03-07 Thread Srinivas Kandagatla
context spin lock can be interrupted from callback path so use correct spinlock so that we do not hit spinlock recursion. Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method") Signed-off-by: Srinivas Kandagatla --- drivers/misc/fast

[PATCH 8/8] misc: fastrpc: increase max init file size to 64 MB

2019-03-07 Thread Srinivas Kandagatla
In some cases where Neural Processing is required the size of init process exceeds default size of 2MB, increase this size to 64MB which is required for QCS404 CDSP Neural Processing. Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 5/8] misc: fastrpc: consider address offset before sending to DSP

2019-03-07 Thread Srinivas Kandagatla
While passing address phy address to DSP, take care of the offset calculated from virtual address vma. Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method") Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 8 1 file changed, 8 insertion

[PATCH 1/8] misc: fastrpc: Avoid free of DMA buffer in interrupt context

2019-03-07 Thread Srinivas Kandagatla
out of the interrupt context. Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method") Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git

[PATCH 0/8] misc: fastrpc: few fixes

2019-03-07 Thread Srinivas Kandagatla
Hi Greg, Doing some stress testing and Neural Processing library showed up some bugs in the code, this patchset fix them. Thanks to Bharath and Krish for testing and helping me debug the issues. Thanks, srini Srinivas Kandagatla (6): misc: fastrpc: make sure memory read and writes are

Re: [PATCH] nvmem: core: don't check the return value of notifier chain call

2019-02-15 Thread Srinivas Kandagatla
ifier callback failures. Drop the retval check. Fixes: bee1138bea15 ("nvmem: add a notifier chain") Cc: sta...@vger.kernel.org Signed-off-by: Bartosz Golaszewski Thanks for the fix! Acked-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 4 +--- 1 file changed, 1 insertion(

[PATCH 1/2] misc: fastrpc: select CONFIG_DMA_SHARED_BUFFER

2019-02-15 Thread Srinivas Kandagatla
fined reference to 'dma_buf_put' ld: fastrpc.c:(.text+0x1abf): undefined reference to 'dma_buf_export' ld: fastrpc.c:(.text+0x1ae7): undefined reference to 'dma_buf_fd' ld: fastrpc.c:(.text+0x1cb5): undefined reference to 'dma_buf_put' ld: fastrpc.c:(.text+0x1cca):

[PATCH 2/2] misc: fastrpc: Fix device_open when no session is available

2019-02-15 Thread Srinivas Kandagatla
From: Thierry Escande This change fixes fastrpc_device_open() when no session is available and return an error in such case. Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[PATCH 0/2] misc: fastrpc: minor fixes.

2019-02-15 Thread Srinivas Kandagatla
Here are two minor fixes, one to fix build error on x86 platforms which do not have CONFIG_DMA_SHARED_BUFFER selected, and other is to hanle possiblity of running out of compute context banks. Thanks, srini Srinivas Kandagatla (1): misc: fastrpc: select CONFIG_DMA_SHARED_BUFFER Thierry

Re: [PATCH] nvmem: core: fix the return value check when calling the notifier chain

2019-02-15 Thread Srinivas Kandagatla
On 15/02/2019 09:41, Bartosz Golaszewski wrote: rval will be masked with STOP MASK, so the above statement could be false even if we have error. So you should consider returning an errono which can be understood by user: may be something like this: if (rval & NOTIFY_STOP_MASK) { rva

Re: mmotm 2019-02-14-15-22 uploaded (drivers/misc/fastrpc.c)

2019-02-15 Thread Srinivas Kandagatla
Thanks for Reporting this Randy, I will send a patch to fix this! On 15/02/2019 03:20, Randy Dunlap wrote: On 2/14/19 3:23 PM, a...@linux-foundation.org wrote: The mm-of-the-moment snapshot 2019-02-14-15-22 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says REA

Re: [PATCH] nvmem: core: fix the return value check when calling the notifier chain

2019-02-15 Thread Srinivas Kandagatla
On 14/02/2019 16:23, Bartosz Golaszewski wrote: diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index f7301bb4ef3b..a3bed2d9aec7 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -687,7 +687,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)

Re: [PATCH 0/4] Add nvmem support on STM32

2019-02-13 Thread Srinivas Kandagatla
On 13/02/2019 10:15, Fabrice Gasnier wrote: On 1/30/19 5:38 PM, Fabrice Gasnier wrote: Non volatile memory area is available on STM32. It contains various factory programmed information such as unique device ID, analog calibration... This patchset adds NVMEM support to access these data. He

[PATCH v2] qcom: apr: Make apr callbacks in non-atomic context

2019-02-08 Thread Srinivas Kandagatla
all the dais to be nonatomic. All the callbacks are now invoked as part of rx work queue. Signed-off-by: Srinivas Kandagatla Reviewed-by: Bjorn Andersson --- Changes since v1: - flush and destroy work queue after removing the device to avoid active communication from device. suggested

[PATCH v7 0/5] misc: Add support to Qualcomm FastRPC driver

2019-02-08 Thread Srinivas Kandagatla
char to misc driver as suggested by Greg KH - updated ioctl data structures as suggested by Arnd. - cleaned up and reorganized most of the code from RFC review comments. Srinivas Kandagatla (5): misc: dt-bindings: Add Qualcomm Fastrpc bindings misc: fastrpc: Add Qualcomm fastrpc basic driver

[PATCH v7 5/5] misc: fastrpc: Add support for dmabuf exporter

2019-02-08 Thread Srinivas Kandagatla
: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 184 include/uapi/misc/fastrpc.h | 8 ++ 2 files changed, 192 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index

[PATCH v7 1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

2019-02-08 Thread Srinivas Kandagatla
-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../devicetree/bindings/misc/qcom,fastrpc.txt | 78 +++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/qcom

[PATCH v7 4/5] misc: fastrpc: Add support for create remote init process

2019-02-08 Thread Srinivas Kandagatla
this code. Specially Tharun Kumar Merugu Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 156 include/uapi/misc/fastrpc.h | 10 +++ 2 files changed, 166 insertions

[PATCH v7 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Srinivas Kandagatla
erry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 730 include/uapi/misc/fastrpc.h | 23 ++ 2 files changed, 753 insertions(+) create mode 100644 include/uapi/misc/fastrpc.h diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fas

[PATCH v7 2/5] misc: fastrpc: Add Qualcomm fastrpc basic driver model

2019-02-08 Thread Srinivas Kandagatla
and is exposed as a character device for userspace interface. Each compute context bank is represented as fastrpc-session-context, which are dynamically managed by the channel context char device. Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla

Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Srinivas Kandagatla
On 08/02/2019 14:11, Greg KH wrote: On 08/02/2019 13:55, Greg KH wrote: + + /* Make sure reserved field is set to 0 */ + if (args->reserved) { + kfree(args); + return -EINVAL; Am I wrong in that you are only checking the

Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Srinivas Kandagatla
Thanks for the review, On 08/02/2019 13:55, Greg KH wrote: + + /* Make sure reserved field is set to 0 */ + if (args->reserved) { + kfree(args); + return -EINVAL; Am I wrong in that you are only checking the first reserved

[PATCH v6 5/5] misc: fastrpc: Add support for dmabuf exporter

2019-02-08 Thread Srinivas Kandagatla
: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 183 include/uapi/misc/fastrpc.h | 8 ++ 2 files changed, 191 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index

[PATCH v6 0/5] misc: Add support to Qualcomm FastRPC driver

2019-02-08 Thread Srinivas Kandagatla
as suggested by Mark Rutland Changes since RFC: - moved from char to misc driver as suggested by Greg KH - updated ioctl data structures as suggested by Arnd. - cleaned up and reorganized most of the code from RFC review comments. Srinivas Kandagatla (5): misc: dt-bindings: Add Qualcomm Fast

[PATCH v6 4/5] misc: fastrpc: Add support for create remote init process

2019-02-08 Thread Srinivas Kandagatla
this code. Specially Tharun Kumar Merugu Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 142 include/uapi/misc/fastrpc.h | 10 +++ 2 files changed, 152 insertions

[PATCH v6 1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

2019-02-08 Thread Srinivas Kandagatla
-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../devicetree/bindings/misc/qcom,fastrpc.txt | 78 +++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/qcom

[PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Srinivas Kandagatla
erry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 741 +++- include/uapi/misc/fastrpc.h | 23 ++ 2 files changed, 763 insertions(+), 1 deletion(-) create mode 100644 include/uapi/misc/fastrpc.h diff --git a/drivers/misc/fastrpc.c b/

[PATCH v6 2/5] misc: fastrpc: Add Qualcomm fastrpc basic driver model

2019-02-08 Thread Srinivas Kandagatla
and is exposed as a character device for userspace interface. Each compute context bank is represented as fastrpc-session-context, which are dynamically managed by the channel context char device. Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla

Re: [PATCH v5 1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

2019-02-08 Thread Srinivas Kandagatla
On 08/02/2019 12:21, Greg KH wrote: On Fri, Feb 01, 2019 at 01:09:21PM +, Srinivas Kandagatla wrote: The FastRPC driver implements an IPC (Inter-Processor Communication) mechanism that allows for clients to transparently make remote method invocations across DSP and APPS boundaries. This

Re: [PATCH v3 2/3] dt-bindings: nvmem: Add bindings for ZynqMP nvmem driver

2019-02-05 Thread Srinivas Kandagatla
On 06/02/2019 11:07, Nava kishore Manne wrote: Add documentation to describe Xilinx ZynqMP nvmem driver bindings. Signed-off-by: Nava kishore Manne Reviewed-by: Rob Herring Acked-by: Srinivas Kandagatla

Re: [PATCH v3 3/3] nvmem: zynqmp: Added zynqmp nvmem firmware driver

2019-02-05 Thread Srinivas Kandagatla
: Add zynqmp_pm_get_chipid() API" Its better to take this patch from the same tree! Acked-by: Srinivas Kandagatla Thanks, srini

Re: [PATCH v2 1/3] firmware: xilinx: Add zynqmp_pm_get_chipid() API

2019-02-05 Thread Srinivas Kandagatla
On 05/02/2019 10:29, Michal Simek wrote: Hi, On 03. 02. 19 9:50, Srinivas Kandagatla wrote: Hi Kishore, I need ack for this patch from Michal Simek to take this via nvmem tree. not sure if my reaction went through. Just for a record. There is high chance that there is collision in

[PATCH] nvmem: allow to select i.MX nvmem driver for i.MX 7D

2019-02-03 Thread Srinivas Kandagatla
From: Stefan Agner The imx-ocotp nvmem driver supports the i.MX 7D SoC too. Allow to select the imx-ocotp driver even if only the i.MX 7D SoC has been selected. Fixes: 711d45477931 ("nvmem: octop: Add i.MX7D support") Signed-off-by: Stefan Agner Signed-off-by: Srinivas Kandagatla -

Re: [PATCH v2 3/3] nvmem: zynqmp: Added zynqmp nvmem firmware driver

2019-02-03 Thread Srinivas Kandagatla
On 04/02/2019 07:09, Nava kishore Manne wrote: -config SC27XX_EFUSE - tristate "Spreadtrum SC27XX eFuse Support" - depends on MFD_SC27XX_PMIC || COMPILE_TEST - depends on HAS_IOMEM Why are you removing SC27XX_EFUSE support here? It does not look right! +config NVMEM_Z

Re: [PATCH v2 1/3] firmware: xilinx: Add zynqmp_pm_get_chipid() API

2019-02-03 Thread Srinivas Kandagatla
Hi Kishore, I need ack for this patch from Michal Simek to take this via nvmem tree. thanks, srini On 04/02/2019 07:09, Nava kishore Manne wrote: This patch adds a new API to provide access to the hardware related data like soc revision, IDCODE... etc. Signed-off-by: Nava kishore Manne --- C

[PATCH v5 5/5] misc: fastrpc: Add support for dmabuf exporter

2019-02-01 Thread Srinivas Kandagatla
: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 182 include/uapi/misc/fastrpc.h | 8 ++ 2 files changed, 190 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index

[PATCH v5 4/5] misc: fastrpc: Add support for create remote init process

2019-02-01 Thread Srinivas Kandagatla
this code. Specially Tharun Kumar Merugu Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 142 include/uapi/misc/fastrpc.h | 10 +++ 2 files changed, 152 insertions

[PATCH v5 1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

2019-02-01 Thread Srinivas Kandagatla
-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../devicetree/bindings/misc/qcom,fastrpc.txt | 78 +++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/qcom

[PATCH v5 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-01 Thread Srinivas Kandagatla
erry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 720 include/uapi/misc/fastrpc.h | 23 ++ 2 files changed, 743 insertions(+) create mode 100644 include/uapi/misc/fastrpc.h diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fas

[PATCH v5 2/5] misc: fastrpc: Add Qualcomm fastrpc basic driver model

2019-02-01 Thread Srinivas Kandagatla
and is exposed as a character device for userspace interface. Each compute context bank is represented as fastrpc-session-context, which are dynamically managed by the channel context char device. Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla

[PATCH v5 0/5] misc: Add support to Qualcomm FastRPC driver

2019-02-01 Thread Srinivas Kandagatla
d by Greg KH. - Removed unnecessary syslog spams. - Added more checks to input validity. Srinivas Kandagatla (5): misc: dt-bindings: Add Qualcomm Fastrpc bindings misc: fastrpc: Add Qualcomm fastrpc basic driver model misc: fastrpc: Add support for context Invoke method misc: fastrpc: Add

Re: [PATCH v4 3/5] misc: fastrpc: Add support for context Invoke method

2019-01-31 Thread Srinivas Kandagatla
Thanks for the review, I will fix them and send new version! On 31/01/2019 15:34, Greg KH wrote: On Thu, Jan 24, 2019 at 03:24:10PM +, Srinivas Kandagatla wrote: This patch adds support to compute context invoke method on the remote processor (DSP). This involves setting up the functions

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-31 Thread Srinivas Kandagatla
On 31/01/2019 16:05, Bjorn Andersson wrote: Sure, but we want the design to allow for that still, either in future upstream or by additional downstream code. Yes, I agree, I don't have solution for this ATM. It will be interesting to see how Intel handles this kind of usecase on there DSP. T

Re: [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel_map

2019-01-31 Thread Srinivas Kandagatla
335 codec") Signed-off-by: Nathan Chancellor --- Acked-by: Srinivas Kandagatla

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-31 Thread Srinivas Kandagatla
On 31/01/2019 01:16, Bjorn Andersson wrote: On Thu 15 Nov 10:49 PST 2018, Srinivas Kandagatla wrote: APR communication with DSP is not atomic in nature. Its request-response type. Trying to pretend that these are atomic and invoking apr client callbacks directly under atomic/irq context has

Re: linux-next: Tree for Jan 29 (SLIMbus & SND_SOC_WCD9335)

2019-01-29 Thread Srinivas Kandagatla
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-5.1&id=a8233b6c1972e1959cf84a021aeb61ddcd23cc26 This should fix the issue! It should be in next today! Thanks, srini On 29/01/2019 16:50, Randy Dunlap wrote: On 1/28/19 10:11 PM, Stephen Rothwell wrote: Hi all

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-29 Thread Srinivas Kandagatla
Hi Andy, Could you queue this up for 5.1 cycle! We would need this to get the audio working on 820c along with WCD9335 slimbus codec! thanks, srini On 15/11/2018 18:49, Srinivas Kandagatla wrote: APR communication with DSP is not atomic in nature. Its request-response type. Trying to

Re: [PATCH 2/3] nvmem: allow to select i.MX nvmem driver for i.MX 7D

2019-01-29 Thread Srinivas Kandagatla
On 28/01/2019 16:07, Stefan Agner wrote: The imx-ocotp nvmem driver supports the i.MX 7D SoC too. Allow to select the imx-ocotp driver even if only the i.MX 7D SoC has been selected. Fixes: 711d45477931 ("nvmem: octop: Add i.MX7D support") Signed-off-by: Stefan Agner Applied thanks, srin

[PATCH 02/13] nvmem: bcm-ocotp: Add ACPI support to BCM OCOTP

2019-01-28 Thread Srinivas Kandagatla
From: Srinath Mannam Add ACPI support to bcm ocotp driver This patch is based on Linux-4.20-rc7. Signed-off-by: Srinath Mannam Acked-by: Scott Branden Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/bcm-ocotp.c | 37 - 1 file changed, 20 insertions

[PATCH 00/13] nvmem: patches for 5.1

2019-01-28 Thread Srinivas Kandagatla
Hi Greg, Here are few nvmem patches which includes - some improvements to nvmem core done by Alban - add support for imx MX7ULP and MX6ULL. - fix block index calculation on sc27xx provider - add ACPI support to BCM OCOTP provider Can you please pick them up for 5.1

[PATCH 03/13] dt-bindings: nvmem: imx-ocotp: add compatible string for i.MX7ULP

2019-01-28 Thread Srinivas Kandagatla
From: Anson Huang Add new compatible string for i.MX7ULP SOC. Signed-off-by: Anson Huang Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH 12/13] nvmem: core: Fix device reference leak

2019-01-28 Thread Srinivas Kandagatla
count. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 1752768dd2d2..5400017ef616 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -811,6

[PATCH 09/13] nvmem: core: Fix cell lookup when no cell is found

2019-01-28 Thread Srinivas Kandagatla
not contained in a struct nvmem_cell the iteration variable then contains an invalid value. This is easily solved by using a variable to iterate over the list and one to return the cell found. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 16

[PATCH 05/13] dt-bindings: imx-ocotp: Add i.MX6ULL/ULZ support

2019-01-28 Thread Srinivas Kandagatla
From: Stefan Wahren Since the i.MX6ULL/ULZ only supports 8 OTP banks we need to introduce a new compatible. Signed-off-by: Stefan Wahren Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 3 ++- 1 file changed, 2

[PATCH 04/13] nvmem: imx-ocotp: add i.MX7ULP support

2019-01-28 Thread Srinivas Kandagatla
From: Anson Huang i.MX7ULP is a new SoC of i.MX family which has 8 kbit eFuse OTP, enable ocotp driver support for this SoC. Signed-off-by: Anson Huang Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvmem/imx

[PATCH 08/13] nvmem: core: Fix of_nvmem_cell_get() for optional cells

2019-01-28 Thread Srinivas Kandagatla
From: Alban Bedel of_nvmem_cell_get() should return -ENOENT when a cell isn't defined, otherwise callers can't distinguish between a missing cell and other errors. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 inser

[PATCH 10/13] nvmem: core: Properly handle connection ID in of_nvmem_device_get()

2019-01-28 Thread Srinivas Kandagatla
, making it impossible to properly implement an optional connection. Return -ENOENT instead to let the caller know that the connection doesn't exists. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 7 --- 1 file changed, 4 insertions(+), 3 dele

[PATCH 06/13] nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support

2019-01-28 Thread Srinivas Kandagatla
From: Stefan Wahren In comparision to the i.MX6UL the lower cost variants i.MX6ULL/ULZ only supports 8 OTP banks a 8 words. Signed-off-by: Stefan Wahren Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvmem

[PATCH 13/13] nvmem: core: Avoid useless iterations in nvmem_cell_get_from_lookup()

2019-01-28 Thread Srinivas Kandagatla
From: Alban Bedel Once the correct cell has been found there is no need to continue iterating, just stop there. While at it replace the goto used to leave the loop with simple break statements. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 5

[PATCH 01/13] nvmem: sc27xx: Convert nvmem offset to block index

2019-01-28 Thread Srinivas Kandagatla
-off-by: Freeman Liu Signed-off-by: Baolin Wang Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sc27xx-efuse.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/nvmem/sc27xx-efuse.c b/drivers/nvmem/sc27xx-efuse.c index 33185d8d82cf..c6ee21018d80 100644

[PATCH 07/13] nvmem: core: Set the provider read-only when no write callback is given

2019-01-28 Thread Srinivas Kandagatla
From: Alban Bedel If no write callback is given the device should be marked as read-only. While at it also move from a bit or to a logical or as that is a logical expression. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2

[PATCH 11/13] nvmem: core: Always reference the device returned by nvmem_device_get()

2019-01-28 Thread Srinivas Kandagatla
e the module and increment the reference count like it is done in the DT path. To fix this we replace the call to nvmem_find() with a call to __nvmem_device_get() which does all the referencing and return a proper ERR_PTR in case of error. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kanda

[PATCH v4 2/5] misc: fastrpc: Add Qualcomm fastrpc basic driver model

2019-01-24 Thread Srinivas Kandagatla
context char device. Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/Kconfig | 10 ++ drivers/misc/Makefile | 1 + drivers/misc/fastrpc.c | 323 + 3 files changed, 334 insertions

[PATCH v4 5/5] misc: fastrpc: Add support for dmabuf exporter

2019-01-24 Thread Srinivas Kandagatla
: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 179 include/uapi/misc/fastrpc.h | 8 ++ 2 files changed, 187 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index

[PATCH v4 4/5] misc: fastrpc: Add support for create remote init process

2019-01-24 Thread Srinivas Kandagatla
this code. Specially Tharun Kumar Merugu Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 141 +++- include/uapi/misc/fastrpc.h | 10 +++ 2 files changed, 150 insertions(+), 1

[PATCH v4 3/5] misc: fastrpc: Add support for context Invoke method

2019-01-24 Thread Srinivas Kandagatla
Qualcomm kernels. Credits to various Qualcomm authors who have contributed to this code. Specially Tharun Kumar Merugu Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 713

[PATCH v4 1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

2019-01-24 Thread Srinivas Kandagatla
-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/misc/qcom,fastrpc.txt | 78 +++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.txt diff --git a

[PATCH v4 0/5] misc: Add support to Qualcomm FastRPC driver

2019-01-24 Thread Srinivas Kandagatla
rt to secure buffers. - reword various bits in bindings suggested by Rob Herring Srinivas Kandagatla (5): misc: dt-bindings: Add Qualcomm Fastrpc bindings misc: fastrpc: Add Qualcomm fastrpc basic driver model misc: fastrpc: Add support for context Invoke method misc: fastrpc: Add support for c

Re: [PATCH v5 2/8] ASoC: wcd9335: add support to wcd9335 codec

2019-01-23 Thread Srinivas Kandagatla
Thanks for the review, On 22/01/2019 18:41, Mark Brown wrote: On Thu, Jan 10, 2019 at 03:06:10PM +, Srinivas Kandagatla wrote: This all looks good apart from a couple of small things that should be easy to fix: diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index

Re: [PATCH v5 4/8] ASoC: wcd9335: add basic controls

2019-01-23 Thread Srinivas Kandagatla
Thanks for the review, On 22/01/2019 18:52, Mark Brown wrote: On Thu, Jan 10, 2019 at 03:06:12PM +, Srinivas Kandagatla wrote: +static const char * const wcd9335_ear_pa_gain_text[] = { + "G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB", +

Re: [PATCH v4 0/2] arm64: dts: qcom: sdm845: Fix DMA allocations for devices with IOMMU

2019-01-18 Thread Srinivas Kandagatla
, finally managed to get both fastrpc and ufs working together with iommu! Tested-by: Srinivas Kandagatla

Re: [PATCH 3/8] nvmem: Add nvmem_cell_get_optional and devm_nvmem_cell_get_optional

2019-01-17 Thread Srinivas Kandagatla
On 16/01/2019 18:26, Alban wrote: What is the real use-case here, it does not make sense to me to add this additional call just to return NULL when cell is not found! It also return NULL when nvmem is not compiled in. I quiet like such convenience functions as they make the driver code much s

Re: [PATCH v3 1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

2019-01-16 Thread Srinivas Kandagatla
Thanks for the review! On 15/01/2019 20:22, Rob Herring wrote: On Mon, Jan 14, 2019 at 07:41:08PM +, Srinivas Kandagatla wrote: The FastRPC driver implements an IPC (Inter-Processor Communication) mechanism that allows for clients to transparently make remote method invocations across DSP

Re: [PATCH 0/8] nvmem: Various small fixes and improvements

2019-01-15 Thread Srinivas Kandagatla
On 06/01/2019 19:28, Alban Bedel wrote: Hi, this series is mostly small bug fixes, but also add a new API to make things simpler in drivers that need to request an optional cell. Alban Bedel (8): nvmem: core: Set the provider read-only when no write callback is given nvmem: core: Fix

Re: [PATCH 3/8] nvmem: Add nvmem_cell_get_optional and devm_nvmem_cell_get_optional

2019-01-15 Thread Srinivas Kandagatla
On 06/01/2019 19:28, Alban Bedel wrote: Add helper functions to make the driver code simpler when a cell is optional. Using these functions just return NULL when the cell doesn't exists or if nvmem is disabled. Signed-off-by: Alban Bedel --- drivers/nvmem/core.c | 48 +

Re: [PATCH 1/2] nvmem: imx-ocotp: add i.MX7ULP support

2019-01-15 Thread Srinivas Kandagatla
On 14/12/2018 08:51, Anson Huang wrote: i.MX7ULP is a new SoC of i.MX family which has 8 kbit eFuse OTP, enable ocotp driver support for this SoC. Signed-off-by: Anson Huang --- drivers/nvmem/imx-ocotp.c | 6 ++ 1 file changed, 6 insertions(+) Thanks Applied both patches! --srini

Re: [PATCH] nvmem: bcm-ocotp: Add ACPI support to BCM OCOTP

2019-01-15 Thread Srinivas Kandagatla
On 27/12/2018 03:39, Srinath Mannam wrote: Add ACPI support to bcm ocotp driver This patch is based on Linux-4.20-rc7. Signed-off-by: Srinath Mannam --- Applied! Thanks, srini

Re: [PATCH] nvmem: sc27xx: Convert nvmem offset to block index

2019-01-15 Thread Srinivas Kandagatla
On 15/01/2019 07:12, Baolin Wang wrote: From: Freeman Liu The Spreadtrum SC27XX efuse data are organized by blocks and each block contains 2 bytes data. Moreover the nvmem core always pass the offset in byte to the controller, so we should change the offset in byte to the correct block index

[PATCH v3 4/5] misc: fastrpc: Add support for create remote init process

2019-01-14 Thread Srinivas Kandagatla
this code. Specially Tharun Kumar Merugu Co-developed-by: Thierry Escande Signed-off-by: Thierry Escande Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 141 +++- include/uapi/misc/fastrpc.h | 10 +++ 2 files changed, 150 insertions(+), 1

<    6   7   8   9   10   11   12   13   14   15   >