Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-21 Thread ulrik . debie-os
On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote: Hi Dmitry, > > On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: > > Will your patch go to stable kernel? > > If yes, that's fine. > > Hmm, it looks like we need this patch after all as we do have screwy > Lenovos with appa

Re: [PATCH 5/7] Input: libps2 - add debugging statements

2018-01-21 Thread ulrik . debie-os
Hi, the patch series looks nice, but best to also include the procedure described here in Documentation/input somewhere. I would not expect everyone to dig into git commit logs to find the howto :) Best regards, Ulrik On Fri, Jan 19, 2018 at 11:41:09AM -0800, Dmitry Torokhov wrote: > Date: F

Re: [PATCH] Input: elantech - support new touchpad IC and extend elan's touchapd command Origianl ic-body field is not sufficient for upcoming IC, Elan ps/2 driver extend the fomation to support futur

2017-08-03 Thread ulrik . debie-os
Hi, Something went wrong with your subject line, it also includes the further commit message lines and the signed off line .. Origianl -> Original fomation .. Do you mean information ? On Wed, Aug 02, 2017 at 07:11:41PM +0800, KT Liao wrote: > > --- > drivers/input/mouse/elantech.c | 28 ++

Re: [PATCH] USB: gtco: remove unnecessary variable assignments

2017-06-15 Thread ulrik . debie-os
Hi Joe, Gustavo, On Wed, Jun 14, 2017 at 10:00:48PM -0700, Joe Perches wrote: > On Wed, 2017-06-14 at 20:50 -0500, Gustavo A. R. Silva wrote: > > Remove unnecessary variable assignments. > > Variable _val_ is overwritten before the value stored in it can be used. > > > > Addresses-Coverity-ID: 13

Re: [PATCH] Input: elantech - Add a special mode for a specific FW The touchapd which sample ver is 0x74 and hw_version is 0x03 have a fw bug which will cause crush sometimes, I add some work-around f

2016-12-02 Thread ulrik . debie-os
Hi, Thank you for the patch, see below my feedback on your patch. Can you provide the contents of fw_verison, capabilities and samples ? It this fw bug present on multiple laptops ? On Fri, Dec 02, 2016 at 01:59:17PM +0800, KT Liao wrote: > Date: Fri, 2 Dec 2016 13:59:17 +0800 > From: KT L

Re: [PATCH 3/3] Input - elantech: Add special check for fw_version 0x470f01 touchpad

2015-08-06 Thread ulrik . debie-os
Hi Dmitry, Duson, On Wed, Aug 05, 2015 at 11:08:18AM -0700, Dmitry Torokhov wrote: > Hi Ulrik, > > On Sun, Aug 02, 2015 at 12:16:41PM +0800, duson wrote: > > It is no need to check the packet[0] for sanity check when doing > > elantech_packet_check_v4() function for fw_version = 0x470f01 touchpad

Re: [PATCH 2/2] Input - elantech: Add special check for fw_version 0x470f01 touchpad

2015-07-28 Thread ulrik . debie-os
Hi Duson, Thanks for your update. Your latest patch has 2 trailing whitespaces problems as shown by checkpatch.pl. There was another comment you probably overlooked in my previous mail: > + if (etd->send_cmd(psmouse, ETP_SAMPLE_QUERY, > + etd->samples)) { Is this wise to run on al

Re: [PATCH] Input - elantech: Add special check for fw_version 0x470f01 touchpad

2015-07-22 Thread ulrik . debie-os
On Wed, Jul 22, 2015 at 09:55:51PM +0800, duson wrote: > > t is no need to check the packet[0] for sanity check when doing > elantech_packet_check_v4() function for fw_version = 0x470f01 touchpad. > Hi Duson, The laptops below also had issues with crc_enabled and they were solved by the elantec

Re: [git pull] Input updates for 3.18-rc4

2014-11-27 Thread ulrik . debie-os
Hi Benjamin, On Wed, Nov 26, 2014 at 09:33:26AM -0500, Benjamin Tissoires wrote: > > Hi Ulrik, > > On Tue, Nov 25, 2014 at 4:23 PM, wrote: > > Hi, > > > > On Wed, Nov 19, 2014 at 11:21:31PM +0100, Marcus Overhagen wrote: > >> Hi, > >> > >> when moving a single finger [3] seems to be one of 0x2

Re: [git pull] Input updates for 3.18-rc4

2014-11-25 Thread ulrik . debie-os
Hi, On Wed, Nov 19, 2014 at 11:21:31PM +0100, Marcus Overhagen wrote: > Hi, > > when moving a single finger [3] seems to be one of 0x21, 0x25, 0x31, 0x35 > moving two fingers [3] seems to be mostly 0x22, 0x26, 0x32, 0x36 but > also sometimes it's 0x42, 0x46, 0x52, 0x56. > It seems to occationall

Re: [git pull] Input updates for 3.18-rc4

2014-11-19 Thread ulrik . debie-os
On Wed, Nov 19, 2014 at 10:49:05PM +0100, Marcus Overhagen wrote: > On Wed, Nov 19, 2014 at 10:05 PM, wrote: > > > Marcus, do you even have a trackpoint ? > This is a clickpad without buttons and without trackpoint. > Looks similar to this image: http://i.imgur.com/5pcCxqa.jpg > > > Marcus, can

Re: [git pull] Input updates for 3.18-rc4

2014-11-19 Thread ulrik . debie-os
Hi, Thanks Dmitry, the fix you provided will mitigate the regression. But there might be more that is going on for v4 hardware. The detection of PACKET_TRACKPOINT can be made more strict. Thank you Marcus and Benjamin for the reports. Sorry for the regression, it was not expected that lowest nibb