> -Original Message-
> From: Borislav Petkov
> Sent: Tuesday, September 4, 2018 1:29 AM
> To: Fan Wu
> Cc: mche...@kernel.org; james.mo...@arm.com; baicar.ty...@gmail.com;
> linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; john.ga...@hu
Thanks tanxiaofei!
Boris/James, are you OK to sign off, or you want to see more tests on
this patch?
Thanks,
Fan
> -Original Message-
> From: tanxiaofei
> Sent: Friday, August 31, 2018 4:06 AM
>
> Hi James,
>
> Our platform do not set CPER_MEM_VALID_MODULE_HANDLE in GHES
> Memory er
Hi Tyler,
> > +static int get_dimm_smbios_index(u16 handle) {
> > + struct mem_ctl_info *mci;
> > + int i;
> > +
> > + mci = ghes_pvt->mci;
> > +
>
> Minor nit: you could define and set mci in the same line to save some space
> here.
>
> Otherwise this patch looks good to me.
Hi Tyler,
> > Is printing the handle to the kernel log critical?
> >
>
> I don't see why we would need this print. The bank/device print is enough to
> map what is shown in dmesg to an SMBIOS entry if that's really needed.
This change is mostly for convenience. I'll revert it since we have two
Hi James,
> > For ghes_edac the bank/device is informational, and nothing would go
> > wrong if the bank/device numbers are the same as another entry. But
> > the handle is now critical for DIMM lookup, thus pull it out.
>
> Is printing the handle to the kernel log critical?
>
> I'd expect somet
Hi James,
> > The current ghes_edac driver does not update per-dimm error counters
> > when reporting memory errors, because there is no platform-independent
> > way to find DIMMs based on the error information provided by firmware.
>
> I'd argue there is: its in the CPER records, we just didn't
Hi Boris,
> If we're going to do this, it needs to be tested on an x86 box which loads
> ghes_edac. Adding Toshi to Cc.
>
> Otherwise it must remain ARM-specific.
Toshi it would be great if you can help! I'll also test the change in x86 but
not sure if the firmware updates module_handle.
> >
Hi James,
> Why get avoid the layer stuff? Isn't counting DIMM/memory-devices what
> EDAC_MC_LAYER_SLOT is for?
Borislav has explained it in his response. Here let me elaborate a little more.
To use the layer information you need an accurate way to pinpoint each
component in the layer and the
8 matches
Mail list logo
