Re: [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)

2012-07-09 Thread yamanetoshi
No problem :-) On Tue, Jul 10, 2012 at 4:33 AM, Greg KH wrote: > On Sun, Jul 08, 2012 at 06:25:47PM +0900, Toshiaki Yamane wrote: >> This change is inspired by checkpatch. >> >> Signed-off-by: Toshiaki Yamane >> --- >> drivers/staging/asus_oled/asus_oled.c |6 +++--- >> 1 files changed, 3

Re: [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)

2012-07-09 Thread yamanetoshi
No problem :-) On Tue, Jul 10, 2012 at 4:33 AM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Jul 08, 2012 at 06:25:47PM +0900, Toshiaki Yamane wrote: This change is inspired by checkpatch. Signed-off-by: Toshiaki Yamane yamaneto...@gmail.com --- drivers/staging/asus_oled/asus_oled.c |

Re: [PATCH] Fix checkpatch.pl issue.

2012-07-08 Thread yamanetoshi
I agree. On Sun, Jul 8, 2012 at 5:36 PM, Jan Ceuleers wrote: > On 07/08/2012 10:16 AM, Toshiaki Yamane wrote: >> -printk(KERN_ERR, to pr_err(... >> >> Signed-off-by: Toshiaki Yamane > > Hi > > I submit that your subject line should be more descriptive. Perhaps > something like the following: >

Re: [PATCH] Fix checkpatch.pl issue.

2012-07-08 Thread yamanetoshi
I agree. On Sun, Jul 8, 2012 at 5:36 PM, Jan Ceuleers jan.ceule...@computer.org wrote: On 07/08/2012 10:16 AM, Toshiaki Yamane wrote: -printk(KERN_ERR, to pr_err(... Signed-off-by: Toshiaki Yamane yamaneto...@gmail.com Hi I submit that your subject line should be more descriptive. Perhaps