Re: + paravirt-vmi-timer-patches.patch added to -mm tree

2007-01-06 Thread Zachary Amsden
Daniel Walker wrote: On Fri, 2006-12-15 at 14:27 -0800, [EMAIL PROTECTED] wrote: + +unsigned long long vmi_sched_clock(void) +{ + return read_available_cycles(); +} + This sched_clock is likely broken if it's returning something other than nanoseconds. It looks like cycles, but

Re: + paravirt-vmi-timer-patches.patch added to -mm tree

2007-01-06 Thread Zachary Amsden
Daniel Walker wrote: On Sat, 2007-01-06 at 12:37 -0800, Zachary Amsden wrote: There is already a dynamic tick (NO_HZ) system in the -mm tree .. Given that this implementation seems unnecessary. Why do you need another different system to do this? We don't. This was written before

Re: + paravirt-vmi-timer-patches.patch added to -mm tree

2007-01-06 Thread Daniel Walker
On Sat, 2007-01-06 at 12:37 -0800, Zachary Amsden wrote: > > > > There is already a dynamic tick (NO_HZ) system in the -mm tree .. Given > > that this implementation seems unnecessary. Why do you need another > > different system to do this? > > > > We don't. This was written before the dynam

Re: + paravirt-vmi-timer-patches.patch added to -mm tree

2007-01-06 Thread Zachary Amsden
Daniel Walker wrote: On Fri, 2006-12-15 at 14:27 -0800, [EMAIL PROTECTED] wrote: + +config NO_IDLE_HZ + bool + depends on PARAVIRT + default y + help + Switches the regular HZ timer off when the system is going idle. + This helps a hypervisor detect tha

Re: + paravirt-vmi-timer-patches.patch added to -mm tree

2007-01-06 Thread Daniel Walker
On Fri, 2006-12-15 at 14:27 -0800, [EMAIL PROTECTED] wrote: > + > +config NO_IDLE_HZ > + bool > + depends on PARAVIRT > + default y > + help > + Switches the regular HZ timer off when the system is going > idle. > + This helps a hypervisor detect that the Lin

Re: + paravirt-vmi-timer-patches.patch added to -mm tree

2007-01-06 Thread Daniel Walker
On Fri, 2006-12-15 at 14:27 -0800, [EMAIL PROTECTED] wrote: > + > +unsigned long long vmi_sched_clock(void) > +{ > + return read_available_cycles(); > +} > + This sched_clock is likely broken if it's returning something other than nanoseconds. It looks like cycles, but it's also getting pi