Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-28 Thread Greg KH
On Sat, Jul 27, 2013 at 09:39:43PM -0700, David Miller wrote: > From: Greg KH > Date: Sat, 27 Jul 2013 21:16:16 -0700 > > > On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote: > >> On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: > >> > From: Ben Hutchings > >> > Date: Sat, 27

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-28 Thread Greg KH
On Sat, Jul 27, 2013 at 09:39:43PM -0700, David Miller wrote: From: Greg KH gre...@linuxfoundation.org Date: Sat, 27 Jul 2013 21:16:16 -0700 On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote: On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: From: Ben Hutchings

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread David Miller
From: Greg KH Date: Sat, 27 Jul 2013 21:16:16 -0700 > On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote: >> On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: >> > From: Ben Hutchings >> > Date: Sat, 27 Jul 2013 16:58:28 +0100 >> > >> > > I'm not so sure this is suitable for

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread Greg KH
On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote: > On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: > > From: Ben Hutchings > > Date: Sat, 27 Jul 2013 16:58:28 +0100 > > > > > I'm not so sure this is suitable for stable. It doesn't seem to be > > > helpful to either userland

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread Ben Hutchings
On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: > From: Ben Hutchings > Date: Sat, 27 Jul 2013 16:58:28 +0100 > > > I'm not so sure this is suitable for stable. It doesn't seem to be > > helpful to either userland or kernel code. > > > > In the kernel, we were checking that ver == 1 and

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread David Miller
From: Ben Hutchings Date: Sat, 27 Jul 2013 16:58:28 +0100 > I'm not so sure this is suitable for stable. It doesn't seem to be > helpful to either userland or kernel code. > > In the kernel, we were checking that ver == 1 and type == 1 thus this > wasn't hurting us. > > If userland does

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread Ben Hutchings
On Fri, 2013-07-26 at 13:46 -0700, Greg Kroah-Hartman wrote: > 3.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Changli Gao > > [ Upstream commit b1a5a34bd0b8767ea689e68f8ea513e9710b671e ] > > Ver and type in pppoe_hdr should be

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread Ben Hutchings
On Fri, 2013-07-26 at 13:46 -0700, Greg Kroah-Hartman wrote: 3.10-stable review patch. If anyone has any objections, please let me know. -- From: Changli Gao xiao...@gmail.com [ Upstream commit b1a5a34bd0b8767ea689e68f8ea513e9710b671e ] Ver and type in pppoe_hdr

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread David Miller
From: Ben Hutchings b...@decadent.org.uk Date: Sat, 27 Jul 2013 16:58:28 +0100 I'm not so sure this is suitable for stable. It doesn't seem to be helpful to either userland or kernel code. In the kernel, we were checking that ver == 1 and type == 1 thus this wasn't hurting us. If

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread Ben Hutchings
On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: From: Ben Hutchings b...@decadent.org.uk Date: Sat, 27 Jul 2013 16:58:28 +0100 I'm not so sure this is suitable for stable. It doesn't seem to be helpful to either userland or kernel code. In the kernel, we were checking that ver

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread Greg KH
On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote: On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: From: Ben Hutchings b...@decadent.org.uk Date: Sat, 27 Jul 2013 16:58:28 +0100 I'm not so sure this is suitable for stable. It doesn't seem to be helpful to either

Re: [ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-27 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Sat, 27 Jul 2013 21:16:16 -0700 On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote: On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: From: Ben Hutchings b...@decadent.org.uk Date: Sat, 27 Jul 2013 16:58:28 +0100 I'm not

[ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-26 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Changli Gao [ Upstream commit b1a5a34bd0b8767ea689e68f8ea513e9710b671e ] Ver and type in pppoe_hdr should be swapped as defined by RFC2516 section-4. Signed-off-by: David S. Miller

[ 06/79] net: Swap ver and type in pppoe_hdr

2013-07-26 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Changli Gao xiao...@gmail.com [ Upstream commit b1a5a34bd0b8767ea689e68f8ea513e9710b671e ] Ver and type in pppoe_hdr should be swapped as defined by RFC2516 section-4. Signed-off-by: David S.