Re: [GIT PULL] HID for 4.11

On Wed, Mar 1, 2017 at 9:58 AM, Dmitry Torokhov wrote: > > Given that it does work for you just apply it. The objections I raised > was more of a bikeshedding. Ok. Patch applied directly and in my tree now, Linus

Re: [GIT PULL] HID for 4.11

On Wed, Mar 1, 2017 at 9:58 AM, Dmitry Torokhov wrote: > > Given that it does work for you just apply it. The objections I raised > was more of a bikeshedding. Ok. Patch applied directly and in my tree now, Linus

Re: [GIT PULL] HID for 4.11

On Wed, Mar 1, 2017 at 1:03 AM, Benjamin Tissoires wrote: > > As Peter mentioned in the bug, there is a missing property on the kernel > node (INPUT_PROP_BUTTONPAD). > > The thing is this property is solely driven in the current driver by the > provided

Re: [GIT PULL] HID for 4.11

On Wed, Mar 1, 2017 at 1:03 AM, Benjamin Tissoires wrote: > > As Peter mentioned in the bug, there is a missing property on the kernel > node (INPUT_PROP_BUTTONPAD). > > The thing is this property is solely driven in the current driver by the > provided platform_data, so there is no way we ever

Re: [GIT PULL] HID for 4.11

Hi Benjamin, On Wed, Mar 01, 2017 at 10:06:35AM +0100, Benjamin Tissoires wrote: > [I forgot to add Dmitry in the loop, sorry for the noise.] > > On Mar 01 2017 or thereabouts, Benjamin Tissoires wrote: > > On Feb 28 2017 or thereabouts, Linus Torvalds wrote: > > > On Tue, Feb 28, 2017 at 7:24

Re: [GIT PULL] HID for 4.11

Hi Benjamin, On Wed, Mar 01, 2017 at 10:06:35AM +0100, Benjamin Tissoires wrote: > [I forgot to add Dmitry in the loop, sorry for the noise.] > > On Mar 01 2017 or thereabouts, Benjamin Tissoires wrote: > > On Feb 28 2017 or thereabouts, Linus Torvalds wrote: > > > On Tue, Feb 28, 2017 at 7:24

Re: [GIT PULL] HID for 4.11

On Wed, Mar 01, 2017 at 09:54:07AM -0800, Linus Torvalds wrote: > On Wed, Mar 1, 2017 at 1:03 AM, Benjamin Tissoires > wrote: > > > > As Peter mentioned in the bug, there is a missing property on the kernel > > node (INPUT_PROP_BUTTONPAD). > > > > The thing is this

Re: [GIT PULL] HID for 4.11

On Wed, Mar 01, 2017 at 09:54:07AM -0800, Linus Torvalds wrote: > On Wed, Mar 1, 2017 at 1:03 AM, Benjamin Tissoires > wrote: > > > > As Peter mentioned in the bug, there is a missing property on the kernel > > node (INPUT_PROP_BUTTONPAD). > > > > The thing is this property is solely driven in

Re: [GIT PULL] HID for 4.11

On 02/28/2017 09:05 PM, Linus Torvalds wrote: On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer wrote: I suspect you're just triggering a bug that wasn't triggered by the ps/2 emulation. you can run linput-debug-events --verbose and have a look at the various state

Re: [GIT PULL] HID for 4.11

On 02/28/2017 09:05 PM, Linus Torvalds wrote: On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer wrote: I suspect you're just triggering a bug that wasn't triggered by the ps/2 emulation. you can run linput-debug-events --verbose and have a look at the various state debugging information, that

Re: [GIT PULL] HID for 4.11

On Feb 28 2017 or thereabouts, Linus Torvalds wrote: > On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer > wrote: > > > > I suspect you're just triggering a bug that wasn't triggered by the ps/2 > > emulation. you can run linput-debug-events --verbose and have a look at

Re: [GIT PULL] HID for 4.11

On Feb 28 2017 or thereabouts, Linus Torvalds wrote: > On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer > wrote: > > > > I suspect you're just triggering a bug that wasn't triggered by the ps/2 > > emulation. you can run linput-debug-events --verbose and have a look at the > > various state

Re: [GIT PULL] HID for 4.11

[I forgot to add Dmitry in the loop, sorry for the noise.] On Mar 01 2017 or thereabouts, Benjamin Tissoires wrote: > On Feb 28 2017 or thereabouts, Linus Torvalds wrote: > > On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer > > wrote: > > > > > > I suspect you're just

Re: [GIT PULL] HID for 4.11

[I forgot to add Dmitry in the loop, sorry for the noise.] On Mar 01 2017 or thereabouts, Benjamin Tissoires wrote: > On Feb 28 2017 or thereabouts, Linus Torvalds wrote: > > On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer > > wrote: > > > > > > I suspect you're just triggering a bug that wasn't

Re: [GIT PULL] HID for 4.11

On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer wrote: > > I suspect you're just triggering a bug that wasn't triggered by the ps/2 > emulation. you can run linput-debug-events --verbose and have a look at the > various state debugging information, that may hint at

Re: [GIT PULL] HID for 4.11

On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer wrote: > > I suspect you're just triggering a bug that wasn't triggered by the ps/2 > emulation. you can run linput-debug-events --verbose and have a look at the > various state debugging information, that may hint at what's going on (e.g. > a

Re: [GIT PULL] HID for 4.11

On Tue, Feb 28, 2017 at 06:31:10PM -0800, Andrew Duggan wrote: > On 02/28/2017 04:56 PM, Linus Torvalds wrote: > > On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds > > wrote: > > > Yeah, so enabling HID_RMI makes my touchpad work again. > > .. so I just noticed

Re: [GIT PULL] HID for 4.11

On Tue, Feb 28, 2017 at 06:31:10PM -0800, Andrew Duggan wrote: > On 02/28/2017 04:56 PM, Linus Torvalds wrote: > > On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds > > wrote: > > > Yeah, so enabling HID_RMI makes my touchpad work again. > > .. so I just noticed something: it works subtly

Re: [GIT PULL] HID for 4.11

On 02/28/2017 04:56 PM, Linus Torvalds wrote: On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds wrote: Yeah, so enabling HID_RMI makes my touchpad work again. .. so I just noticed something: it works subtly differently. When I drag something around, I mostly just

Re: [GIT PULL] HID for 4.11

On 02/28/2017 04:56 PM, Linus Torvalds wrote: On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds wrote: Yeah, so enabling HID_RMI makes my touchpad work again. .. so I just noticed something: it works subtly differently. When I drag something around, I mostly just double-tap and move, and that

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds wrote: > > Yeah, so enabling HID_RMI makes my touchpad work again. .. so I just noticed something: it works subtly differently. When I drag something around, I mostly just double-tap and move, and that still works

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds wrote: > > Yeah, so enabling HID_RMI makes my touchpad work again. .. so I just noticed something: it works subtly differently. When I drag something around, I mostly just double-tap and move, and that still works fine. But sometimes I click (and

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

One of the main reasons Wacom devices have historically required a special driver is that the HID descriptors on their branded devices are useless. A generic driver would only know the length of a report; no information about the contents or layout is actually provided by the hardware. The latest

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

One of the main reasons Wacom devices have historically required a special driver is that the HID descriptors on their branded devices are useless. A generic driver would only know the length of a report; no information about the contents or layout is actually provided by the hardware. The latest

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On 02/21/2017 06:17 AM, Jiri Kosina wrote: On Mon, 20 Feb 2017, Linus Torvalds wrote: I'll have a more specific commit (or range) soon. Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics touchpads using hid-rmi"). And the reason seems to be stupid: I don't have RMI enabled at

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On 02/21/2017 06:17 AM, Jiri Kosina wrote: On Mon, 20 Feb 2017, Linus Torvalds wrote: I'll have a more specific commit (or range) soon. Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics touchpads using hid-rmi"). And the reason seems to be stupid: I don't have RMI enabled at

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, 21 Feb 2017, Benjamin Tissoires wrote: > Well, Wacom devices use to need a special driver, but the latest > generation should somewhat be able to work without a driver (IIRC). I vaguely recall this wasn't the case at all for the older generations I've had my hands on, and it wasn't

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, 21 Feb 2017, Benjamin Tissoires wrote: > Well, Wacom devices use to need a special driver, but the latest > generation should somewhat be able to work without a driver (IIRC). I vaguely recall this wasn't the case at all for the older generations I've had my hands on, and it wasn't

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Feb 21 2017 or thereabouts, Jiri Kosina wrote: > On Mon, 20 Feb 2017, Linus Torvalds wrote: > > > > I'll have a more specific commit (or range) soon. > > > > Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics > > touchpads using hid-rmi"). > > > > And the reason seems to be

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Feb 21 2017 or thereabouts, Jiri Kosina wrote: > On Mon, 20 Feb 2017, Linus Torvalds wrote: > > > > I'll have a more specific commit (or range) soon. > > > > Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics > > touchpads using hid-rmi"). > > > > And the reason seems to be

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Feb 21 2017 or thereabouts, Linus Torvalds wrote: > On Tue, Feb 21, 2017 at 7:46 AM, Jiri Kosina wrote: > > On Tue, 21 Feb 2017, Linus Torvalds wrote: > >> > >> .. and maybe we should do this same thing for the WACOM case a couple > >> of lines up from your patch? > > > >

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Feb 21 2017 or thereabouts, Linus Torvalds wrote: > On Tue, Feb 21, 2017 at 7:46 AM, Jiri Kosina wrote: > > On Tue, 21 Feb 2017, Linus Torvalds wrote: > >> > >> .. and maybe we should do this same thing for the WACOM case a couple > >> of lines up from your patch? > > > > Well, that's far more

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, Feb 21, 2017 at 7:46 AM, Jiri Kosina wrote: > On Tue, 21 Feb 2017, Linus Torvalds wrote: >> >> .. and maybe we should do this same thing for the WACOM case a couple >> of lines up from your patch? > > Well, that's far more questionable. I am pretty sure Wacom devices are

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, Feb 21, 2017 at 7:46 AM, Jiri Kosina wrote: > On Tue, 21 Feb 2017, Linus Torvalds wrote: >> >> .. and maybe we should do this same thing for the WACOM case a couple >> of lines up from your patch? > > Well, that's far more questionable. I am pretty sure Wacom devices are > completely

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, 21 Feb 2017, Linus Torvalds wrote: > > I agree; that's in line with what we usually try to stick to (force > > specific drivers if the device doesn't work with the generic at all and > > switch over to generic in compile-time for devices that have limited > > functionality with the

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, 21 Feb 2017, Linus Torvalds wrote: > > I agree; that's in line with what we usually try to stick to (force > > specific drivers if the device doesn't work with the generic at all and > > switch over to generic in compile-time for devices that have limited > > functionality with the

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, Feb 21, 2017 at 6:17 AM, Jiri Kosina wrote: > > I agree; that's in line with what we usually try to stick to (force > specific drivers if the device doesn't work with the generic at all and > switch over to generic in compile-time for devices that have limited >

Re: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Tue, Feb 21, 2017 at 6:17 AM, Jiri Kosina wrote: > > I agree; that's in line with what we usually try to stick to (force > specific drivers if the device doesn't work with the generic at all and > switch over to generic in compile-time for devices that have limited > functionality with the

[PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Mon, 20 Feb 2017, Linus Torvalds wrote: > > I'll have a more specific commit (or range) soon. > > Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics > touchpads using hid-rmi"). > > And the reason seems to be stupid: I don't have RMI enabled at all, > because that didn't use to

[PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11)

On Mon, 20 Feb 2017, Linus Torvalds wrote: > > I'll have a more specific commit (or range) soon. > > Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics > touchpads using hid-rmi"). > > And the reason seems to be stupid: I don't have RMI enabled at all, > because that didn't use to

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 8:13 PM, Linus Torvalds wrote: > > Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics > touchpads using hid-rmi"). > > And the reason seems to be stupid: I don't have RMI enabled at all, > because that didn't use to work or make a

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 8:13 PM, Linus Torvalds wrote: > > Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics > touchpads using hid-rmi"). > > And the reason seems to be stupid: I don't have RMI enabled at all, > because that didn't use to work or make a difference. > > Maybe that

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 7:03 PM, Linus Torvalds wrote: > > I'll have a more specific commit (or range) soon. Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics touchpads using hid-rmi"). And the reason seems to be stupid: I don't have RMI enabled at

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 7:03 PM, Linus Torvalds wrote: > > I'll have a more specific commit (or range) soon. Hmm. It's commit 279967a65b32 ("HID: rmi: Handle all Synaptics touchpads using hid-rmi"). And the reason seems to be stupid: I don't have RMI enabled at all, because that didn't use to

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 7:03 PM, Linus Torvalds wrote: > > It's bisecting right into the HID pull request, so you can consider > that confirmed. There's something badly broken in this pull. Side note, the touchpad messages from a working kernel are as psmouse

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 7:03 PM, Linus Torvalds wrote: > > It's bisecting right into the HID pull request, so you can consider > that confirmed. There's something badly broken in this pull. Side note, the touchpad messages from a working kernel are as psmouse serio1: synaptics: Touchpad

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 6:48 PM, Linus Torvalds wrote: > On Mon, Feb 20, 2017 at 7:20 AM, Jiri Kosina wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus >> >> to receive HID subsystem updates for 4.11: > > The

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 6:48 PM, Linus Torvalds wrote: > On Mon, Feb 20, 2017 at 7:20 AM, Jiri Kosina wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus >> >> to receive HID subsystem updates for 4.11: > > The touchpad on my XPS13 no longer works. It might not

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 7:20 AM, Jiri Kosina wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus > > to receive HID subsystem updates for 4.11: The touchpad on my XPS13 no longer works. It might not be this pull request, and I'll bisect the exact

Re: [GIT PULL] HID for 4.11

On Mon, Feb 20, 2017 at 7:20 AM, Jiri Kosina wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus > > to receive HID subsystem updates for 4.11: The touchpad on my XPS13 no longer works. It might not be this pull request, and I'll bisect the exact cause, but this

[GIT PULL] HID for 4.11

Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus to receive HID subsystem updates for 4.11: = - a lot of Wacom driver updates; most notably second generation Intuos Pro is now supported, code from Aaron Armstrong Skomra and Jason Gerecke -

[GIT PULL] HID for 4.11

Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus to receive HID subsystem updates for 4.11: = - a lot of Wacom driver updates; most notably second generation Intuos Pro is now supported, code from Aaron Armstrong Skomra and Jason Gerecke -