Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

2016-07-05 Thread Suravee Suthikulpanit
Hi Paolo, On 6/21/16 10:15, Paolo Bonzini wrote: On 21/06/2016 15:50, Joerg Roedel wrote: The code has a few style issues (thing I'd implemented differently), but it looks functional. Anyway, before merging this the last 3 patches need to be acked by the KVM maintainers. Paolo? I think pat

Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

2016-06-21 Thread Suravee Suthikulanit
On 6/21/2016 9:46 AM, Joerg Roedel wrote: On Tue, Jun 21, 2016 at 09:27:27AM -0500, Suthikulpanit, Suravee wrote: On 6/21/2016 8:50 AM, Joerg Roedel wrote: The code has a few style issues (thing I'd implemented differently), but it looks functional. Anything in particular that you think I sho

Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

2016-06-21 Thread Paolo Bonzini
On 21/06/2016 15:50, Joerg Roedel wrote: > The code has a few style issues (thing I'd implemented differently), but > it looks functional. Anyway, before merging this the last 3 patches need > to be acked by the KVM maintainers. > > Paolo? I think patches 9 and 10 should be squashed because the

Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

2016-06-21 Thread Joerg Roedel
On Tue, Jun 21, 2016 at 09:27:27AM -0500, Suthikulpanit, Suravee wrote: > On 6/21/2016 8:50 AM, Joerg Roedel wrote: > >The code has a few style issues (thing I'd implemented differently), but > >it looks functional. > > Anything in particular that you think I should improve or/and change? One thi

Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

2016-06-21 Thread Suravee Suthikulanit
On 6/21/2016 8:50 AM, Joerg Roedel wrote: The code has a few style issues (thing I'd implemented differently), but it looks functional. Anything in particular that you think I should improve or/and change? Thanks, Suravee

Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

2016-06-21 Thread Joerg Roedel
On Mon, Jun 13, 2016 at 05:06:40PM -0500, Suravee Suthikulpanit wrote: > Suravee Suthikulpanit (10): > iommu/amd: Detect and enable guest vAPIC support > iommu/amd: Add support for 128-bit IRTE > iommu/amd: Detect and initialize guest vAPIC log > iommu/amd: Adding GALOG interrupt handler >

[PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

2016-06-13 Thread Suravee Suthikulpanit
CHANGES FROM V1 === * Rename the new mode from ga to vapic to be consistent with the current terminology used in KVM for guest virtual APIC (1/10 and 2/10). * Rename the member enum amd_iommu_intr_mode_type, and provide helper functions (1/10 and 2/10). * Re-factor the