Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-26 Thread Al Viro
On Wed, Nov 21, 2007 at 03:24:33PM -0800, Andrew Morton wrote: > -repeat: > - if (atomic_dec_and_lock(>mnt_count, _lock)) { > + while (atomic_dec_and_lock(>mnt_count, _lock)) { > if (likely(!mnt->mnt_pinned)) { > spin_unlock(_lock); >

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-26 Thread Al Viro
On Wed, Nov 21, 2007 at 03:24:33PM -0800, Andrew Morton wrote: -repeat: - if (atomic_dec_and_lock(mnt-mnt_count, vfsmount_lock)) { + while (atomic_dec_and_lock(mnt-mnt_count, vfsmount_lock)) { if (likely(!mnt-mnt_pinned)) {

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-21 Thread Dmitri Vorobiev
Andrew Morton пишет: > On Thu, 22 Nov 2007 01:49:19 +0300 > Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > >> Zach Brown пишет: > This doesn't look fine. Did you test this? Oops, my fault. Of course, I tested the patch, but kernel modules are disabled in my test setup, so I missed

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-21 Thread Andrew Morton
On Thu, 22 Nov 2007 01:49:19 +0300 Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > Zach Brown пишет: > >>> This doesn't look fine. Did you test this? > >> Oops, my fault. Of course, I tested the patch, but kernel modules are > >> disabled in my test setup, so I missed the error. > > > > :) > > >

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-21 Thread Dmitri Vorobiev
Zach Brown пишет: >>> This doesn't look fine. Did you test this? >> Oops, my fault. Of course, I tested the patch, but kernel modules are >> disabled in my test setup, so I missed the error. > > :) > >> Enclosed to this message is a new patch, which replaces the goto-loop by >> the while-based

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-21 Thread Dmitri Vorobiev
Zach Brown пишет: This doesn't look fine. Did you test this? Oops, my fault. Of course, I tested the patch, but kernel modules are disabled in my test setup, so I missed the error. :) Enclosed to this message is a new patch, which replaces the goto-loop by the while-based one, but

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-21 Thread Andrew Morton
On Thu, 22 Nov 2007 01:49:19 +0300 Dmitri Vorobiev [EMAIL PROTECTED] wrote: Zach Brown пишет: This doesn't look fine. Did you test this? Oops, my fault. Of course, I tested the patch, but kernel modules are disabled in my test setup, so I missed the error. :) Enclosed to this

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

2007-11-21 Thread Dmitri Vorobiev
Andrew Morton пишет: On Thu, 22 Nov 2007 01:49:19 +0300 Dmitri Vorobiev [EMAIL PROTECTED] wrote: Zach Brown пишет: This doesn't look fine. Did you test this? Oops, my fault. Of course, I tested the patch, but kernel modules are disabled in my test setup, so I missed the error. :)