Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-22 Thread Andrew Morton
> On Tue, 22 Jan 2008 08:12:08 -0800 (PST) Alex Dubov <[EMAIL PROTECTED]> wrote: > > --- Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Wed, 2 Jan 2008 17:42:24 +1100 [EMAIL PROTECTED] wrote: > > > > > From: Alex Dubov <[EMAIL PROTECTED]> > > > > > > Sony MemoryStick cards are used in many

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-22 Thread Alex Dubov
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 2 Jan 2008 17:42:24 +1100 [EMAIL PROTECTED] wrote: > > > From: Alex Dubov <[EMAIL PROTECTED]> > > > > Sony MemoryStick cards are used in many products manufactured by Sony. They > > are available both as storage and as IO expansion cards.

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-15 Thread Alex Dubov
--- Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: > Hello, > > > Sony MemoryStick cards are used in many products manufactured by Sony. They > > are available both as storage and as IO expansion cards. Currently, only > > MemoryStick Pro storage cards are supported via TI FlashMedia MemoryStick >

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-15 Thread Mariusz Kozlowski
Hello, > Sony MemoryStick cards are used in many products manufactured by Sony. They > are available both as storage and as IO expansion cards. Currently, only > MemoryStick Pro storage cards are supported via TI FlashMedia MemoryStick > interface. I tried it here and it doesn't work. My Vaio (PC

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-13 Thread Alex Dubov
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 2 Jan 2008 17:42:24 +1100 [EMAIL PROTECTED] wrote: > > > From: Alex Dubov <[EMAIL PROTECTED]> > > > > Sony MemoryStick cards are used in many products manufactured by Sony. They > > are available both as storage and as IO expansion cards.

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-13 Thread Miguel Botón
This happens when trying to compile memory stick support inside the kernel. drivers/memstick/core/mspro_block.o: In function `memstick_priv': mspro_block.c:(.text+0x0): multiple definition of `memstick_priv' drivers/memstick/core/memstick.o:memstick.c:(.text+0x0): first defined here drivers/memsti

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-11 Thread Jens Axboe
On Thu, Jan 10 2008, Andrew Morton wrote: > > +static void mspro_block_request(struct request_queue *q) > > +{ > > + struct memstick_dev *card = q->queuedata; > > + struct mspro_block_data *msb = memstick_get_drvdata(card); > > + struct request *req = NULL; > > + > > + if (!msb->q_thread) {

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-10 Thread Andrew Morton
On Wed, 2 Jan 2008 17:42:24 +1100 [EMAIL PROTECTED] wrote: > From: Alex Dubov <[EMAIL PROTECTED]> > > Sony MemoryStick cards are used in many products manufactured by Sony. They > are available both as storage and as IO expansion cards. Currently, only > MemoryStick Pro storage cards are support

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Alex Dubov
--- Carlos Corbacho <[EMAIL PROTECTED]> wrote: > > So do we require changes to the userspace udev rules here, or just some use > of > modalias in the drivers? > It was handled by whoever manages the distro's udev rules until now. Here's the example: https://lists.ubuntu.com/archives/ubuntu

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Carlos Corbacho
On Monday 31 December 2007 01:01:08 Alex Dubov wrote: > This is exactly the same as with tifm_sd module if you noticed. Unfortunately not, I've really never used tifm_sd as I don't have any MMC/ SD cards. > Second, it is impossible to guess in advance, which type of card is put > into slot (Pro,

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Alex Dubov
--- Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Dec 31 2007 00:01, Carlos Corbacho wrote: > >On Monday 24 December 2007 03:06:37 [EMAIL PROTECTED] wrote: > >> From: Alex Dubov <[EMAIL PROTECTED]> > >> > >> Sony MemoryStick cards are used in many products manufactured by Sony. They > >> are

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Alex Dubov
> However, my only concerns are that: > > 1) tifm_ms was not autoloaded > 2) On loading tifm_ms, only memstick was autoloaded - mspro_block was not. > > Although, whether this is an issue with userspace (ie. udev) not dealing with > the modules properly, I don't know. > This is exactly the sam

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Carlos Corbacho
On Monday 31 December 2007 00:31:12 Jan Engelhardt wrote: > On Dec 31 2007 00:01, Carlos Corbacho wrote: > >On Monday 24 December 2007 03:06:37 [EMAIL PROTECTED] wrote: > >> From: Alex Dubov <[EMAIL PROTECTED]> > >> > >> Sony MemoryStick cards are used in many products manufactured by Sony. > >> Th

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Jan Engelhardt
On Dec 31 2007 00:01, Carlos Corbacho wrote: >On Monday 24 December 2007 03:06:37 [EMAIL PROTECTED] wrote: >> From: Alex Dubov <[EMAIL PROTECTED]> >> >> Sony MemoryStick cards are used in many products manufactured by Sony. They >> are available both as storage and as IO expansion cards. Currently

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Carlos Corbacho
Mostly just stylistic comments from me here. On Monday 24 December 2007 03:06:37 [EMAIL PROTECTED] wrote: > From: Alex Dubov <[EMAIL PROTECTED]> > > Sony MemoryStick cards are used in many products manufactured by Sony. They > are available both as storage and as IO expansion cards. Currently, onl