Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-09-01 Thread Viet Nga Dao
On Thu, Aug 20, 2015 at 2:55 PM, wrote: > From: VIET NGA DAO > > Altera Quad SPI Controller is a soft IP which enables access to > Altera EPCS and EPCQ flash chips. This patch adds driver > for these devices. > > Signed-off-by: VIET NGA DAO > > --- > v5: > - Remove Micron support > - Add

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-09-01 Thread Viet Nga Dao
On Thu, Aug 20, 2015 at 2:55 PM, wrote: > From: VIET NGA DAO > > Altera Quad SPI Controller is a soft IP which enables access to > Altera EPCS and EPCQ flash chips. This patch adds driver > for these devices. > > Signed-off-by: VIET NGA DAO

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Fri, Aug 21, 2015 at 4:37 AM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 05:18:14PM +0800, Viet Nga Dao wrote: >> You might misunderstand the hardware problem i mention here. This soft >> IP controller is able to provide the ID for our Altera EPCS/EPCQ flash >> chips, which are non JEDEC

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 10:19:25 PM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 12:06:36PM +0200, Alexander Stein wrote: > > On Thursday 20 August 2015 10:03:38, Marek Vasut wrote: > > > > +Example: > > > > + > > > > + quadspi_controller_0: quadspi@0x180014a0 { > >

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 11:42:18AM +0200, Marek Vasut wrote: > On Thursday, August 20, 2015 at 11:18:14 AM, Viet Nga Dao wrote: > > You might misunderstand the hardware problem i mention here. This soft > > IP controller is able to provide the ID for our Altera EPCS/EPCQ flash > > chips, which are

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 05:18:14PM +0800, Viet Nga Dao wrote: > You might misunderstand the hardware problem i mention here. This soft > IP controller is able to provide the ID for our Altera EPCS/EPCQ flash > chips, which are non JEDEC chips. As from EPCQ device data sheet >

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 12:06:36PM +0200, Alexander Stein wrote: > On Thursday 20 August 2015 10:03:38, Marek Vasut wrote: > > > +Example: > > > + > > > + quadspi_controller_0: quadspi@0x180014a0 { > > > + compatible = "altr,quadspi-1.0"; > > > +

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Alexander Stein
Hello Marek, On Thursday 20 August 2015 10:03:38, Marek Vasut wrote: > > +Example: > > + > > + quadspi_controller_0: quadspi@0x180014a0 { > > + compatible = "altr,quadspi-1.0"; > > + reg = <0x180014a0 0x0020>, > > +

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 11:18:14 AM, Viet Nga Dao wrote: Hi, [...] > >> That is why we decided to upstream the > >> driver. If the hardware fix, there might not need to have any changes > >> in driver to support or if yes, it will be just minor. > > > > If the hardware can do proper

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Thu, Aug 20, 2015 at 4:52 PM, Marek Vasut wrote: > On Thursday, August 20, 2015 at 10:13:30 AM, Nga Chi wrote: >> On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut wrote: >> > On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: >> >> From: VIET NGA DAO >> >> >> >> Altera Quad SPI

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 10:17:57 AM, Viet Nga Dao wrote: > Sorry for missing to reply the last question Hi! > >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c > >>> b/drivers/mtd/spi-nor/spi-nor.c index 14a5d23..2ab7279 100644 > >>> --- a/drivers/mtd/spi-nor/spi-nor.c > >>> +++

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 10:13:30 AM, Nga Chi wrote: > On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut wrote: > > On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: > >> From: VIET NGA DAO > >> > >> Altera Quad SPI Controller is a soft IP which enables access to > >>

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
Sorry for missing to reply the last question On Thu, Aug 20, 2015 at 4:13 PM, Nga Chi wrote: > On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut wrote: >> On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: >>> From: VIET NGA DAO >>> >>> Altera Quad SPI Controller is a soft IP

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Nga Chi
On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut wrote: > On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: >> From: VIET NGA DAO >> >> Altera Quad SPI Controller is a soft IP which enables access to >> Altera EPCS and EPCQ flash chips. This patch adds driver >> for these devices.

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: > From: VIET NGA DAO > > Altera Quad SPI Controller is a soft IP which enables access to > Altera EPCS and EPCQ flash chips. This patch adds driver > for these devices. > > Signed-off-by: VIET NGA DAO > > --- > v5: > -

[PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread vndao
From: VIET NGA DAO Altera Quad SPI Controller is a soft IP which enables access to Altera EPCS and EPCQ flash chips. This patch adds driver for these devices. Signed-off-by: VIET NGA DAO --- v5: - Remove Micron support - Add multiple flashes probe failure handle v4: - Add more flash devices

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: From: VIET NGA DAO vn...@altera.com Altera Quad SPI Controller is a soft IP which enables access to Altera EPCS and EPCQ flash chips. This patch adds driver for these devices. Signed-off-by: VIET NGA DAO vn...@altera.com

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Thu, Aug 20, 2015 at 4:52 PM, Marek Vasut ma...@denx.de wrote: On Thursday, August 20, 2015 at 10:13:30 AM, Nga Chi wrote: On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut ma...@denx.de wrote: On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: From: VIET NGA DAO

[PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread vndao
From: VIET NGA DAO vn...@altera.com Altera Quad SPI Controller is a soft IP which enables access to Altera EPCS and EPCQ flash chips. This patch adds driver for these devices. Signed-off-by: VIET NGA DAO vn...@altera.com --- v5: - Remove Micron support - Add multiple flashes probe failure

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
Sorry for missing to reply the last question On Thu, Aug 20, 2015 at 4:13 PM, Nga Chi ngach...@gmail.com wrote: On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut ma...@denx.de wrote: On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: From: VIET NGA DAO vn...@altera.com Altera

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Nga Chi
On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut ma...@denx.de wrote: On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: From: VIET NGA DAO vn...@altera.com Altera Quad SPI Controller is a soft IP which enables access to Altera EPCS and EPCQ flash chips. This patch adds driver

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 10:13:30 AM, Nga Chi wrote: On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut ma...@denx.de wrote: On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: From: VIET NGA DAO vn...@altera.com Altera Quad SPI Controller is a soft IP which enables

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 10:17:57 AM, Viet Nga Dao wrote: Sorry for missing to reply the last question Hi! diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 14a5d23..2ab7279 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 11:18:14 AM, Viet Nga Dao wrote: Hi, [...] That is why we decided to upstream the driver. If the hardware fix, there might not need to have any changes in driver to support or if yes, it will be just minor. If the hardware can do proper READID opcode,

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Alexander Stein
Hello Marek, On Thursday 20 August 2015 10:03:38, Marek Vasut wrote: +Example: + + quadspi_controller_0: quadspi@0x180014a0 { + compatible = altr,quadspi-1.0; + reg = 0x180014a0 0x0020, +

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Fri, Aug 21, 2015 at 4:37 AM, Brian Norris computersforpe...@gmail.com wrote: On Thu, Aug 20, 2015 at 05:18:14PM +0800, Viet Nga Dao wrote: You might misunderstand the hardware problem i mention here. This soft IP controller is able to provide the ID for our Altera EPCS/EPCQ flash chips,

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 11:42:18AM +0200, Marek Vasut wrote: On Thursday, August 20, 2015 at 11:18:14 AM, Viet Nga Dao wrote: You might misunderstand the hardware problem i mention here. This soft IP controller is able to provide the ID for our Altera EPCS/EPCQ flash chips, which are non

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 12:06:36PM +0200, Alexander Stein wrote: On Thursday 20 August 2015 10:03:38, Marek Vasut wrote: +Example: + + quadspi_controller_0: quadspi@0x180014a0 { + compatible = altr,quadspi-1.0; + reg =

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 05:18:14PM +0800, Viet Nga Dao wrote: You might misunderstand the hardware problem i mention here. This soft IP controller is able to provide the ID for our Altera EPCS/EPCQ flash chips, which are non JEDEC chips. As from EPCQ device data sheet

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Marek Vasut
On Thursday, August 20, 2015 at 10:19:25 PM, Brian Norris wrote: On Thu, Aug 20, 2015 at 12:06:36PM +0200, Alexander Stein wrote: On Thursday 20 August 2015 10:03:38, Marek Vasut wrote: +Example: + + quadspi_controller_0: quadspi@0x180014a0 { +