Re: [PATCH] .gitignore: Add compilation database files

2019-07-23 Thread Nick Desaulniers
On Tue, Jul 23, 2019 at 9:28 AM Toru Komatsu wrote: > I'm begginer because this patch is my first time, > What should I do next? https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/ TL;DR $ git commit --amend $ git form

Re: [PATCH] .gitignore: Add compilation database files

2019-07-23 Thread Masahiro Yamada
On Wed, Jul 24, 2019 at 1:28 AM Toru Komatsu wrote: > > On 07/24, Masahiro Yamada wrote: > > Just a nit. > > > > The patch title is: > > .gitignore: Add compilation database "files" > > > > Maybe, should it be singular? > > > > > > On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu wrote: > > > > > > T

Re: [PATCH] .gitignore: Add compilation database files

2019-07-23 Thread Toru Komatsu
On 07/24, Masahiro Yamada wrote: > Just a nit. > > The patch title is: > .gitignore: Add compilation database "files" > > Maybe, should it be singular? > > > On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu wrote: > > > > This file is used by clangd to use language server protocol. > > It can be g

Re: [PATCH] .gitignore: Add compilation database files

2019-07-23 Thread Masahiro Yamada
Just a nit. The patch title is: .gitignore: Add compilation database "files" Maybe, should it be singular? On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu wrote: > > This file is used by clangd to use language server protocol. > It can be generated at each compile using scripts/gen_compile_comman

Re: [PATCH] .gitignore: Add compilation database files

2019-07-22 Thread Nick Desaulniers
On Sun, Jul 21, 2019 at 1:54 AM Toru Komatsu wrote: > > This file is used by clangd to use language server protocol. > It can be generated at each compile using scripts/gen_compile_commands.py. > Therefore it is different depending on the environment and should be > ignored. > > Signed-off-by: Tor

[PATCH] .gitignore: Add compilation database files

2019-07-21 Thread Toru Komatsu
This file is used by clangd to use language server protocol. It can be generated at each compile using scripts/gen_compile_commands.py. Therefore it is different depending on the environment and should be ignored. Signed-off-by: Toru Komatsu --- .gitignore | 3 +++ 1 file changed, 3 insertions(+