Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-02-05 Thread Uwe Kleine-König
On Mon, Feb 05, 2018 at 04:10:20PM +0800, Shawn Guo wrote: > On Sat, Jan 27, 2018 at 09:37:11PM +0100, Benoît Thébaudeau wrote: > > On Sat, Jan 27, 2018 at 4:37 PM, Uwe Kleine-König > > wrote: > > > On Sat, Jan 27, 2018 at 01:07:52AM +0100, Benoît Thébaudeau wrote: > > >> The eSDHC does not work p

Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-02-05 Thread Shawn Guo
On Sat, Jan 27, 2018 at 09:37:11PM +0100, Benoît Thébaudeau wrote: > On Sat, Jan 27, 2018 at 4:37 PM, Uwe Kleine-König > wrote: > > On Sat, Jan 27, 2018 at 01:07:52AM +0100, Benoît Thébaudeau wrote: > >> The eSDHC does not work properly if the SION bit is not set for the > >> bidirectional CMD sig

Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-27 Thread Uwe Kleine-König
On Sat, Jan 27, 2018 at 09:37:11PM +0100, Benoît Thébaudeau wrote: > On Sat, Jan 27, 2018 at 4:37 PM, Uwe Kleine-König > wrote: > > On Sat, Jan 27, 2018 at 01:07:52AM +0100, Benoît Thébaudeau wrote: > >> The eSDHC does not work properly if the SION bit is not set for the > >> bidirectional CMD sig

Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-27 Thread Benoît Thébaudeau
On Sat, Jan 27, 2018 at 4:37 PM, Uwe Kleine-König wrote: > On Sat, Jan 27, 2018 at 01:07:52AM +0100, Benoît Thébaudeau wrote: >> The eSDHC does not work properly if the SION bit is not set for the >> bidirectional CMD signal, whatever the eSDHC instance and the selected >> pad. Therefore, setting

Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-27 Thread Uwe Kleine-König
On Sat, Jan 27, 2018 at 01:07:52AM +0100, Benoît Thébaudeau wrote: > The eSDHC does not work properly if the SION bit is not set for the > bidirectional CMD signal, whatever the eSDHC instance and the selected > pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do > this for MX25_P

Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-26 Thread Fabio Estevam
On Fri, Jan 26, 2018 at 10:07 PM, Benoît Thébaudeau wrote: > The eSDHC does not work properly if the SION bit is not set for the > bidirectional CMD signal, whatever the eSDHC instance and the selected > pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do > this for MX25_PAD_*__S

[PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-26 Thread Benoît Thébaudeau
The eSDHC does not work properly if the SION bit is not set for the bidirectional CMD signal, whatever the eSDHC instance and the selected pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do this for MX25_PAD_*__SD*_CMD in imx25-pinfunc.h in order to enforce this behavior for all