Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-05-22 Thread Barry Song
2014-05-22 19:27 GMT+08:00 Russell King - ARM Linux : > On Thu, May 22, 2014 at 07:04:14PM +0800, Barry Song wrote: >> 2014-05-22 17:33 GMT+08:00 Russell King - ARM Linux : >> > On Tue, Apr 29, 2014 at 11:40:33PM +0800, Barry Song wrote: >> >> 2014-04-29 23:14 GMT+08:00 Russell King - ARM Linux >>

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-05-22 Thread Russell King - ARM Linux
On Thu, May 22, 2014 at 07:04:14PM +0800, Barry Song wrote: > 2014-05-22 17:33 GMT+08:00 Russell King - ARM Linux : > > On Tue, Apr 29, 2014 at 11:40:33PM +0800, Barry Song wrote: > >> 2014-04-29 23:14 GMT+08:00 Russell King - ARM Linux > >> : > >> > On Tue, Apr 29, 2014 at 11:05:06PM +0800, Barry

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-05-22 Thread Barry Song
2014-05-22 17:33 GMT+08:00 Russell King - ARM Linux : > On Tue, Apr 29, 2014 at 11:40:33PM +0800, Barry Song wrote: >> 2014-04-29 23:14 GMT+08:00 Russell King - ARM Linux : >> > On Tue, Apr 29, 2014 at 11:05:06PM +0800, Barry Song wrote: >> >> 2014-04-28 22:52 GMT+08:00 Russell King - ARM Linux >>

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-05-22 Thread Russell King - ARM Linux
On Tue, Apr 29, 2014 at 11:40:33PM +0800, Barry Song wrote: > 2014-04-29 23:14 GMT+08:00 Russell King - ARM Linux : > > On Tue, Apr 29, 2014 at 11:05:06PM +0800, Barry Song wrote: > >> 2014-04-28 22:52 GMT+08:00 Russell King - ARM Linux > >> : > >> > On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-29 Thread Barry Song
2014-04-29 23:14 GMT+08:00 Russell King - ARM Linux : > On Tue, Apr 29, 2014 at 11:05:06PM +0800, Barry Song wrote: >> 2014-04-28 22:52 GMT+08:00 Russell King - ARM Linux : >> > On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt Porter wrote: >> >> The "fix" is tested against bcm281xx and bcm21664 as t

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-29 Thread Russell King - ARM Linux
On Tue, Apr 29, 2014 at 11:05:06PM +0800, Barry Song wrote: > 2014-04-28 22:52 GMT+08:00 Russell King - ARM Linux : > > On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt Porter wrote: > >> The "fix" is tested against bcm281xx and bcm21664 as that is what the > >> l2c cleanup breaks in -next. As mentio

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-29 Thread Barry Song
2014-04-28 21:40 GMT+08:00 Matt Porter : > On Mon, Apr 28, 2014 at 10:15:33AM +0100, Russell King wrote: >> On Sun, Apr 27, 2014 at 08:27:40PM -0400, Matt Porter wrote: >> > l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init() >> > early initcall. In a multi v7 kernel this caus

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-29 Thread Barry Song
2014-04-28 22:52 GMT+08:00 Russell King - ARM Linux : > On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt Porter wrote: >> The "fix" is tested against bcm281xx and bcm21664 as that is what the >> l2c cleanup breaks in -next. As mentioned, I don't have the sirfsoc h/w >> so this first attempt at a fix

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-28 Thread Russell King - ARM Linux
On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt Porter wrote: > The "fix" is tested against bcm281xx and bcm21664 as that is what the > l2c cleanup breaks in -next. As mentioned, I don't have the sirfsoc h/w > so this first attempt at a fix also breaks their platform. It can be > addressed by adding

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-28 Thread Matt Porter
On Mon, Apr 28, 2014 at 09:29:51AM -0500, Felipe Balbi wrote: > On Sun, Apr 27, 2014 at 08:27:40PM -0400, Matt Porter wrote: > > l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init() > > early initcall. In a multi v7 kernel this causes bcm281xx and bcm21664 > > platform to fail

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-28 Thread Felipe Balbi
On Sun, Apr 27, 2014 at 08:27:40PM -0400, Matt Porter wrote: > l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init() > early initcall. In a multi v7 kernel this causes bcm281xx and bcm21664 > platform to fail boot since they have their own pre l2x0 init sequence > that is requir

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-28 Thread Matt Porter
On Mon, Apr 28, 2014 at 10:15:33AM +0100, Russell King wrote: > On Sun, Apr 27, 2014 at 08:27:40PM -0400, Matt Porter wrote: > > l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init() > > early initcall. In a multi v7 kernel this causes bcm281xx and bcm21664 > > platform to fail

Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-28 Thread Russell King - ARM Linux
On Sun, Apr 27, 2014 at 08:27:40PM -0400, Matt Porter wrote: > l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init() > early initcall. In a multi v7 kernel this causes bcm281xx and bcm21664 > platform to fail boot since they have their own pre l2x0 init sequence > that is requir

[PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

2014-04-27 Thread Matt Porter
l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init() early initcall. In a multi v7 kernel this causes bcm281xx and bcm21664 platform to fail boot since they have their own pre l2x0 init sequence that is required. Fix this by checking that a matching OF ID is present before call