Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-15 Thread Jean Delvare
Hi Andrew, On Mon, 14 May 2007 23:34:01 -0700, Andrew Morton wrote: > On Sun, 13 May 2007 01:43:42 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > > --- > > > > Here is the 3rd iteration with the following changes: > > - Modified to be an

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-15 Thread Grant Likely
On 5/15/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Sun, 13 May 2007 01:43:42 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > > Here is the 3rd iteration with the following changes: > - Modified to be an i2c "new style" driver based on

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-15 Thread Andrew Morton
On Sun, 13 May 2007 01:43:42 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > > Here is the 3rd iteration with the following changes: > - Modified to be an i2c "new style" driver based on David Brownell's work > - uses the new prototype for

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-15 Thread Andrew Morton
On Sun, 13 May 2007 01:43:42 -0600 Grant Likely [EMAIL PROTECTED] wrote: Signed-off-by: Grant Likely [EMAIL PROTECTED] --- Here is the 3rd iteration with the following changes: - Modified to be an i2c new style driver based on David Brownell's work - uses the new prototype for

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-15 Thread Grant Likely
On 5/15/07, Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 13 May 2007 01:43:42 -0600 Grant Likely [EMAIL PROTECTED] wrote: Signed-off-by: Grant Likely [EMAIL PROTECTED] --- Here is the 3rd iteration with the following changes: - Modified to be an i2c new style driver based on David

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-15 Thread Jean Delvare
Hi Andrew, On Mon, 14 May 2007 23:34:01 -0700, Andrew Morton wrote: On Sun, 13 May 2007 01:43:42 -0600 Grant Likely [EMAIL PROTECTED] wrote: Signed-off-by: Grant Likely [EMAIL PROTECTED] --- Here is the 3rd iteration with the following changes: - Modified to be an i2c new style

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Andrew Morton
On Sun, 13 May 2007 01:43:42 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > > Here is the 3rd iteration with the following changes: > - Modified to be an i2c "new style" driver based on David Brownell's work > - uses the new prototype for i2c_smbus_read_i2c_block_data() for block data > reads

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Jean Delvare
On Mon, 14 May 2007 11:29:04 -0600, Grant Likely wrote: > BTW, I've just left the driver in drivers/i2c/chips. It seems > sufficiently different from an rtc (and the interface is totally > difference) that putting it in drivers/rtc seems wrong. If you > disagree, I can change this. That's fine

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Grant Likely
Ugh. Well that was a rather sloppy patch on my part. I'll fix up and resubmit. On 5/14/07, Jean Delvare <[EMAIL PROTECTED]> wrote: Hi Grant, On Sun, 13 May 2007 01:43:42 -0600, Grant Likely wrote: > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > > Here is the 3rd iteration with the

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Jean Delvare
Hi Grant, On Sun, 13 May 2007 01:43:42 -0600, Grant Likely wrote: > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > > Here is the 3rd iteration with the following changes: > - Modified to be an i2c "new style" driver based on David Brownell's work Can we see the corresponding

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Jean Delvare
Hi Grant, On Sun, 13 May 2007 01:43:42 -0600, Grant Likely wrote: Signed-off-by: Grant Likely [EMAIL PROTECTED] --- Here is the 3rd iteration with the following changes: - Modified to be an i2c new style driver based on David Brownell's work Can we see the corresponding architecture patch

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Grant Likely
Ugh. Well that was a rather sloppy patch on my part. I'll fix up and resubmit. On 5/14/07, Jean Delvare [EMAIL PROTECTED] wrote: Hi Grant, On Sun, 13 May 2007 01:43:42 -0600, Grant Likely wrote: Signed-off-by: Grant Likely [EMAIL PROTECTED] --- Here is the 3rd iteration with the

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Jean Delvare
On Mon, 14 May 2007 11:29:04 -0600, Grant Likely wrote: BTW, I've just left the driver in drivers/i2c/chips. It seems sufficiently different from an rtc (and the interface is totally difference) that putting it in drivers/rtc seems wrong. If you disagree, I can change this. That's fine with

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-14 Thread Andrew Morton
On Sun, 13 May 2007 01:43:42 -0600 Grant Likely [EMAIL PROTECTED] wrote: Here is the 3rd iteration with the following changes: - Modified to be an i2c new style driver based on David Brownell's work - uses the new prototype for i2c_smbus_read_i2c_block_data() for block data reads instead

[PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-13 Thread Grant Likely
Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- Here is the 3rd iteration with the following changes: - Modified to be an i2c "new style" driver based on David Brownell's work - uses the new prototype for i2c_smbus_read_i2c_block_data() for block data reads instead of a single byte at a

[PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-13 Thread Grant Likely
Signed-off-by: Grant Likely [EMAIL PROTECTED] --- Here is the 3rd iteration with the following changes: - Modified to be an i2c new style driver based on David Brownell's work - uses the new prototype for i2c_smbus_read_i2c_block_data() for block data reads instead of a single byte at a time.

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-11 Thread Jean Delvare
Hi Grant, On Thu, 10 May 2007 14:37:54 -0600, Grant Likely wrote: > Thanks for the comments Jean. I've got some questions/comments below. > > On 5/10/07, Jean Delvare <[EMAIL PROTECTED]> wrote: > > Hi Grant, > > > > On Mon, 7 May 2007 14:45:42 -0600, Grant Likely wrote: > > > Signed-off-by:

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-11 Thread Jean Delvare
Hi Grant, On Thu, 10 May 2007 14:37:54 -0600, Grant Likely wrote: Thanks for the comments Jean. I've got some questions/comments below. On 5/10/07, Jean Delvare [EMAIL PROTECTED] wrote: Hi Grant, On Mon, 7 May 2007 14:45:42 -0600, Grant Likely wrote: Signed-off-by: Grant Likely

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-10 Thread Grant Likely
Thanks for the comments Jean. I've got some questions/comments below. On 5/10/07, Jean Delvare <[EMAIL PROTECTED]> wrote: Hi Grant, On Mon, 7 May 2007 14:45:42 -0600, Grant Likely wrote: > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > drivers/i2c/chips/Kconfig | 10 ++ >

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-10 Thread Alessandro Zummo
On Thu, 10 May 2007 13:48:50 +0200 Jean Delvare <[EMAIL PROTECTED]> wrote: > I know this isn't exactly a RTC chip, but this is still related with > timekeeping, so wouldn't it be better placed under drivers/rtc? > Alessandro, what do you think? Hi, I don't know if the rtc subsystem can

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-10 Thread Jean Delvare
Hi Grant, On Mon, 7 May 2007 14:45:42 -0600, Grant Likely wrote: > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > drivers/i2c/chips/Kconfig | 10 ++ > drivers/i2c/chips/Makefile |1 + > drivers/i2c/chips/ds1682.c | 363 > > 3 files

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-10 Thread Jean Delvare
Hi Grant, On Mon, 7 May 2007 14:45:42 -0600, Grant Likely wrote: Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/i2c/chips/Kconfig | 10 ++ drivers/i2c/chips/Makefile |1 + drivers/i2c/chips/ds1682.c | 363 3 files changed,

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-10 Thread Alessandro Zummo
On Thu, 10 May 2007 13:48:50 +0200 Jean Delvare [EMAIL PROTECTED] wrote: I know this isn't exactly a RTC chip, but this is still related with timekeeping, so wouldn't it be better placed under drivers/rtc? Alessandro, what do you think? Hi, I don't know if the rtc subsystem can offer

Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-10 Thread Grant Likely
Thanks for the comments Jean. I've got some questions/comments below. On 5/10/07, Jean Delvare [EMAIL PROTECTED] wrote: Hi Grant, On Mon, 7 May 2007 14:45:42 -0600, Grant Likely wrote: Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/i2c/chips/Kconfig | 10 ++

[PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-07 Thread Grant Likely
Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/i2c/chips/Kconfig | 10 ++ drivers/i2c/chips/Makefile |1 + drivers/i2c/chips/ds1682.c | 363 3 files changed, 374 insertions(+), 0 deletions(-) create mode 100644

[PATCH] Add driver for Dallas DS1682 elapsed time recorder

2007-05-07 Thread Grant Likely
Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/i2c/chips/Kconfig | 10 ++ drivers/i2c/chips/Makefile |1 + drivers/i2c/chips/ds1682.c | 363 3 files changed, 374 insertions(+), 0 deletions(-) create mode 100644