> That being said, I don't think there's any reason to expect the table to
> show up on anything but i386 and x86_64, and maybe ia64.
I've posted a new patch (http://lkml.org/lkml/2008/1/30/531) that includes
that dependency in the Kconfig (i386, x86_64, ia64)
--
To unsubscribe from this
That being said, I don't think there's any reason to expect the table to
show up on anything but i386 and x86_64, and maybe ia64.
I've posted a new patch (http://lkml.org/lkml/2008/1/30/531) that includes
that dependency in the Kconfig (i386, x86_64, ia64)
--
To unsubscribe from this list:
On Tuesday 29 January 2008 14:15:15 Mike Christie wrote:
> Konrad Rzeszutek wrote:
> > +/*
> > + * Helper functions to parse data properly.
> > + */
> > +static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
> > +{
> > + if (ip[0] == 0 && ip[1] == 0 && ip[2] == 0 && ip[3] == 0 &&
> > + ip[4] ==
On Tue, Jan 29, 2008 at 01:13:28PM -0600, Mike Christie wrote:
> Konrad Rzeszutek wrote:
>> On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]>
wrote: Hey Andrew,
Please add this patch along with Greg KH's
Konrad Rzeszutek wrote:
+/*
+ * Helper functions to parse data properly.
+ */
+static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
+{
+ if (ip[0] == 0 && ip[1] == 0 && ip[2] == 0 && ip[3] == 0 &&
+ ip[4] == 0 && ip[5] == 0 && ip[6] == 0 && ip[7] == 0 &&
+ ip[8] == 0 &&
Konrad Rzeszutek wrote:
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]>
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
Konrad Rzeszutek wrote:
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED]
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
On Tue, Jan 29, 2008 at 01:13:28PM -0600, Mike Christie wrote:
Konrad Rzeszutek wrote:
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED]
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK.
Konrad Rzeszutek wrote:
+/*
+ * Helper functions to parse data properly.
+ */
+static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
+{
+ if (ip[0] == 0 ip[1] == 0 ip[2] == 0 ip[3] == 0
+ ip[4] == 0 ip[5] == 0 ip[6] == 0 ip[7] == 0
+ ip[8] == 0 ip[9] == 0 ip[10] ==
On Tuesday 29 January 2008 14:15:15 Mike Christie wrote:
Konrad Rzeszutek wrote:
+/*
+ * Helper functions to parse data properly.
+ */
+static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
+{
+ if (ip[0] == 0 ip[1] == 0 ip[2] == 0 ip[3] == 0
+ ip[4] == 0 ip[5] == 0 ip[6]
Konrad Rzeszutek wrote:
iBFT is not platform-independent; it only makes sense on platforms with
ACPI (and even then, just barely; ACPI is a poor fit for it and it was
probably "integrated" with ACPI for political reasons.)
The spec just mentions that iBFT table has to be "compatible with an
> iBFT is not platform-independent; it only makes sense on platforms with
> ACPI (and even then, just barely; ACPI is a poor fit for it and it was
> probably "integrated" with ACPI for political reasons.)
The spec just mentions that iBFT table has to be "compatible with an ACPI
table format" and
Doug Maxey wrote:
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
+EXPORT_SYMBOL(find_ibft);
Is this x86-specific? Are suitable Kconfig dependencies in place?
Originally I had it to be x86-specific but was told that I should make it all
platforms since the IBFT is platform
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
> > > +EXPORT_SYMBOL(find_ibft);
> >
> > Is this x86-specific? Are suitable Kconfig dependencies in place?
>
> Originally I had it to be x86-specific but was told that I should make it all
> platforms since the IBFT is platform
On Sunday 27 January 2008 01:01:23 you wrote:
> > On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]>
> > wrote: Hey Andrew,
> >
> > Please add this patch along with Greg KH's kobject fixes.
>
> erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
>
> By
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote:
> > int __initdata user_defined_memmap = 0;
>
> checkpatch should have told you that this "= 0" shouldn't be there. But it
> doesn't.
Ok, this line would be correctly picked up if it was being added by this
author, but this line
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
+EXPORT_SYMBOL(find_ibft);
Is this x86-specific? Are suitable Kconfig dependencies in place?
Originally I had it to be x86-specific but was told that I should make it all
platforms since the IBFT is platform independent.
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED]
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
By what path _does_
iBFT is not platform-independent; it only makes sense on platforms with
ACPI (and even then, just barely; ACPI is a poor fit for it and it was
probably integrated with ACPI for political reasons.)
The spec just mentions that iBFT table has to be compatible with an ACPI
table format and
Konrad Rzeszutek wrote:
iBFT is not platform-independent; it only makes sense on platforms with
ACPI (and even then, just barely; ACPI is a poor fit for it and it was
probably integrated with ACPI for political reasons.)
The spec just mentions that iBFT table has to be compatible with an ACPI
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this = 0 shouldn't be there. But it
doesn't.
Ok, this line would be correctly picked up if it was being added by this
author, but this line is in
Doug Maxey wrote:
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
+EXPORT_SYMBOL(find_ibft);
Is this x86-specific? Are suitable Kconfig dependencies in place?
Originally I had it to be x86-specific but was told that I should make it all
platforms since the IBFT is platform
Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this "= 0" shouldn't be there. But it
doesn't.
checkpatch checks for static initializers, not non-static ones.
Should that be changed?
+ for (pos = (u8 *)hdr; pos < (u8 *)hdr +
Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this = 0 shouldn't be there. But it
doesn't.
checkpatch checks for static initializers, not non-static ones.
Should that be changed?
+ for (pos = (u8 *)hdr; pos (u8 *)hdr + len;
> On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote:
> Hey Andrew,
>
> Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
By what path _does_ iscsi ode get into the tree, anyway? Mike
Please always include a diffstat with non-trivial patches.
> On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote:
> --- a/arch/x86/kernel/setup_32.c
> +++ b/arch/x86/kernel/setup_32.c
lol. You touched x86 code.
--
To unsubscribe from this list: send the line
Please always include a diffstat with non-trivial patches.
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED] wrote:
--- a/arch/x86/kernel/setup_32.c
+++ b/arch/x86/kernel/setup_32.c
lol. You touched x86 code.
goes off to fix the inevitable rejects
--
To unsubscribe from
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED] wrote:
Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
By what path _does_ iscsi ode get into the tree, anyway? Mike is
Hey Andrew,
Please add this patch along with Greg KH's kobject fixes. This module
is dependent on the fixes that Greg KH has in his patches git tree.
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot
Hey Andrew,
Please add this patch along with Greg KH's kobject fixes. This module
is dependent on the fixes that Greg KH has in his patches git tree.
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot
32 matches
Mail list logo
