Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-23 Thread Rene Herman
On 05/23/2007 09:34 PM, Alan Cox wrote: driver was snappy in that regard. When I replaced our sleeping loop with a busy-wait same as the original the snappyness returned and moreover, reading the TOC from the CD went from something close to a minute to approximately a second. Thought that minu

Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-23 Thread Rene Herman
On 05/23/2007 09:28 PM, Ingo Molnar wrote: * Rene Herman <[EMAIL PROTECTED]> wrote: The trouble there is that unless you poll the bloody thing like mad too much of the Q subchannels passes below you and you need a huge number of retries to get anything out of it. I noticed when I started add

Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-23 Thread Alan Cox
> driver was snappy in that regard. When I replaced our sleeping loop with a > busy-wait same as the original the snappyness returned and moreover, reading > the TOC from the CD went from something close to a minute to approximately a > second. Thought that minute was just because I was dealing

Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-23 Thread Ingo Molnar
* Rene Herman <[EMAIL PROTECTED]> wrote: > The trouble there is that unless you poll the bloody thing like mad > too much of the Q subchannels passes below you and you need a huge > number of retries to get anything out of it. I noticed when I started > adding audio bits that the driver took f

Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-23 Thread Rene Herman
On 05/22/2007 12:25 PM, Thomas Gleixner wrote: From: Ingo Molnar <[EMAIL PROTECTED]> The SJCD driver uses a jiffies busy loop. Replace it with msleep. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Acked-by: Thomas Gleixner <[EMAIL PROTECTED]> Okay, that's just waiting for a reset to complet

Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-22 Thread Jens Axboe
On Tue, May 22 2007, Ingo Molnar wrote: > > * Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >@@ -1709,12 +1710,11 @@ static int __init sjcd_init(void) > > > printk(KERN_INFO "SJCD: Resetting: "); > > > sjcd_send_cmd(SCMD_RESET); > > > for (i = 1000; i > 0 && !sjcd_status_valid; --i) { > > >-

Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-22 Thread Ingo Molnar
* Jeff Garzik <[EMAIL PROTECTED]> wrote: > >@@ -1709,12 +1710,11 @@ static int __init sjcd_init(void) > > printk(KERN_INFO "SJCD: Resetting: "); > > sjcd_send_cmd(SCMD_RESET); > > for (i = 1000; i > 0 && !sjcd_status_valid; --i) { > >-unsigned long timer; > >- > >

Re: [PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-22 Thread Jeff Garzik
Thomas Gleixner wrote: From: Ingo Molnar <[EMAIL PROTECTED]> The SJCD driver uses a jiffies busy loop. Replace it with msleep. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Acked-by: Thomas Gleixner <[EMAIL PROTECTED]> --- drivers/cdrom/sjcd.c |6 +++--- 1 file changed, 3 insertions(+),

[PATCH] CDROM: replace jiffies busyloop with msleep

2007-05-22 Thread Thomas Gleixner
From: Ingo Molnar <[EMAIL PROTECTED]> The SJCD driver uses a jiffies busy loop. Replace it with msleep. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Acked-by: Thomas Gleixner <[EMAIL PROTECTED]> --- drivers/cdrom/sjcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: li