Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2019-01-21 Thread Greg KH
On Sat, Jan 19, 2019 at 07:22:50PM +0100, Miguel Ojeda wrote: > Hi Greg, Nick, Xiaozhou, > > On Thu, Dec 6, 2018 at 1:50 PM Greg KH wrote: > > > > If something is fixed in Linus's tree for this, I want to take it into > > the 4.19-stable tree as well. > > This ended up in Linus' tree before the

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2019-01-19 Thread Miguel Ojeda
Hi Greg, Nick, Xiaozhou, On Thu, Dec 6, 2018 at 1:50 PM Greg KH wrote: > > If something is fixed in Linus's tree for this, I want to take it into > the 4.19-stable tree as well. This ended up in Linus' tree before the holidays, i.e. 4.20 has it, see commit 71391bdd2e9a ("include/linux/compiler_t

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-12-06 Thread Greg KH
On Thu, Dec 06, 2018 at 08:39:26PM +0800, Xiaozhou Liu wrote: > On Thu, Nov 29, 2018 at 11:42:11AM +0100, Miguel Ojeda wrote: > > > Exactly, thanks a lot for clarifying it up (we should put this in the > > commit message, I would say). That also answers my question: it is > > clear everything shou

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-12-06 Thread Xiaozhou Liu
On Thu, Nov 29, 2018 at 11:42:11AM +0100, Miguel Ojeda wrote: > Exactly, thanks a lot for clarifying it up (we should put this in the > commit message, I would say). That also answers my question: it is > clear everything should be back into __KERNEL__. The only worry is > that the v4.19 release c

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-12-04 Thread Nick Desaulniers
On Wed, Nov 28, 2018 at 9:35 AM Miguel Ojeda wrote: > > Hi Xiaozhou, > > On Wed, Nov 28, 2018 at 3:09 PM Xiaozhou Liu > wrote: > > > > Attributes such as `__gnu_inline' are meant to be used within the > > kernel. When userspace somehow includes > > (eg. tools/bpf), compilation errors would be s

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-11-29 Thread Miguel Ojeda
On Thu, Nov 29, 2018 at 3:16 AM Xiaozhou Liu wrote: > > On Wed, Nov 28, 2018 at 06:35:18PM +0100, Miguel Ojeda wrote: > > By `these' I mean inline and the like, to be clear. Ah, that makes more sense! Sorry. > > That is not exactly correct -- a3f8a30f3f00 moved some attributes to > > another fil

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-11-28 Thread Miguel Ojeda
On Wed, Nov 28, 2018 at 6:35 PM Miguel Ojeda wrote: > > If your problem is fixed by putting __gnu_inline into __KERNEL__ s/__gnu_inline/inline/ Cheers, Miguel

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-11-28 Thread Miguel Ojeda
Hi Xiaozhou, On Wed, Nov 28, 2018 at 3:09 PM Xiaozhou Liu wrote: > > Attributes such as `__gnu_inline' are meant to be used within the > kernel. When userspace somehow includes > (eg. tools/bpf), compilation errors would be shown: > > "error: unknown type name ‘__gnu_inline’" > > So just

[PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-11-28 Thread Xiaozhou Liu
Attributes such as `__gnu_inline' are meant to be used within the kernel. When userspace somehow includes (eg. tools/bpf), compilation errors would be shown: "error: unknown type name ‘__gnu_inline’" So just move these things into __KERNEL__ and the behavior is kept as before. Fixes: a3