Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-15 Thread Kai-Heng Feng
at 19:42, Hans de Goede wrote: Hi, On 15-04-19 13:36, hotwater...@tutanota.com wrote: Sorry for the delay. By applying this patch I get next results: Five finger tap and two finger scroll issues disappear, but after suspend touchpad dies. Restarting module doesn't help. So bascally the sa

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-15 Thread Hans de Goede
Hi, On 15-04-19 13:36, hotwater...@tutanota.com wrote: Sorry for the delay. By applying this patch I get next results: Five finger tap and two finger scroll issues disappear, but after suspend touchpad dies. Restarting module doesn't help. So bascally the same results as with the edge-trigger

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-13 Thread Kai-Heng Feng
at 16:40, wrote: Hi. I've applied this patch, but still getting incomplete report messages. Does the patch fix the other two issues: - Five finger tap kill's module so you have to restart it; - Two finger scoll is working incorrect and sometimes even when you raised one of two finger still

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-11 Thread Kai-Heng Feng
Hi, at 05:18, wrote: Hi. 1) Run "cat /proc/interrupts | grep ELAN" , note down the value 2) Very quickly/briefly touch the touchpad once 3) Run "cat /proc/interrupts | grep ELAN" , note down the value again 4) Subtract result from 1. from result from 3, this difference is the value we are in

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-03 Thread Hans de Goede
Hi, On 31-03-19 11:50, hotwater...@tutanota.com wrote: Hi. I've done everything you said, here are results: Vladislav can you check the output of /cat/interrupts on a kernel without the patch and while *not* using the touchpad; and check if the amount of touchpads-interrupts still k

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-03 Thread Kai-Heng Feng
...@chromium.org; linux-in...@vger.kernel.org; linux- ker...@vger.kernel.org Subject: Re: [PATCH] ELAN touchpad i2c_hid bugs fix [EXTERNAL EMAIL] On Apr 2, 2019, at 5:37 AM, wrote: -Original Message- From: Andy Shevchenko Sent: Thursday, March 21, 2019 4:48 AM To: Kai-Heng Feng

RE: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-02 Thread Mario.Limonciello
e...@linutronix.de; d...@chromium.org; linux-in...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] ELAN touchpad i2c_hid bugs fix > > > [EXTERNAL EMAIL] > > > > > On Apr 2, 2019, at 5:37 AM, > > wrote: > > > >> -Original Messag

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-01 Thread Kai Heng Feng
; Dmitry Torokhov; open list:HID CORE LAYER; lkml Subject: Re: [PATCH] ELAN touchpad i2c_hid bugs fix [EXTERNAL EMAIL] +Cc: Mario Mario, do you have any insights about the issue with touchpad on Dell system described below? My apologies, this got lost while I was on vacation. On Thu, Mar 21

RE: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-01 Thread Mario.Limonciello
open list:HID CORE > LAYER; lkml > Subject: Re: [PATCH] ELAN touchpad i2c_hid bugs fix > > > [EXTERNAL EMAIL] > > +Cc: Mario > > Mario, do you have any insights about the issue with touchpad on Dell > system described below? My apologies, this got lost while I was on

RE: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-01 Thread 廖崇榮
CORE LAYER; lkml; hotwater...@tutanota.com Subject: Re: [PATCH] ELAN touchpad i2c_hid bugs fix On Fri, Mar 29, 2019 at 5:18 AM Hans de Goede wrote: > > Hi, > > On 3/25/19 5:56 PM, Dmitry Torokhov wrote: > > Hi Hans, > > > > On Mon, Mar 25, 2019 at 9:38 AM Hans de Goe

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-29 Thread Dmitry Torokhov
On Fri, Mar 29, 2019 at 5:18 AM Hans de Goede wrote: > > Hi, > > On 3/25/19 5:56 PM, Dmitry Torokhov wrote: > > Hi Hans, > > > > On Mon, Mar 25, 2019 at 9:38 AM Hans de Goede wrote: > >> > >> Hi Dmitry, > >> > >> On 25-03-19 17:02, Dmitry Torokhov wrote: > >>> Hi Vladislav, > >>> > >>> On Mon, Ma

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-29 Thread Hans de Goede
Hi, On 3/25/19 5:56 PM, Dmitry Torokhov wrote: Hi Hans, On Mon, Mar 25, 2019 at 9:38 AM Hans de Goede wrote: Hi Dmitry, On 25-03-19 17:02, Dmitry Torokhov wrote: Hi Vladislav, On Mon, Mar 25, 2019 at 5:57 AM Vladislav Dalechyn wrote: From: Vladislav Dalechyn Description: The ELAN1200

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-25 Thread Dmitry Torokhov
On Mon, Mar 25, 2019 at 11:23 AM wrote: > > Hi. > > Mar 25, 2019, 6:56 PM by d...@chromium.org: > > If you want to keep on using edge you need to make sure that i2c-hid > never loses edge, as replaying of previously disabled interrupts in > not at all reliable. So you need to "kick" the device aft

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-25 Thread Dmitry Torokhov
Hi Hans, On Mon, Mar 25, 2019 at 9:38 AM Hans de Goede wrote: > > Hi Dmitry, > > On 25-03-19 17:02, Dmitry Torokhov wrote: > > Hi Vladislav, > > > > On Mon, Mar 25, 2019 at 5:57 AM Vladislav Dalechyn > > wrote: > >> > >> From: Vladislav Dalechyn > >> > >> Description: The ELAN1200:04F3:303E tou

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-25 Thread Hans de Goede
Hi Dmitry, On 25-03-19 17:02, Dmitry Torokhov wrote: Hi Vladislav, On Mon, Mar 25, 2019 at 5:57 AM Vladislav Dalechyn wrote: From: Vladislav Dalechyn Description: The ELAN1200:04F3:303E touchpad exposes several issues, all caused by an error setting the correct IRQ_TRIGGER flag: - i2c_hid

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-25 Thread Dmitry Torokhov
Hi Vladislav, On Mon, Mar 25, 2019 at 5:57 AM Vladislav Dalechyn wrote: > > From: Vladislav Dalechyn > > Description: The ELAN1200:04F3:303E touchpad exposes several issues, all > caused by an error setting the correct IRQ_TRIGGER flag: > - i2c_hid incoplete error flood in journalctl; > - Five f

[PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-25 Thread Vladislav Dalechyn
From: Vladislav Dalechyn Description: The ELAN1200:04F3:303E touchpad exposes several issues, all caused by an error setting the correct IRQ_TRIGGER flag: - i2c_hid incoplete error flood in journalctl; - Five finger tap kill's module so you have to restart it; - Two finger scoll is working incorr

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-25 Thread Benjamin Tissoires
Hi Vladislav, we are almost there. When submitting/applying a patch, we do run ./script/checkpatch.pl on the final patch. This gives us here 2 warnings (inlined below) Also, can you versionize your submissions (use `-v` in git format-patch: `git format-patch -v3 HEAD`). On Sun, Mar 24, 2019 at

[PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-24 Thread Vladislav Dalechyn
From: h0tw4t3r Description: The ELAN1200:04F3:303E touchpad exposes several issues, all caused by an error setting the correct IRQ_TRIGGER flag: - i2c_hid incoplete error flood in journalctl; - Five finger tap kill's module so you have to restart it; - Two finger scoll is working inco

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-24 Thread Hans de Goede
42d00 Mon Sep 17 00:00:00 2001 From: h0tw4t3r mailto:hotwater...@tutanota.com>> Date: Wed, 24 Mar 2019 19:14:22 +0200 Subject: [PATCH] ELAN touchpad i2c_hid bugs fix Description: The ELAN1200:04F3:303E touchpad exposes several issues, all caused by an error setting the correct IRQ_T

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-24 Thread Hans de Goede
:00 2001 From: h0tw4t3r mailto:hotwater...@tutanota.com>> Date: Wed, 20 Mar 2019 00:41:22 +0200 Subject: [PATCH] ELAN touchpad i2c_hid bugs fix Description: The ELAN1200:04F3:303E touchpad exposes several issues, all caused by an error setting the correct IRQ_TRIGGER fla

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-21 Thread Andy Shevchenko
+Cc: Mario Mario, do you have any insights about the issue with touchpad on Dell system described below? On Thu, Mar 21, 2019 at 6:08 AM Kai-Heng Feng wrote: > > at 01:18, Andy Shevchenko wrote: > > > On Wed, Mar 20, 2019 at 6:55 PM Kai-Heng Feng > > wrote: > >> at 23:39, Hans de Goede wrote:

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-21 Thread Kai Heng Feng
> On Mar 21, 2019, at 4:55 PM, Andy Shevchenko > wrote: > > On Thu, Mar 21, 2019 at 6:08 AM Kai-Heng Feng > wrote: >> at 01:18, Andy Shevchenko wrote: >>> On Wed, Mar 20, 2019 at 6:55 PM Kai-Heng Feng >>> wrote: at 23:39, Hans de Goede wrote: > On 3/20/19 3:37 PM, Benjamin Tissoi

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-21 Thread Hans de Goede
Hi, On 21-03-19 05:08, Kai-Heng Feng wrote: at 01:18, Andy Shevchenko wrote: On Wed, Mar 20, 2019 at 6:55 PM Kai-Heng Feng wrote: at 23:39, Hans de Goede wrote: On 3/20/19 3:37 PM, Benjamin Tissoires wrote: Benjamin, what I find interesting here is that the BOGUS_IRQ quirk is also used

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-21 Thread Andy Shevchenko
On Thu, Mar 21, 2019 at 6:08 AM Kai-Heng Feng wrote: > at 01:18, Andy Shevchenko wrote: > > On Wed, Mar 20, 2019 at 6:55 PM Kai-Heng Feng > > wrote: > >> at 23:39, Hans de Goede wrote: > >>> On 3/20/19 3:37 PM, Benjamin Tissoires wrote: > >> Recently we found that Elan touchpad doesn’t like Gp

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-20 Thread Kai-Heng Feng
at 01:18, Andy Shevchenko wrote: On Wed, Mar 20, 2019 at 6:55 PM Kai-Heng Feng wrote: at 23:39, Hans de Goede wrote: On 3/20/19 3:37 PM, Benjamin Tissoires wrote: Benjamin, what I find interesting here is that the BOGUS_IRQ quirk is also used on Elan devices, I suspect that these Elan de

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-20 Thread Andy Shevchenko
On Wed, Mar 20, 2019 at 6:55 PM Kai-Heng Feng wrote: > at 23:39, Hans de Goede wrote: > > On 3/20/19 3:37 PM, Benjamin Tissoires wrote: > > Benjamin, what I find interesting here is that the BOGUS_IRQ quirk > > is also used on Elan devices, I suspect that these Elan devices > > likely also need

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-20 Thread Andy Shevchenko
On Wed, Mar 20, 2019 at 4:38 PM Benjamin Tissoires wrote: > On Wed, Mar 20, 2019 at 2:28 PM wrote: > > Patch is created by help of ELANTECH and RedHat guys (Hans De Goede > > , Benjamin Tissoires , Andy > > Shevchenko ) and me (Vladislav Dalechyn > > . > > Don't take it wrong, but that's not

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-20 Thread Kai-Heng Feng
Hi Hans, at 23:39, Hans de Goede wrote: H, On 3/20/19 3:37 PM, Benjamin Tissoires wrote: The reason why i2c_hid_init_irq was moved is told by Hans De Goede : i2c_hid_init_irq now checks for a quirk, so we must setup the quirks before we init the irq, and we cannot setup the quirk earlie

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-20 Thread Hans de Goede
H, On 3/20/19 3:37 PM, Benjamin Tissoires wrote: The reason why i2c_hid_init_irq was moved is told by Hans De Goede : i2c_hid_init_irq now checks for a quirk, so we must setup the quirks before we init the irq, and we cannot setup the quirk earlier, so we must init the irq later. I am pre

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-20 Thread Benjamin Tissoires
Hi Vladislav, I really appreciate the contribution, there are a few issues with the formatting of the patch, thanks for taking care of those (I'll inline the problems). On Wed, Mar 20, 2019 at 2:28 PM wrote: > > Desciption: This patch add's additional quirk to force > IRQ_TRIGGER_FALLING flag wh