Re: [PATCH] Fix checkpatch.pl issue.

2012-07-08 Thread yamanetoshi
I agree. On Sun, Jul 8, 2012 at 5:36 PM, Jan Ceuleers wrote: > On 07/08/2012 10:16 AM, Toshiaki Yamane wrote: >> -printk(KERN_ERR, to pr_err(... >> >> Signed-off-by: Toshiaki Yamane > > Hi > > I submit that your subject line should be more descriptive. Perhaps > something like the following: > >

Re: [PATCH] Fix checkpatch.pl issue.

2012-07-08 Thread Jan Ceuleers
On 07/08/2012 10:16 AM, Toshiaki Yamane wrote: > -printk(KERN_ERR, to pr_err(... > > Signed-off-by: Toshiaki Yamane Hi I submit that your subject line should be more descriptive. Perhaps something like the following: [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...) The rest

[PATCH] Fix checkpatch.pl issue.

2012-07-08 Thread Toshiaki Yamane
-printk(KERN_ERR, to pr_err(... Signed-off-by: Toshiaki Yamane --- drivers/staging/asus_oled/asus_oled.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c index 510d796..f63c1d3 100644 ---