Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-13 Thread Frank Haverkamp
Hi Pavel, Am Dienstag, den 12.11.2013, 14:50 +0100 schrieb Pavel Machek: > Hi! > > > The GenWQE device is a PCIe card used to acclerate different tasks. > > Since it is configurable, it can be adjusted to different purposes. > > Our initial task for the card is to do zlib style compression/decomp

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-12 Thread Pavel Machek
Hi! > The GenWQE device is a PCIe card used to acclerate different tasks. > Since it is configurable, it can be adjusted to different purposes. > Our initial task for the card is to do zlib style compression/decompression > RFC1950, RFC1951, and RFC1952. Is it similar to the Intel's Xeon Phi? The

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-05 Thread Greg KH
On Tue, Nov 05, 2013 at 08:16:24AM +0100, Frank Haverkamp wrote: > Hi Greg, > > Am Montag, den 04.11.2013, 14:15 -0800 schrieb Greg KH: > > > I am using sysfs_create_group() now, but do I understand you > > correctly > > > that setting the const struct attribute_group **groups; in my device > > >

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Hi Greg, Am Montag, den 04.11.2013, 14:15 -0800 schrieb Greg KH: > > I am using sysfs_create_group() now, but do I understand you > correctly > > that setting the const struct attribute_group **groups; in my device > > (where in my struct pci_device.dev?) is an even better way to > establish > > m

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Greg KH
On Mon, Nov 04, 2013 at 05:41:27PM +0100, Frank Haverkamp wrote: > Hi Greg, > > Am Mittwoch, den 30.10.2013, 10:44 -0700 schrieb Greg KH: > > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > > > +/* > > > + * Create device_attribute structures / params: name, mode, show, store >

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Hi Ryan, Am Donnerstag, den 31.10.2013, 14:49 +1100 schrieb Ryan Mallon: > > +/** > > + * create_card_sysfs() - Setup sysfs entries of the card device > > + * > > + * VFs have restricted mmio capabilities, so not all sysfs entries > > + * are allowed in VFs. > > + */ > > +int create_card_sysfs(str

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Hi Ryan, Am Donnerstag, den 31.10.2013, 14:49 +1100 schrieb Ryan Mallon: > > +static ssize_t show_card_status(struct device *dev, > > + struct device_attribute *attr, > > + char *buf) > > +{ > > + ssize_t len = 0; > > + struct genwqe_

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 30.10.2013, 10:44 -0700 schrieb Greg KH: > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > > +/* > > + * Create device_attribute structures / params: name, mode, show, store > > + * additional flag if valid in VF > > + */ > > +struct genwqe_dev_attrib {

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 30.10.2013, 10:37 -0700 schrieb Greg KH: > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > > +/* > > + * We like to be able to disable the health checking entirely in some > > + * cases e.g. if a card is broken and needs to be analyzed. I > > + * consid

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Am Donnerstag, den 31.10.2013, 07:38 +1100 schrieb Ryan Mallon: > On 31/10/13 04:35, Greg KH wrote: > > > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > >> +if GENWQE > >> + > >> +config GENWQE_DEVNAME > >> +string "Name for sysfs and device nodes" > >> + default "genw

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 30.10.2013, 10:35 -0700 schrieb Greg KH: > Don't let the user pick this, it's up to the driver to set this once > and > then live with it. Ok. I will remove it in the next version. > > And, from what I can tell in the driver, this help text is wrong > (there > are no d

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-11-04 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 30.10.2013, 10:36 -0700 schrieb Greg KH: > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > > +/* > > + * Module initialization and PCIe setup. Card health monitoring and > > + * recovery functionality. Character device creation and deletion are > > + *

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Ryan Mallon
On 30/10/13 20:32, Frank Haverkamp wrote: > From: Frank Haverkamp > Signed-off-by: Frank Haverkamp > Co-authors: Joerg-Stephan Vogt , > Michael Jung , > Michael Ruettger > --- > Documentation/ABI/testing/debugfs-driver-genwqe | 57 + > Documentation/ABI/testing/sysfs-

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Ryan Mallon
On 31/10/13 04:35, Greg KH wrote: > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: >> +if GENWQE >> + >> +config GENWQE_DEVNAME >> +string "Name for sysfs and device nodes" >> +default "genwqe" >> +help >> + Select alternate name for sysfs and device

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > +/* > + * Create device_attribute structures / params: name, mode, show, store > + * additional flag if valid in VF > + */ > +struct genwqe_dev_attrib { > + struct device_attribute att;/* sysfs entry attributes */ > + in

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > +/* > + * GenWQE Driver: Need SLC timeout set to 250ms (temporary setting for > + * testing of 1000ms due to decompressor testcase failing) > + * > + * There is a requirement by the card users that the timeout must not > + * exceed

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > +/* > + * We like to be able to disable the health checking entirely in some > + * cases e.g. if a card is broken and needs to be analyzed. I > + * considered using debugfs/sysfs attributes, but I did not see a way > + * to prevent

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > +/* > + * Module initialization and PCIe setup. Card health monitoring and > + * recovery functionality. Character device creation and deletion are > + * controlled from here. > + * > + * Please use the new sysfs interfaces to enabl

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > +if GENWQE > + > +config GENWQE_DEVNAME > +string "Name for sysfs and device nodes" > + default "genwqe" > +help > + Select alternate name for sysfs and device nodes. Don't let the user pick this, it's

[PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

2013-10-30 Thread Frank Haverkamp
The GenWQE device is a PCIe card used to acclerate different tasks. Since it is configurable, it can be adjusted to different purposes. Our initial task for the card is to do zlib style compression/decompression RFC1950, RFC1951, and RFC1952. I kindly ask for your feedback on the code, such that I