Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Mike Frysinger
On Nov 11, 2007 5:52 PM, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > >> Nack, we shoiuld never include userspace headers in kernel headers, > >> an even more never add !__KERNEL__ ifdefs. Just make sure your > >> programs include limit.h before including linux/cdrom.h. > > > >I think header files

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Jan Engelhardt
On Nov 12 2007 13:57, Vegard Nossum wrote: > >This seems like a good time to ask why the kernel doesn't use > for its INT_MAX and type definitions like uint32_t., etc. >>From the manpage: "The header is a subset of the > header more suitable for use in freestanding >environments, which might not

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Vegard Nossum
On Nov 12, 2007 1:06 PM, Andreas Schwab <[EMAIL PROTECTED]> wrote: > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > On Mon, 12 Nov 2007, Andreas Schwab wrote: > > > >> Jan Engelhardt <[EMAIL PROTECTED]> writes: > >> > >> > No, because I be damn sure that some developers try compiling programs

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Andreas Schwab
"Robert P. J. Day" <[EMAIL PROTECTED]> writes: > On Mon, 12 Nov 2007, Andreas Schwab wrote: > >> Jan Engelhardt <[EMAIL PROTECTED]> writes: >> >> > No, because I be damn sure that some developers try compiling programs >> > in non-linux environments (cygwin, solaris, andyourpersonaldistro, you >>

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Robert P. J. Day
On Mon, 12 Nov 2007, Andreas Schwab wrote: > Jan Engelhardt <[EMAIL PROTECTED]> writes: > > > No, because I be damn sure that some developers try compiling programs > > in non-linux environments (cygwin, solaris, andyourpersonaldistro, you > > name it) which do not have to adhere to . It might use

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > No, because I be damn sure that some developers try compiling programs > in non-linux environments (cygwin, solaris, andyourpersonaldistro, you > name it) which do not have to adhere to . It might use > instead, or whatever. Every C compiler has .

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Peter Zijlstra
On Sun, 2007-11-11 at 23:52 +0100, Jan Engelhardt wrote: > >> Nack, we shoiuld never include userspace headers in kernel headers, > >> an even more never add !__KERNEL__ ifdefs. Just make sure your > >> programs include limit.h before including linux/cdrom.h. > > > >I think header files should be

Re: [PATCH] Include header required for INT_MAX

2007-11-11 Thread Jan Engelhardt
>> Nack, we shoiuld never include userspace headers in kernel headers, >> an even more never add !__KERNEL__ ifdefs. Just make sure your >> programs include limit.h before including linux/cdrom.h. > >I think header files should be complete, and should not use undefined >macros, picking up every r

Re: [PATCH] Include header required for INT_MAX

2007-11-10 Thread Thomas Koeller
On Samstag, 10. November 2007, Christoph Hellwig wrote: > On Sat, Nov 10, 2007 at 03:55:15PM +0100, Thomas Koeller wrote: > > cdrom.h uses INT_MAX, so it must include kernel.h or > > limits.h (userspace) for a definition. > > Nack, we shoiuld never include userspace headers in kernel headers, > an

Re: [PATCH] Include header required for INT_MAX

2007-11-10 Thread Alexander E. Patrakov
Thomas Koeller wrote: cdrom.h uses INT_MAX, so it must include kernel.h or limits.h (userspace) for a definition. No, it must be fixed so that it doesn't use this #defined constant. Debian has this: /* Special codes used when specifying changer slots. */ #define CDSL_NONE ((int)

Re: [PATCH] Include header required for INT_MAX

2007-11-10 Thread Christoph Hellwig
On Sat, Nov 10, 2007 at 03:55:15PM +0100, Thomas Koeller wrote: > cdrom.h uses INT_MAX, so it must include kernel.h or > limits.h (userspace) for a definition. Nack, we shoiuld never include userspace headers in kernel headers, an even more never add !__KERNEL__ ifdefs. Just make sure your progra

[PATCH] Include header required for INT_MAX

2007-11-10 Thread Thomas Koeller
cdrom.h uses INT_MAX, so it must include kernel.h or limits.h (userspace) for a definition. Signed-off-by: Thomas Koeller <[EMAIL PROTECTED]> diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h index c6d3e22..bd8064a 100644 --- a/include/linux/cdrom.h +++ b/include/linux/cdrom.h @@ -12,6 +