Re: [PATCH] Input: add support for the Samsung S6SY761 touchscreen

2017-09-24 Thread Andi Shyti
Hi Dmitry, > > > > +static void s6sy761_report_coordinates(struct s6sy761_data *sdata, u8 > > > > *event) > > > > +{ > > > > + u8 tid = ((event[0] & S6SY761_MASK_TID) >> 2) - 1; > > > > > > Should we make sure that event[0] & S6SY761_MASK_TID is not 0? > > > > I check event[0] already in

Re: [PATCH] Input: add support for the Samsung S6SY761 touchscreen

2017-09-22 Thread Dmitry Torokhov
Hi Andi, On Fri, Sep 22, 2017 at 01:17:02PM +0900, Andi Shyti wrote: > Hi Dmitry, > > thanks for your review! > > [...] > > > > +static void s6sy761_report_coordinates(struct s6sy761_data *sdata, u8 > > > *event) > > > +{ > > > + u8 tid = ((event[0] & S6SY761_MASK_TID) >> 2) - 1; > > > > Shou

Re: [PATCH] Input: add support for the Samsung S6SY761 touchscreen

2017-09-21 Thread Andi Shyti
Hi Dmitry, thanks for your review! [...] > > +static void s6sy761_report_coordinates(struct s6sy761_data *sdata, u8 > > *event) > > +{ > > + u8 tid = ((event[0] & S6SY761_MASK_TID) >> 2) - 1; > > Should we make sure that event[0] & S6SY761_MASK_TID is not 0? I check event[0] already in s6sy

Re: [PATCH] Input: add support for the Samsung S6SY761 touchscreen

2017-09-21 Thread Dmitry Torokhov
Hi Andi, On Thu, Sep 21, 2017 at 10:29:50PM +0900, Andi Shyti wrote: > The S6SY761 touchscreen is a capicitive multi-touch controller > for mobile use. It's connected with i2c at the address 0x48. > > This commit provides a basic version of the driver which can > handle only initialization, touch

[PATCH] Input: add support for the Samsung S6SY761 touchscreen

2017-09-21 Thread Andi Shyti
The S6SY761 touchscreen is a capicitive multi-touch controller for mobile use. It's connected with i2c at the address 0x48. This commit provides a basic version of the driver which can handle only initialization, touch events and power states. The controller is controlled by a firmware which, in