Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger

2017-04-14 Thread Jean Delvare
On Thu, 13 Apr 2017 16:49:23 -0700, Dmitry Torokhov wrote: > We should not be forcing edge triggered interrupt, but rather let platform > decide the kind of trigger it needs to use. Also, the driver is not quite > safe with regard to edge-triggered interrupts as it does not try to kick > the contro

Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger

2017-04-14 Thread Christian Gmeiner
2017-04-14 1:49 GMT+02:00 Dmitry Torokhov : > We should not be forcing edge triggered interrupt, but rather let platform > decide the kind of trigger it needs to use. Also, the driver is not quite > safe with regard to edge-triggered interrupts as it does not try to kick > the controller after requ

Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger

2017-04-13 Thread Martin Kepplinger
On 2017-04-14 01:49, Dmitry Torokhov wrote: > We should not be forcing edge triggered interrupt, but rather let platform > decide the kind of trigger it needs to use. Also, the driver is not quite > safe with regard to edge-triggered interrupts as it does not try to kick > the controller after requ

[PATCH] Input: ar1021 - do not force raising edge IRQ trigger

2017-04-13 Thread Dmitry Torokhov
We should not be forcing edge triggered interrupt, but rather let platform decide the kind of trigger it needs to use. Also, the driver is not quite safe with regard to edge-triggered interrupts as it does not try to kick the controller after requesting/enabling IRQ. Signed-off-by: Dmitry Torokhov