Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-27 Thread Dmitry Torokhov
On Fri, May 27, 2016 at 11:14:27AM +0200, Manfred Schlaegl wrote: > Pwm config may sleep so defer it using a worker. > > On a Freescale i.MX53 based board we ran into "BUG: scheduling while > atomic" because input_inject_event locks interrupts, but > imx_pwm_config_v2 sleeps. > > Tested on Freesc

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-27 Thread Manfred Schlaegl
Pwm config may sleep so defer it using a worker. On a Freescale i.MX53 based board we ran into "BUG: scheduling while atomic" because input_inject_event locks interrupts, but imx_pwm_config_v2 sleeps. Tested on Freescale i.MX53 SoC with 4.6.0. Signed-off-by: Manfred Schlaegl --- drivers/input/

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-27 Thread Manfred Schlaegl
On 2016-05-27 10:54, Manfred Schlaegl wrote: > > Ok. Thanks for clarification. > I will send a patch with the modifications you suggested before. > > The following patch will also have some slight modifications in line numbers > to make it apply after > cfae56f18 (input: misc: pwm-beeper: Explic

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-27 Thread Manfred Schlaegl
On 2016-05-26 02:36, Dmitry Torokhov wrote: > On Tue, May 24, 2016 at 10:32:53AM +0200, Manfred Schlaegl wrote: >> On 2016-05-20 18:59, Dmitry Torokhov wrote: >>> Hi Manfred, >>> >>> On Wed, May 18, 2016 at 05:16:49PM +0200, Manfred Schlaegl wrote: @@ -133,6 +149,8 @@ static int pwm_beeper_rem

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-25 Thread Dmitry Torokhov
On Tue, May 24, 2016 at 10:32:53AM +0200, Manfred Schlaegl wrote: > On 2016-05-20 18:59, Dmitry Torokhov wrote: > > Hi Manfred, > > > > On Wed, May 18, 2016 at 05:16:49PM +0200, Manfred Schlaegl wrote: > >> @@ -133,6 +149,8 @@ static int pwm_beeper_remove(struct platform_device > >> *pdev) > >>

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-24 Thread Manfred Schlaegl
Pwm config may sleep so defer it using a worker. On a Freescale i.MX53 based board we ran into "BUG: scheduling while atomic" because input_inject_event locks interrupts, but imx_pwm_config_v2 sleeps. Tested on Freescale i.MX53 SoC with 4.6.0 and 4.1.24. Signed-off-by: Manfred Schlaegl --- dri

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-24 Thread Manfred Schlaegl
On 2016-05-20 18:59, Dmitry Torokhov wrote: > Hi Manfred, > > On Wed, May 18, 2016 at 05:16:49PM +0200, Manfred Schlaegl wrote: >> @@ -133,6 +149,8 @@ static int pwm_beeper_remove(struct platform_device >> *pdev) >> { >> struct pwm_beeper *beeper = platform_get_drvdata(pdev); >> >> +c

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-20 Thread Dmitry Torokhov
Hi Manfred, On Wed, May 18, 2016 at 05:16:49PM +0200, Manfred Schlaegl wrote: > @@ -133,6 +149,8 @@ static int pwm_beeper_remove(struct platform_device *pdev) > { > struct pwm_beeper *beeper = platform_get_drvdata(pdev); > > + cancel_work_sync(&beeper->work); > + > input_unregis

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-19 Thread Manfred Schlaegl
On 2016-05-18 18:06, Greg Kroah-Hartman wrote: > On Wed, May 18, 2016 at 05:16:49PM +0200, Manfred Schlaegl wrote: >> Pwm config may sleep so defer it using a worker. >> >> Trigger: >> On a Freescale i.MX53 based board we ran into "BUG: scheduling while >> atomic" because input_inject_event locks i

Re: [PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-18 Thread Greg Kroah-Hartman
On Wed, May 18, 2016 at 05:16:49PM +0200, Manfred Schlaegl wrote: > Pwm config may sleep so defer it using a worker. > > Trigger: > On a Freescale i.MX53 based board we ran into "BUG: scheduling while > atomic" because input_inject_event locks interrupts, but > imx_pwm_config_v2 sleeps. > > Teste

[PATCH] Input: pwm-beeper - fix: scheduling while atomic

2016-05-18 Thread Manfred Schlaegl
Pwm config may sleep so defer it using a worker. Trigger: On a Freescale i.MX53 based board we ran into "BUG: scheduling while atomic" because input_inject_event locks interrupts, but imx_pwm_config_v2 sleeps. Tested on Freescale i.MX53 SoC with 4.6.0 and 4.1.24. Unmodified applicable to * 4.6