Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-07 Thread Paolo Bonzini
On 07/06/19 18:04, Sean Christopherson wrote: >> That's what came to mind first, but then "extended" had the same issue >> as "full" (i.e. encompassing the "basic" set as well) so I decided you >> knew better! > Ah, I was thinking of "basic" and "extended" as separate states, but your >

Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-07 Thread Sean Christopherson
On Fri, Jun 07, 2019 at 05:17:09PM +0200, Paolo Bonzini wrote: > On 07/06/19 16:18, Sean Christopherson wrote: > > On Fri, Jun 07, 2019 at 02:19:20PM +0200, Paolo Bonzini wrote: > >> On 06/06/19 20:41, Sean Christopherson wrote: > +static void prepare_vmcs02_early_extra(struct vcpu_vmx *vmx,

Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-07 Thread Paolo Bonzini
On 07/06/19 16:18, Sean Christopherson wrote: > On Fri, Jun 07, 2019 at 02:19:20PM +0200, Paolo Bonzini wrote: >> On 06/06/19 20:41, Sean Christopherson wrote: +static void prepare_vmcs02_early_extra(struct vcpu_vmx *vmx, >>> Or maybe 'uncommon', 'rare' or 'ext'? I don't I particularly love

Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-07 Thread Sean Christopherson
On Fri, Jun 07, 2019 at 02:19:20PM +0200, Paolo Bonzini wrote: > On 06/06/19 20:41, Sean Christopherson wrote: > >> +static void prepare_vmcs02_early_extra(struct vcpu_vmx *vmx, > > Or maybe 'uncommon', 'rare' or 'ext'? I don't I particularly love any of > > the names, but they're all better than

Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-07 Thread Paolo Bonzini
On 06/06/19 20:41, Sean Christopherson wrote: >> +static void prepare_vmcs02_early_extra(struct vcpu_vmx *vmx, > Or maybe 'uncommon', 'rare' or 'ext'? I don't I particularly love any of > the names, but they're all better than 'full'. I thought 'ext' was short for 'extra'? :) Paolo

Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-06 Thread Paolo Bonzini
On 06/06/19 21:19, Krish Sadhukhan wrote: > > The big chunk of the work in this function is done via > prepare_vmcs02_constant_state(). It seems cleaner to get rid of > prepare_vmcs02_early_full(), call prepare_vmcs02_constant_state() > directly from prepare_vmcs02_early() and move the three

Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-06 Thread Krish Sadhukhan
On 06/06/2019 11:41 AM, Sean Christopherson wrote: On Thu, Jun 06, 2019 at 05:24:12PM +0200, Paolo Bonzini wrote: These function do not prepare the entire state of the vmcs02, only the rarely needed parts. Rename them to make this clearer. Signed-off-by: Paolo Bonzini ---

Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-06 Thread Sean Christopherson
On Thu, Jun 06, 2019 at 05:24:12PM +0200, Paolo Bonzini wrote: > These function do not prepare the entire state of the vmcs02, only the > rarely needed parts. Rename them to make this clearer. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/vmx/nested.c | 8 > 1 file changed, 4

[PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra

2019-06-06 Thread Paolo Bonzini
These function do not prepare the entire state of the vmcs02, only the rarely needed parts. Rename them to make this clearer. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx/nested.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/vmx/nested.c