Re: [PATCH] KVM: use slowpath for cross page cached accesses

2015-04-08 Thread Wanpeng Li
On Wed, Apr 08, 2015 at 02:16:48PM +0200, Radim Krčmář wrote: >2015-04-08 12:43+0200, Paolo Bonzini: >> On 08/04/2015 11:26, Radim Krčmář wrote: >>> 2015-04-08 10:49+0200, Paolo Bonzini: On 07/04/2015 22:34, Radim Krčmář wrote: > We dirtied only one page because writes originally couldn't

Re: [PATCH] KVM: use slowpath for cross page cached accesses

2015-04-08 Thread Paolo Bonzini
On 08/04/2015 14:16, Radim Krčmář wrote: > 2015-04-08 12:43+0200, Paolo Bonzini: >> On 08/04/2015 11:26, Radim Krčmář wrote: >>> Only cross-memslot writes have NULL memslot. >> >> The power of wrong comments... >> >> Considering how kvm_gfn_to_hva_cache_init is used (one 1-byte field, two >> 4-by

[PATCH] KVM: use slowpath for cross page cached accesses

2015-04-08 Thread Radim Krčmář
2015-04-08 12:43+0200, Paolo Bonzini: > On 08/04/2015 11:26, Radim Krčmář wrote: >> 2015-04-08 10:49+0200, Paolo Bonzini: >>> On 07/04/2015 22:34, Radim Krčmář wrote: We dirtied only one page because writes originally couldn't span more. Use improved syntax for '>> PAGE_SHIFT' while at it