Re: [PATCH] KVM: x86: Fix load damaged SSEx MXCSR register

2017-05-11 Thread Wanpeng Li
2017-05-11 15:44 GMT+08:00 Paolo Bonzini : > > > On 11/05/2017 02:56, Wanpeng Li wrote: >>> Hmm, thinking more about it, maybe use mxcsr_feature_mask instead of >>> digging into vcpu->arch.guest_fpu? If you send v2, please remember to >> ERROR: "mxcsr_feature_mask" [arch/x86/kvm/kvm.ko] undefined.

Re: [PATCH] KVM: x86: Fix load damaged SSEx MXCSR register

2017-05-11 Thread Paolo Bonzini
On 11/05/2017 02:56, Wanpeng Li wrote: >> Hmm, thinking more about it, maybe use mxcsr_feature_mask instead of >> digging into vcpu->arch.guest_fpu? If you send v2, please remember to > ERROR: "mxcsr_feature_mask" [arch/x86/kvm/kvm.ko] undefined. So we > should dig into vcpu->arch.guest_fpu. Ye

Re: [PATCH] KVM: x86: Fix load damaged SSEx MXCSR register

2017-05-10 Thread Wanpeng Li
2017-05-10 23:35 GMT+08:00 Paolo Bonzini : > > > On 10/05/2017 12:19, Wanpeng Li wrote: >>* with old userspace. >>*/ >> - if (xstate_bv & ~kvm_supported_xcr0()) >> + if (xstate_bv & ~kvm_supported_xcr0() || >> + mxcsr & >>

Re: [PATCH] KVM: x86: Fix load damaged SSEx MXCSR register

2017-05-10 Thread Paolo Bonzini
On 10/05/2017 12:19, Wanpeng Li wrote: >* with old userspace. >*/ > - if (xstate_bv & ~kvm_supported_xcr0()) > + if (xstate_bv & ~kvm_supported_xcr0() || > + mxcsr & > ~vcpu->arch.guest_fpu.state.xsave.i387.mxcsr_mask) >

Re: [PATCH] KVM: x86: Fix load damaged SSEx MXCSR register

2017-05-10 Thread Paolo Bonzini
On 10/05/2017 12:19, Wanpeng Li wrote: > From: Wanpeng Li > > Reported by syzkaller: > >BUG: unable to handle kernel paging request at c07f6a2e >IP: report_bug+0x94/0x120 >PGD 348e12067 >P4D 348e12067 >PUD 348e14067 >PMD 3cbd84067 >PTE 8003f7e87161 >

[PATCH] KVM: x86: Fix load damaged SSEx MXCSR register

2017-05-10 Thread Wanpeng Li
From: Wanpeng Li Reported by syzkaller: BUG: unable to handle kernel paging request at c07f6a2e IP: report_bug+0x94/0x120 PGD 348e12067 P4D 348e12067 PUD 348e14067 PMD 3cbd84067 PTE 8003f7e87161 Oops: 0003 [#1] SMP CPU: 2 PID: 7091 Comm: kvm_load_gue