Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-29 Thread Daniel Drake
Dave Jones wrote: The patch content looks ok to me, Daniel, ack? Works for me, thanks. Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-29 Thread Dave Jones
On Mon, May 21, 2007 at 04:47:43PM -1000, Joshua Hoblitt wrote: apologies for the delay in getting back to this. > Here is cleaned up version of Ed's patch that I believe addresses Dave's > stylistic concerns applies the relevant changes to both x86 & x86_64. The x86-64 version is a symlink

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-29 Thread Dave Jones
On Mon, May 21, 2007 at 04:47:43PM -1000, Joshua Hoblitt wrote: apologies for the delay in getting back to this. Here is cleaned up version of Ed's patch that I believe addresses Dave's stylistic concerns applies the relevant changes to both x86 x86_64. The x86-64 version is a symlink to

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-29 Thread Daniel Drake
Dave Jones wrote: The patch content looks ok to me, Daniel, ack? Works for me, thanks. Daniel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-21 Thread Joshua Hoblitt
On Fri, May 18, 2007 at 12:01:08PM -0400, Dave Jones wrote: > On Fri, May 18, 2007 at 12:09:38AM -0400, Ed Sweetman wrote: [snip] > still has unnecessary whitespace changes [snip] > and still wordwrapped. > (also capitalise ACPI) I haven't seen any more e-mail traffic on this topic so I'm

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-21 Thread Joshua Hoblitt
On Fri, May 18, 2007 at 12:01:08PM -0400, Dave Jones wrote: On Fri, May 18, 2007 at 12:09:38AM -0400, Ed Sweetman wrote: [snip] still has unnecessary whitespace changes [snip] and still wordwrapped. (also capitalise ACPI) I haven't seen any more e-mail traffic on this topic so I'm assuming

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-18 Thread Dave Jones
On Fri, May 18, 2007 at 12:09:38AM -0400, Ed Sweetman wrote: > the previous post i keep referring you to has a patch that was mangled > ...here is the non-mangled version > > --- ./linux-backup/arch/x86_64/kernel/cpufreq/Kconfig 2007-02-04 > 13:44:54.0 -0500 > +++

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-18 Thread Dave Jones
On Fri, May 18, 2007 at 12:09:38AM -0400, Ed Sweetman wrote: the previous post i keep referring you to has a patch that was mangled ...here is the non-mangled version --- ./linux-backup/arch/x86_64/kernel/cpufreq/Kconfig 2007-02-04 13:44:54.0 -0500 +++

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-17 Thread Ed Sweetman
the previous post i keep referring you to has a patch that was mangled ...here is the non-mangled version --- ./linux-backup/arch/x86_64/kernel/cpufreq/Kconfig 2007-02-04 13:44:54.0 -0500 +++ ./linux-2.6.21-rc5-mm2/arch/x86_64/kernel/cpufreq/Kconfig 2007-05-17 18:13:07.0

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-17 Thread Ed Sweetman
Joshua Hoblitt wrote: I think it's pretty clear that Dave and Daniel were both correct and that ACPI_PROCESSOR is the correct dependency for multi-socket systems. However, it's worth noting that this dependency seems to be unrelated to SMP support. Ed Sweetman has reported that his

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-17 Thread Joshua Hoblitt
I think it's pretty clear that Dave and Daniel were both correct and that ACPI_PROCESSOR is the correct dependency for multi-socket systems. However, it's worth noting that this dependency seems to be unrelated to SMP support. Ed Sweetman has reported that his single-socket but multi-core system

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-17 Thread Joshua Hoblitt
I think it's pretty clear that Dave and Daniel were both correct and that ACPI_PROCESSOR is the correct dependency for multi-socket systems. However, it's worth noting that this dependency seems to be unrelated to SMP support. Ed Sweetman has reported that his single-socket but multi-core system

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-17 Thread Ed Sweetman
Joshua Hoblitt wrote: I think it's pretty clear that Dave and Daniel were both correct and that ACPI_PROCESSOR is the correct dependency for multi-socket systems. However, it's worth noting that this dependency seems to be unrelated to SMP support. Ed Sweetman has reported that his

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-17 Thread Ed Sweetman
the previous post i keep referring you to has a patch that was mangled ...here is the non-mangled version --- ./linux-backup/arch/x86_64/kernel/cpufreq/Kconfig 2007-02-04 13:44:54.0 -0500 +++ ./linux-2.6.21-rc5-mm2/arch/x86_64/kernel/cpufreq/Kconfig 2007-05-17 18:13:07.0

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Ed Sweetman
Daniel Drake wrote: Ed Sweetman wrote: Like i mentioned off list, the problem here is that cpu freq modules dont depend (Kconfig) on CONFIG_ACPI_PROCESSOR, yet they do. Not really. Firstly, some of the cpufreq modules *do* depend on CONFIG_ACPI_PROCESSOR. Secondly, the ones that don't have

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Daniel Drake
Ed Sweetman wrote: Like i mentioned off list, the problem here is that cpu freq modules dont depend (Kconfig) on CONFIG_ACPI_PROCESSOR, yet they do. Not really. Firstly, some of the cpufreq modules *do* depend on CONFIG_ACPI_PROCESSOR. Secondly, the ones that don't have an existing

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Ed Sweetman
Joshua Hoblitt wrote: On Wed, May 16, 2007 at 04:04:40PM -0400, Daniel Drake wrote: Duane Griffin wrote: On 16/05/07, Prakash Punnoor <[EMAIL PROTECTED]> wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do,

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Joshua Hoblitt
On Wed, May 16, 2007 at 04:04:40PM -0400, Daniel Drake wrote: > Duane Griffin wrote: > >On 16/05/07, Prakash Punnoor <[EMAIL PROTECTED]> wrote: > >>Maybe you want to give a hint in the p states driver help text? > > > >I think a hint is the right thing to do, but in the PowerNow! driver > >rather

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Dave Jones
On Wed, May 16, 2007 at 08:53:13PM +0100, Duane Griffin wrote: > On 16/05/07, Prakash Punnoor <[EMAIL PROTECTED]> wrote: > > Maybe you want to give a hint in the p states driver help text? > > I think a hint is the right thing to do, but in the PowerNow! driver > rather than the p states

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Daniel Drake
Duane Griffin wrote: On 16/05/07, Prakash Punnoor <[EMAIL PROTECTED]> wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do, but in the PowerNow! driver rather than the p states one. How about adding something like this to the

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Duane Griffin
On 16/05/07, Prakash Punnoor <[EMAIL PROTECTED]> wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do, but in the PowerNow! driver rather than the p states one. How about adding something like this to the X86_POWERNOW_K8 (and

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Prakash Punnoor
Am Mittwoch 16 Mai 2007 schrieb Joshua Hoblitt: > Hello, > > Below is a one line patch to possibly fix this bug: > > http://bugs.gentoo.org/show_bug.cgi?id=178585 > http://bugzilla.kernel.org/show_bug.cgi?id=8075 > > If the kernel is configured with: > > CONFIG_X86_POWERNOW_K8=y >

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Dave Jones
On Tue, May 15, 2007 at 03:17:11PM -1000, Joshua Hoblitt wrote: > --- linux-2.6.21.1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig2007-04-27 > 11:49:26.0 -1000 > +++ linux-2.6.21.1/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-05-15 > 14:48:50.0 -1000 > @@ -82,6 +82,7 @@

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Chuck Ebbert
[Copying maintainer.] Joshua Hoblitt wrote: > Hello, > > Below is a one line patch to possibly fix this bug: > > http://bugs.gentoo.org/show_bug.cgi?id=178585 > http://bugzilla.kernel.org/show_bug.cgi?id=8075 > > If the kernel is configured with: > > CONFIG_X86_POWERNOW_K8=y >

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Chuck Ebbert
[Copying maintainer.] Joshua Hoblitt wrote: Hello, Below is a one line patch to possibly fix this bug: http://bugs.gentoo.org/show_bug.cgi?id=178585 http://bugzilla.kernel.org/show_bug.cgi?id=8075 If the kernel is configured with: CONFIG_X86_POWERNOW_K8=y CONFIG_X86_ACPI_CPUFREQ=m

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Dave Jones
dropping trivial@ from cc: as this definitly isn't On Tue, May 15, 2007 at 03:17:11PM -1000, Joshua Hoblitt wrote: --- linux-2.6.21.1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig2007-04-27 11:49:26.0 -1000 +++ linux-2.6.21.1/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-05-15

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Prakash Punnoor
Am Mittwoch 16 Mai 2007 schrieb Joshua Hoblitt: Hello, Below is a one line patch to possibly fix this bug: http://bugs.gentoo.org/show_bug.cgi?id=178585 http://bugzilla.kernel.org/show_bug.cgi?id=8075 If the kernel is configured with: CONFIG_X86_POWERNOW_K8=y CONFIG_X86_ACPI_CPUFREQ=m

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Duane Griffin
On 16/05/07, Prakash Punnoor [EMAIL PROTECTED] wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do, but in the PowerNow! driver rather than the p states one. How about adding something like this to the X86_POWERNOW_K8 (and

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Daniel Drake
Duane Griffin wrote: On 16/05/07, Prakash Punnoor [EMAIL PROTECTED] wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do, but in the PowerNow! driver rather than the p states one. How about adding something like this to the

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Dave Jones
On Wed, May 16, 2007 at 08:53:13PM +0100, Duane Griffin wrote: On 16/05/07, Prakash Punnoor [EMAIL PROTECTED] wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do, but in the PowerNow! driver rather than the p states one. How

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Joshua Hoblitt
On Wed, May 16, 2007 at 04:04:40PM -0400, Daniel Drake wrote: Duane Griffin wrote: On 16/05/07, Prakash Punnoor [EMAIL PROTECTED] wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do, but in the PowerNow! driver rather than the p

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Ed Sweetman
Joshua Hoblitt wrote: On Wed, May 16, 2007 at 04:04:40PM -0400, Daniel Drake wrote: Duane Griffin wrote: On 16/05/07, Prakash Punnoor [EMAIL PROTECTED] wrote: Maybe you want to give a hint in the p states driver help text? I think a hint is the right thing to do, but

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Daniel Drake
Ed Sweetman wrote: Like i mentioned off list, the problem here is that cpu freq modules dont depend (Kconfig) on CONFIG_ACPI_PROCESSOR, yet they do. Not really. Firstly, some of the cpufreq modules *do* depend on CONFIG_ACPI_PROCESSOR. Secondly, the ones that don't have an existing

Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-16 Thread Ed Sweetman
Daniel Drake wrote: Ed Sweetman wrote: Like i mentioned off list, the problem here is that cpu freq modules dont depend (Kconfig) on CONFIG_ACPI_PROCESSOR, yet they do. Not really. Firstly, some of the cpufreq modules *do* depend on CONFIG_ACPI_PROCESSOR. Secondly, the ones that don't have

[PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-15 Thread Joshua Hoblitt
Hello, Below is a one line patch to possibly fix this bug: http://bugs.gentoo.org/show_bug.cgi?id=178585 http://bugzilla.kernel.org/show_bug.cgi?id=8075 If the kernel is configured with: CONFIG_X86_POWERNOW_K8=y CONFIG_X86_ACPI_CPUFREQ=m Which is currently an allowed configuration, the

[PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

2007-05-15 Thread Joshua Hoblitt
Hello, Below is a one line patch to possibly fix this bug: http://bugs.gentoo.org/show_bug.cgi?id=178585 http://bugzilla.kernel.org/show_bug.cgi?id=8075 If the kernel is configured with: CONFIG_X86_POWERNOW_K8=y CONFIG_X86_ACPI_CPUFREQ=m Which is currently an allowed configuration, the