Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion

2020-11-17 Thread Thomas Bogendoerfer
On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > The loop over all memblocks works with PFN numbers and not physical > addresses, so we need for_each_mem_pfn_range(). > > Fixes: b10d6bca8720 ("arch, drivers: replace for_each_membock() with > for_each_mem_range()") >

Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion

2020-11-17 Thread Thomas Bogendoerfer
On Tue, Nov 17, 2020 at 10:05:18AM +0200, Mike Rapoport wrote: > On Mon, Nov 16, 2020 at 11:05:54PM +0300, Serge Semin wrote: > > On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > > > The loop over all memblocks works with PFN numbers and not physical > > > addresses, so we

Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion

2020-11-17 Thread Serge Semin
On Tue, Nov 17, 2020 at 10:05:18AM +0200, Mike Rapoport wrote: > On Mon, Nov 16, 2020 at 11:05:54PM +0300, Serge Semin wrote: > > On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > > > The loop over all memblocks works with PFN numbers and not physical > > > addresses, so we

Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion

2020-11-17 Thread Mike Rapoport
On Mon, Nov 16, 2020 at 11:05:54PM +0300, Serge Semin wrote: > On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > > The loop over all memblocks works with PFN numbers and not physical > > addresses, so we need for_each_mem_pfn_range(). > > Great catch! Don't know how that has

Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion

2020-11-16 Thread Serge Semin
On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > The loop over all memblocks works with PFN numbers and not physical > addresses, so we need for_each_mem_pfn_range(). Great catch! Don't know how that has been working so far. Anyway Reviewed-by: Serge Semin -Sergey > >

Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion

2020-11-16 Thread Mike Rapoport
On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > The loop over all memblocks works with PFN numbers and not physical > addresses, so we need for_each_mem_pfn_range(). > > Fixes: b10d6bca8720 ("arch, drivers: replace for_each_membock() with > for_each_mem_range()") >

[PATCH] MIPS: kernel: Fix for_each_memblock conversion

2020-11-16 Thread Thomas Bogendoerfer
The loop over all memblocks works with PFN numbers and not physical addresses, so we need for_each_mem_pfn_range(). Fixes: b10d6bca8720 ("arch, drivers: replace for_each_membock() with for_each_mem_range()") Signed-off-by: Thomas Bogendoerfer --- arch/mips/kernel/setup.c | 6 +++--- 1 file