Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-08-23 Thread Bjorn Helgaas
[+cc Shaohua] On Thu, Aug 22, 2013 at 6:02 PM, Bjorn Helgaas wrote: > On Thu, Aug 08, 2013 at 03:57:07PM +0200, Radim Krčmář wrote: >> PCIe switch can be connected directly to the PCIe root complex in QEMU; >> ASPM does not expect this topology and dereferences NULL pointer when >> initializing.

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-08-22 Thread Bjorn Helgaas
On Thu, Aug 08, 2013 at 03:57:07PM +0200, Radim Krčmář wrote: > PCIe switch can be connected directly to the PCIe root complex in QEMU; > ASPM does not expect this topology and dereferences NULL pointer when > initializing. > > Downstream port can be also connected to the root complex without > up

[PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-08-08 Thread Radim Krčmář
PCIe switch can be connected directly to the PCIe root complex in QEMU; ASPM does not expect this topology and dereferences NULL pointer when initializing. Downstream port can be also connected to the root complex without upstream one, so code checks for both, otherwise they dereference NULL on li

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-25 Thread Radim Krčmář
2013-06-25 11:17-0600, Bjorn Helgaas: > On Tue, Jun 25, 2013 at 5:23 AM, Michael S. Tsirkin wrote: > > On Mon, Jun 24, 2013 at 07:38:45PM -0600, Bjorn Helgaas wrote: > >> [+cc Michael, Alex, Isaku] > >> > >> On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: > >> > PCIe switch upstream port ca

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-25 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 5:23 AM, Michael S. Tsirkin wrote: > On Mon, Jun 24, 2013 at 07:38:45PM -0600, Bjorn Helgaas wrote: >> [+cc Michael, Alex, Isaku] >> >> On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: >> > PCIe switch upstream port can be connected directly to the PCIe root bus >> >

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-25 Thread Michael S. Tsirkin
On Mon, Jun 24, 2013 at 07:38:45PM -0600, Bjorn Helgaas wrote: > [+cc Michael, Alex, Isaku] > > On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: > > PCIe switch upstream port can be connected directly to the PCIe root bus > > in QEMU; ASPM does not expect this topology and dereferences NULL

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-24 Thread Alex Williamson
On Mon, 2013-06-24 at 21:35 -0600, Bjorn Helgaas wrote: > On Mon, Jun 24, 2013 at 8:58 PM, Alex Williamson > wrote: > > On Mon, 2013-06-24 at 19:38 -0600, Bjorn Helgaas wrote: > >> [+cc Michael, Alex, Isaku] > >> > >> On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: > >> > PCIe switch upstre

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-24 Thread Bjorn Helgaas
On Mon, Jun 24, 2013 at 8:58 PM, Alex Williamson wrote: > On Mon, 2013-06-24 at 19:38 -0600, Bjorn Helgaas wrote: >> [+cc Michael, Alex, Isaku] >> >> On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: >> > PCIe switch upstream port can be connected directly to the PCIe root bus >> > in QEMU; A

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-24 Thread Alex Williamson
On Mon, 2013-06-24 at 19:38 -0600, Bjorn Helgaas wrote: > [+cc Michael, Alex, Isaku] > > On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: > > PCIe switch upstream port can be connected directly to the PCIe root bus > > in QEMU; ASPM does not expect this topology and dereferences NULL pointer

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-24 Thread Bjorn Helgaas
[+cc Michael, Alex, Isaku] On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: > PCIe switch upstream port can be connected directly to the PCIe root bus > in QEMU; ASPM does not expect this topology and dereferences NULL pointer > when initializing. > > I have not confirmed this can happen on

[PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-19 Thread Radim Krčmář
PCIe switch upstream port can be connected directly to the PCIe root bus in QEMU; ASPM does not expect this topology and dereferences NULL pointer when initializing. I have not confirmed this can happen on real hardware, but it is presented as a feature in QEMU, so there is no reason to panic if w