Re: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero

2017-02-17 Thread Dan Carpenter
drivers/infiniband/hw/bnxt_re/ib_verbs.c 2817 int bnxt_re_dereg_mr(struct ib_mr *ib_mr) 2818 { 2819 struct bnxt_re_mr *mr = container_of(ib_mr, struct bnxt_re_mr, ib_mr); 2820 struct bnxt_re_dev *rdev = mr->rdev; 2821 int rc = 0; It's weird that it would com

Re: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero

2017-02-17 Thread Laurence Oberman
nstock" > , > linux-r...@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org, linux-kernel@vger.kernel.org > Sent: Friday, February 17, 2017 10:35:22 AM > Subject: [PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero > > From: Colin Ian King > > rc is

[PATCH] RDMA/bnxt_re: remove redundant initialization of rc to zero

2017-02-17 Thread Colin King
From: Colin Ian King rc is initialized to zero but is then updated by calls to bnxt_qplib_free_fast_reg_page_list and/or bnxt_qpliob_free_mrw so the initialization is redundant and can be removed. Detected with CoverityScan, CID#1408448 ("Unused Value") Signed-off-by: Colin Ian King --- drive