Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-05-04 Thread David Miller
From: Linus Walleij Date: Mon, 4 May 2015 15:18:39 +0200 > On Tue, Mar 17, 2015 at 8:05 PM, David Miller wrote: >> From: Robert Jarzmik >> Date: Mon, 16 Mar 2015 22:06:13 +0100 >> >>> David Miller writes: >>> From: Robert Jarzmik Date: Thu, 19 Feb 2015 21:48:49 +0100 > Linu

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-05-04 Thread Linus Walleij
On Tue, Mar 17, 2015 at 8:05 PM, David Miller wrote: > From: Robert Jarzmik > Date: Mon, 16 Mar 2015 22:06:13 +0100 > >> David Miller writes: >> >>> From: Robert Jarzmik >>> Date: Thu, 19 Feb 2015 21:48:49 +0100 >>> Linus has submitted the patch [1]. I'll be watching carefully until -rc4

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-03-17 Thread David Miller
From: Robert Jarzmik Date: Mon, 16 Mar 2015 22:06:13 +0100 > David Miller writes: > >> From: Robert Jarzmik >> Date: Thu, 19 Feb 2015 21:48:49 +0100 >> >>> Linus has submitted the patch [1]. I'll be watching carefully until -rc4 >>> that >>> this is applied. If it's not, I'll reping you to ap

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-03-16 Thread Robert Jarzmik
Cheers. -- Robert [1] Patch reminder ---<8--- From: Robert Jarzmik Subject: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way" To: Nicolas Pitre , "David S. Miller" , Linus Walleij Cc: net...@vger.kernel.org, linux-kernel@vger.kernel.org, Robert J

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-23 Thread Linus Walleij
On Fri, Feb 20, 2015 at 4:33 PM, Greg KH wrote: > On Fri, Feb 20, 2015 at 10:37:59AM +0100, Linus Walleij wrote: >> On Thu, Feb 19, 2015 at 9:48 PM, Robert Jarzmik >> wrote: >> > David Miller writes: >> > >> >>> Now if you can make it in -rc2 or -rc3, this revert should be forgotten. >> >>> Bu

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-20 Thread Greg KH
On Fri, Feb 20, 2015 at 10:37:59AM +0100, Linus Walleij wrote: > On Thu, Feb 19, 2015 at 9:48 PM, Robert Jarzmik > wrote: > > David Miller writes: > > > >>> Now if you can make it in -rc2 or -rc3, this revert should be forgotten. > >>> But if > >>> you can't make it for 3.20, I'll push for the

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-20 Thread Linus Walleij
On Thu, Feb 19, 2015 at 9:48 PM, Robert Jarzmik wrote: > David Miller writes: > >>> Now if you can make it in -rc2 or -rc3, this revert should be forgotten. >>> But if >>> you can't make it for 3.20, I'll push for the revert. >>> >>> So I think it's up to you now, and let's see what Gregh says a

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-19 Thread David Miller
From: Robert Jarzmik Date: Thu, 19 Feb 2015 21:48:49 +0100 > Linus has submitted the patch [1]. I'll be watching carefully until -rc4 that > this is applied. If it's not, I'll reping you to apply this revert. Until > then, > you can forget about it, I'll do the follow-up. > > Does that plan sou

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-19 Thread Robert Jarzmik
David Miller writes: >> Now if you can make it in -rc2 or -rc3, this revert should be forgotten. But >> if >> you can't make it for 3.20, I'll push for the revert. >> >> So I think it's up to you now, and let's see what Gregh says about it. > > What is the current status of this? I'd like to s

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-19 Thread David Miller
From: Robert Jarzmik Date: Fri, 13 Feb 2015 17:06:49 +0100 > Linus Walleij writes: > >> On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik >> wrote: >> >> But isn't the real problem that in the device tree case, >> irq_get_irq_data(ndev->irq) will work becaus parsing an interrupt >> from the de

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-13 Thread Robert Jarzmik
Linus Walleij writes: > On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik > wrote: > > But isn't the real problem that in the device tree case, > irq_get_irq_data(ndev->irq) will work becaus parsing an interrupt > from the device tree populates it correctly in platform_get_irq() > whereas for th

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-13 Thread Robert Jarzmik
Linus Walleij writes: > On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik > wrote: > > But isn't the real problem that in the device tree case, > irq_get_irq_data(ndev->irq) will work becaus parsing an interrupt > from the device tree populates it correctly in platform_get_irq() > whereas for th

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-13 Thread Robert Jarzmik
Linus Walleij writes: > On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik > wrote: > But isn't the real problem that in the device tree case, > irq_get_irq_data(ndev->irq) will work becaus parsing an interrupt > from the device tree populates it correctly in platform_get_irq() > whereas for the

Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-12 Thread Linus Walleij
On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik wrote: > The commit breaks the legacy platforms, ie. these not using device-tree, > and setting up the interrupt resources with a flag to activate edge > detection. The issue was found on the zylonite platform. > > The reason is that zylonite uses

[PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

2015-02-12 Thread Robert Jarzmik
The commit breaks the legacy platforms, ie. these not using device-tree, and setting up the interrupt resources with a flag to activate edge detection. The issue was found on the zylonite platform. The reason is that zylonite uses platform resources to pass the interrupt number and the irq flags (