Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Greg KH
On Mon, Feb 04, 2008 at 10:37:37PM +, Adrian McMenamin wrote: > > On Mon, 2008-02-04 at 08:14 -0800, Greg KH wrote: > > On Mon, Feb 04, 2008 at 08:27:55AM +, Adrian McMenamin wrote: > > > > > > On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > > > > On Sun, Feb 03, 2008 at 08:00:47PM

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 22:37 +, Adrian McMenamin wrote: > > The hardware is very flaky. If I add in delays to the bus start, it will > detect the devices, but it's not brilliant. Registering an empty device > got round that problem, at the price of testing for the earlier > registration. >

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 08:14 -0800, Greg KH wrote: > On Mon, Feb 04, 2008 at 08:27:55AM +, Adrian McMenamin wrote: > > > > On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > > > On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > > > > From: Adrian McMenamin > > > > > > > >

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Greg KH
On Mon, Feb 04, 2008 at 08:27:55AM +, Adrian McMenamin wrote: > > On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > > On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > > > From: Adrian McMenamin > > > > > > This patch fixes the regression noted here: > > >

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:59 am, Paul Mundt wrote: > On Mon, Feb 04, 2008 at 09:35:11AM -, Adrian McMenamin wrote: >> On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: >> > My previous commit was directly from _your_ patch, given that your >> > patches have a history of whitespace damage,

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Paul Mundt
On Mon, Feb 04, 2008 at 09:35:11AM -, Adrian McMenamin wrote: > On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: > > My previous commit was directly from _your_ patch, given that your > > patches have a history of whitespace damage, this doesn't seem like much > > of a stretch. It's true I

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: > My previous commit was directly from _your_ patch, given that your > patches have a history of whitespace damage, this doesn't seem like much > of a stretch. It's true I neglected to run it through checkpatch, I'll be > more careful with that

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Paul Mundt
On Mon, Feb 04, 2008 at 08:23:44AM +, Adrian McMenamin wrote: > > On Mon, 2008-02-04 at 10:10 +0900, Paul Mundt wrote: > > On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > > > From: Adrian McMenamin > > > > > This is useless if you are submitting the patch, especially if

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > > From: Adrian McMenamin > > > > This patch fixes the regression noted here: > > http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the > > previous commit of

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 10:10 +0900, Paul Mundt wrote: > On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > > From: Adrian McMenamin > > > This is useless if you are submitting the patch, especially if you're > missing a mail address. > >From Documentation/SubmittingPatches The

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 10:10 +0900, Paul Mundt wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This is useless if you are submitting the patch, especially if you're missing a mail address. From Documentation/SubmittingPatches The

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Paul Mundt
On Mon, Feb 04, 2008 at 08:23:44AM +, Adrian McMenamin wrote: On Mon, 2008-02-04 at 10:10 +0900, Paul Mundt wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This is useless if you are submitting the patch, especially if you're

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: My previous commit was directly from _your_ patch, given that your patches have a history of whitespace damage, this doesn't seem like much of a stretch. It's true I neglected to run it through checkpatch, I'll be more careful with that in

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Paul Mundt
On Mon, Feb 04, 2008 at 09:35:11AM -, Adrian McMenamin wrote: On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: My previous commit was directly from _your_ patch, given that your patches have a history of whitespace damage, this doesn't seem like much of a stretch. It's true I

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:59 am, Paul Mundt wrote: On Mon, Feb 04, 2008 at 09:35:11AM -, Adrian McMenamin wrote: On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: My previous commit was directly from _your_ patch, given that your patches have a history of whitespace damage, this

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Greg KH
On Mon, Feb 04, 2008 at 08:27:55AM +, Adrian McMenamin wrote: On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This patch fixes the regression noted here:

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 22:37 +, Adrian McMenamin wrote: The hardware is very flaky. If I add in delays to the bus start, it will detect the devices, but it's not brilliant. Registering an empty device got round that problem, at the price of testing for the earlier registration. I

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 08:14 -0800, Greg KH wrote: On Mon, Feb 04, 2008 at 08:27:55AM +, Adrian McMenamin wrote: On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This patch fixes the

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Greg KH
On Mon, Feb 04, 2008 at 10:37:37PM +, Adrian McMenamin wrote: On Mon, 2008-02-04 at 08:14 -0800, Greg KH wrote: On Mon, Feb 04, 2008 at 08:27:55AM +, Adrian McMenamin wrote: On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Greg KH
On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > From: Adrian McMenamin > > This patch fixes the regression noted here: > http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the > previous commit of this driver and the memory leaks noted here: >

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Paul Mundt
On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > From: Adrian McMenamin > This is useless if you are submitting the patch, especially if you're missing a mail address. > This patch fixes the regression noted here: > http://lkml.org/lkml/2008/1/26/189 as well as whitespace

[PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Adrian McMenamin
From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver and the memory leaks noted here: http://lkml.org/lkml/2008/2/2/143 (as well as one or two other minor cleanups). Signed off by:

[PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Adrian McMenamin
From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver and the memory leaks noted here: http://lkml.org/lkml/2008/2/2/143 (as well as one or two other minor cleanups). Signed off by:

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Paul Mundt
On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This is useless if you are submitting the patch, especially if you're missing a mail address. This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Greg KH
On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver and the memory leaks noted here: