Re: [PATCH] Staging: comedi: Fix coding style issues

On Sun, Sep 20, 2015 at 6:50 AM, Jaime Arrocha wrote: > > On 09/19/2015 01:13 PM, punit vara wrote: >> >> [PATCH] Staging: comedi: Fix block comment warning > > > [PATCH] Staging: comedi: Coding style warnings fix for block comments > Thank you for suggestion sir .I would appreciate your help.

Re: [PATCH] Staging: comedi: Fix coding style issues

On Sun, Sep 20, 2015 at 6:50 AM, Jaime Arrocha wrote: > > On 09/19/2015 01:13 PM, punit vara wrote: >> >> [PATCH] Staging: comedi: Fix block comment warning > > > [PATCH] Staging: comedi: Coding style warnings fix for block comments > Thank you for suggestion sir .I would

Re: [PATCH] Staging: comedi: Fix coding style issues

On 09/19/2015 01:13 PM, punit vara wrote: [PATCH] Staging: comedi: Fix block comment warning [PATCH] Staging: comedi: Coding style warnings fix for block comments -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] Staging: comedi: Fix coding style issues

On Fri, Sep 18, 2015 at 10:22 PM, Punit Vara wrote: > This patch is to comedidev.h file that fixes up following warnings > reported by checkpatch.pl : > > -Block comments use a trailing */ on a separate line > -Block comments use * on subsequent lines > > Signed-off-by: Punit Vara > --- >

Re: [PATCH] Staging: comedi: Fix coding style issues

[PATCH] Staging: comedi: Fix block comment according to preferred style [PATCH] Staging: comedi: Fix block comment warning which would be the better subject for my patch ? anybody can suggest please ? regards, punitvara -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] Staging: comedi: Fix coding style issues

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sat, Sep 19, 2015 at 09:57:43PM +0530, punit vara wrote: > For this patch can I put subject like > > [PATCH] Staging: comedi: Fix trailing */ and * comment warning > > ?? Yes, that would be much

Re: [PATCH] Staging: comedi: Fix coding style issues

For this patch can I put subject like [PATCH] Staging: comedi: Fix trailing */ and * comment warning ?? Kindly suggest me as this is my first patch and i am trying to contribute to linux kernel . On Fri, Sep 18, 2015 at 10:22 PM, Punit Vara wrote: > This patch is to comedidev.h file that fixes

Re: [PATCH] Staging: comedi: Fix coding style issues

On 09/19/2015 01:13 PM, punit vara wrote: [PATCH] Staging: comedi: Fix block comment warning [PATCH] Staging: comedi: Coding style warnings fix for block comments -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] Staging: comedi: Fix coding style issues

On Fri, Sep 18, 2015 at 10:22 PM, Punit Vara wrote: > This patch is to comedidev.h file that fixes up following warnings > reported by checkpatch.pl : > > -Block comments use a trailing */ on a separate line > -Block comments use * on subsequent lines > > Signed-off-by: Punit

Re: [PATCH] Staging: comedi: Fix coding style issues

[PATCH] Staging: comedi: Fix block comment according to preferred style [PATCH] Staging: comedi: Fix block comment warning which would be the better subject for my patch ? anybody can suggest please ? regards, punitvara -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] Staging: comedi: Fix coding style issues

For this patch can I put subject like [PATCH] Staging: comedi: Fix trailing */ and * comment warning ?? Kindly suggest me as this is my first patch and i am trying to contribute to linux kernel . On Fri, Sep 18, 2015 at 10:22 PM, Punit Vara wrote: > This patch is to

Re: [PATCH] Staging: comedi: Fix coding style issues

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sat, Sep 19, 2015 at 09:57:43PM +0530, punit vara wrote: > For this patch can I put subject like > > [PATCH] Staging: comedi: Fix trailing */ and * comment warning > > ?? Yes, that would be much

Re: [PATCH] Staging: comedi: Fix coding style issues

On Fri, Sep 18, 2015 at 10:22:59PM +0530, Punit Vara wrote: > This patch is to comedidev.h file that fixes up following warnings > reported by checkpatch.pl : > > -Block comments use a trailing */ on a separate line > -Block comments use * on subsequent lines Your subject needs to be very

[PATCH] Staging: comedi: Fix coding style issues

This patch is to comedidev.h file that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line -Block comments use * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/comedi/comedidev.h | 62

Re: [PATCH] Staging: comedi: Fix coding style issues

On Fri, Sep 18, 2015 at 10:22:59PM +0530, Punit Vara wrote: > This patch is to comedidev.h file that fixes up following warnings > reported by checkpatch.pl : > > -Block comments use a trailing */ on a separate line > -Block comments use * on subsequent lines Your subject needs to be very

[PATCH] Staging: comedi: Fix coding style issues

This patch is to comedidev.h file that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line -Block comments use * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/comedi/comedidev.h | 62

Re: [PATCH] staging: comedi: fix coding style issues

On 16/05/15 05:16, Geliang Tang wrote: 1) Fixed an error found by checkpatch.pl. ERROR: space required after that ',' (ctx:VxV) ./drivers/ni_mio_common.c:3764 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency of this file. 3) The kernel version is next-20150515,

Re: [PATCH] staging: comedi: fix coding style issues

On 16/05/15 05:16, Geliang Tang wrote: 1) Fixed an error found by checkpatch.pl. ERROR: space required after that ',' (ctx:VxV) ./drivers/ni_mio_common.c:3764 2) Changed register 0x%x to register=0x%x to keep the consistency of this file. 3) The kernel version is next-20150515,

[PATCH] staging: comedi: fix coding style issues

1) Fixed an error found by checkpatch.pl. ERROR: space required after that ',' (ctx:VxV) ./drivers/ni_mio_common.c:3764 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency of this file. 3) The kernel version is next-20150515, 4.1.0-rc3. Signed-off-by: Geliang Tang ---

[PATCH] staging: comedi: fix coding style issues

1) Fixed an error found by checkpatch.pl. ERROR: space required after that ',' (ctx:VxV) ./drivers/ni_mio_common.c:3764 2) Changed register 0x%x to register=0x%x to keep the consistency of this file. 3) The kernel version is next-20150515, 4.1.0-rc3. Signed-off-by: Geliang Tang

Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

On 2014/05/01 09:23 AM, Raghavendra Ganiga wrote: > This is a patch to fix coding style > warnings found by checkpatch.pl tool > > Signed-off-by: Raghavendra Chandra Ganiga > --- > drivers/staging/comedi/comedi_fops.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

On 2014/04/30 06:34 PM, Raghavendra Ganiga wrote: > This is a patch to fix coding style > warnings found by the checkpatch.pl tool > > Signed-off-by: Raghavendra Chandra Ganiga > --- > drivers/staging/comedi/comedi_fops.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > >

[PATCH] staging: comedi: fix coding style issues in comedi_fops.c

This is a patch to fix coding style warnings found by checkpatch.pl tool Signed-off-by: Raghavendra Chandra Ganiga --- drivers/staging/comedi/comedi_fops.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index

[PATCH] staging: comedi: fix coding style issues in comedi_fops.c

This is a patch to fix coding style warnings found by checkpatch.pl tool Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com --- drivers/staging/comedi/comedi_fops.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/comedi/comedi_fops.c

Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

On 2014/04/30 06:34 PM, Raghavendra Ganiga wrote: This is a patch to fix coding style warnings found by the checkpatch.pl tool Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com --- drivers/staging/comedi/comedi_fops.c |6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

On 2014/05/01 09:23 AM, Raghavendra Ganiga wrote: This is a patch to fix coding style warnings found by checkpatch.pl tool Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com --- drivers/staging/comedi/comedi_fops.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

On Wed, Apr 30, 2014 at 11:04:49PM +0530, Raghavendra Ganiga wrote: > This is a patch to fix coding style > warnings found by the checkpatch.pl tool > Someone fixed this already. You should be working against linux-next for this kind of thing. regards, dan carpenter -- To unsubscribe from

[PATCH] staging: comedi: fix coding style issues in comedi_fops.c

This is a patch to fix coding style warnings found by the checkpatch.pl tool Signed-off-by: Raghavendra Chandra Ganiga --- drivers/staging/comedi/comedi_fops.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c

[PATCH] staging: comedi: fix coding style issues in comedi_fops.c

This is a patch to fix coding style warnings found by the checkpatch.pl tool Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com --- drivers/staging/comedi/comedi_fops.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c

Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

On Wed, Apr 30, 2014 at 11:04:49PM +0530, Raghavendra Ganiga wrote: This is a patch to fix coding style warnings found by the checkpatch.pl tool Someone fixed this already. You should be working against linux-next for this kind of thing. regards, dan carpenter -- To unsubscribe from this

[PATCH] staging: comedi: fix coding style issues in comedi_fops.c

>From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga Date: Fri, 25 Apr 2014 23:11:22 +0530 Subject: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c This is a patch to fix coding style warnings found by the checkpatch.pl tool Sig

[PATCH] staging: comedi: fix coding style issues in comedi_fops.c

From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga ravi23gan...@gmail.com Date: Fri, 25 Apr 2014 23:11:22 +0530 Subject: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c This is a patch to fix coding style warnings found

Re: [PATCH] Staging: comedi: fix coding style issues in poc.c

You have not understood what Joe said. On Mon, Feb 24, 2014 at 08:48:47PM +1100, David Roddick wrote: > Removed unnecessary spaces after function pointer names and corrected > multi-line wrap alignment > This should be line wrapped at 72 characters (same rule as email). In other words it

[PATCH] Staging: comedi: fix coding style issues in poc.c

Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment Signed-off-by: David Roddick --- drivers/staging/comedi/drivers/poc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c

[PATCH] Staging: comedi: fix coding style issues in poc.c

Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment Signed-off-by: David Roddick dgrodd...@gmail.com --- drivers/staging/comedi/drivers/poc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH] Staging: comedi: fix coding style issues in poc.c

You have not understood what Joe said. On Mon, Feb 24, 2014 at 08:48:47PM +1100, David Roddick wrote: Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment This should be line wrapped at 72 characters (same rule as email). In other words it should

Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

On 2013-11-17 03:42, Conrad Gomes wrote: Hi, No problem, I'll break this up and resend it. In order to use dev_info type functions I was planning on assigning the comedi device's struct device to the struct subdevice's class_dev as follows in comedi_alloc_subdevices as it appears that is is

Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

On 2013-11-17 03:42, Conrad Gomes wrote: Hi, No problem, I'll break this up and resend it. In order to use dev_info type functions I was planning on assigning the comedi device's struct device to the struct subdevice's class_dev as follows in comedi_alloc_subdevices as it appears that is is

Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote: > This is a patch which fixes coding style issues in unioxx5.c found > by checkpatch.pl > > 1) Replaced printk with pr_info and pr_err Drivers should never call printk() as they all have access to a struct device somewhere. So

Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote: This is a patch which fixes coding style issues in unioxx5.c found by checkpatch.pl 1) Replaced printk with pr_info and pr_err Drivers should never call printk() as they all have access to a struct device somewhere. So please

[PATCH] Staging: comedi: fix coding style issues in unioxx5.c

This is a patch which fixes coding style issues in unioxx5.c found by checkpatch.pl 1) Replaced printk with pr_info and pr_err 2) Reinitialized n_subd before for loop to fix over 80 character warning 3) Reworded comment to fix 80 character warning Signed-off-by: Conrad Gomes ---

[PATCH] Staging: comedi: fix coding style issues in unioxx5.c

This is a patch which fixes coding style issues in unioxx5.c found by checkpatch.pl 1) Replaced printk with pr_info and pr_err 2) Reinitialized n_subd before for loop to fix over 80 character warning 3) Reworded comment to fix 80 character warning Signed-off-by: Conrad Gomes