Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

2013-11-18 Thread Ian Abbott
On 2013-11-17 03:42, Conrad Gomes wrote: Hi, No problem, I'll break this up and resend it. In order to use dev_info type functions I was planning on assigning the comedi device's struct device to the struct subdevice's class_dev as follows in comedi_alloc_subdevices as it appears that is is

Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

2013-11-18 Thread Ian Abbott
On 2013-11-17 03:42, Conrad Gomes wrote: Hi, No problem, I'll break this up and resend it. In order to use dev_info type functions I was planning on assigning the comedi device's struct device to the struct subdevice's class_dev as follows in comedi_alloc_subdevices as it appears that is is

Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

2013-11-11 Thread Greg KH
On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote: > This is a patch which fixes coding style issues in unioxx5.c found > by checkpatch.pl > > 1) Replaced printk with pr_info and pr_err Drivers should never call printk() as they all have access to a struct device somewhere. So

Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

2013-11-11 Thread Greg KH
On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote: This is a patch which fixes coding style issues in unioxx5.c found by checkpatch.pl 1) Replaced printk with pr_info and pr_err Drivers should never call printk() as they all have access to a struct device somewhere. So please

[PATCH] Staging: comedi: fix coding style issues in unioxx5.c

2013-11-01 Thread Conrad Gomes
This is a patch which fixes coding style issues in unioxx5.c found by checkpatch.pl 1) Replaced printk with pr_info and pr_err 2) Reinitialized n_subd before for loop to fix over 80 character warning 3) Reworded comment to fix 80 character warning Signed-off-by: Conrad Gomes ---

[PATCH] Staging: comedi: fix coding style issues in unioxx5.c

2013-11-01 Thread Conrad Gomes
This is a patch which fixes coding style issues in unioxx5.c found by checkpatch.pl 1) Replaced printk with pr_info and pr_err 2) Reinitialized n_subd before for loop to fix over 80 character warning 3) Reworded comment to fix 80 character warning Signed-off-by: Conrad Gomes