Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-11 Thread Pantelis Antoniou
Hi Grant, > On Jun 7, 2015, at 14:16 , Grant Likely wrote: > > On Wed, 22 Apr 2015 15:30:28 +0300 > , Pantelis Antoniou > wrote: >> Hi Wolfram, >> >>> On Apr 14, 2015, at 16:27 , Wolfram Sang wrote: >>> >>> Hi Pantelis, >>> >>> thanks for your prompt reply. Unfortunately, I had to wait

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-11 Thread Pantelis Antoniou
Hi Grant, On Jun 7, 2015, at 14:16 , Grant Likely grant.lik...@secretlab.ca wrote: On Wed, 22 Apr 2015 15:30:28 +0300 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Wolfram, On Apr 14, 2015, at 16:27 , Wolfram Sang w...@the-dreams.de wrote: Hi Pantelis, thanks for

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-10 Thread Grant Likely
On Tue, 09 Jun 2015 19:50:26 +0300 , Laurent Pinchart wrote: > Hi Grant, > > On Sunday 07 June 2015 12:16:32 Grant Likely wrote: > > On Wed, 22 Apr 2015 15:30:28 +0300, Pantelis Antoniou wrote: > > > > On Apr 14, 2015, at 16:27 , Wolfram Sang wrote: > > > > > > > > Hi Pantelis, > > > > > > >

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-10 Thread Grant Likely
On Tue, 09 Jun 2015 19:50:26 +0300 , Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Grant, On Sunday 07 June 2015 12:16:32 Grant Likely wrote: On Wed, 22 Apr 2015 15:30:28 +0300, Pantelis Antoniou wrote: On Apr 14, 2015, at 16:27 , Wolfram Sang w...@the-dreams.de wrote:

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-09 Thread Laurent Pinchart
Hi Grant, On Sunday 07 June 2015 12:16:32 Grant Likely wrote: > On Wed, 22 Apr 2015 15:30:28 +0300, Pantelis Antoniou wrote: > > > On Apr 14, 2015, at 16:27 , Wolfram Sang wrote: > > > > > > Hi Pantelis, > > > > > > thanks for your prompt reply. Unfortunately, I had to wait until I could > > >

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-09 Thread Laurent Pinchart
Hi Grant, On Sunday 07 June 2015 12:16:32 Grant Likely wrote: On Wed, 22 Apr 2015 15:30:28 +0300, Pantelis Antoniou wrote: On Apr 14, 2015, at 16:27 , Wolfram Sang w...@the-dreams.de wrote: Hi Pantelis, thanks for your prompt reply. Unfortunately, I had to wait until I could

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-07 Thread Grant Likely
On Wed, 22 Apr 2015 15:30:28 +0300 , Pantelis Antoniou wrote: > Hi Wolfram, > > > On Apr 14, 2015, at 16:27 , Wolfram Sang wrote: > > > > Hi Pantelis, > > > > thanks for your prompt reply. Unfortunately, I had to wait until I could > > access the test system again. > > > > [snip] > >

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-06-07 Thread Grant Likely
On Wed, 22 Apr 2015 15:30:28 +0300 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Wolfram, On Apr 14, 2015, at 16:27 , Wolfram Sang w...@the-dreams.de wrote: Hi Pantelis, thanks for your prompt reply. Unfortunately, I had to wait until I could access the test system

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-23 Thread Wolfram Sang
> This patch has been posted before but up to now, no-one had a test case that > triggered > the bug, At your service... ;) signature.asc Description: Digital signature

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-23 Thread Pantelis Antoniou
Hi Wolfram, > On Apr 23, 2015, at 11:33 , Wolfram Sang wrote: > > >> Sorry for the non-prompt reply; but just for kicks, can you try the attached >> patch? >> >> I have a hunch this might be the problem. > > Yeah, this even makes my more complex driver work \o/ I will post it > once -rc1 is

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-23 Thread Wolfram Sang
> Sorry for the non-prompt reply; but just for kicks, can you try the attached > patch? > > I have a hunch this might be the problem. Yeah, this even makes my more complex driver work \o/ I will post it once -rc1 is out. Thanks a lot for your help, much appreciated! signature.asc

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-23 Thread Wolfram Sang
Sorry for the non-prompt reply; but just for kicks, can you try the attached patch? I have a hunch this might be the problem. Yeah, this even makes my more complex driver work \o/ I will post it once -rc1 is out. Thanks a lot for your help, much appreciated! signature.asc Description:

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-23 Thread Wolfram Sang
This patch has been posted before but up to now, no-one had a test case that triggered the bug, At your service... ;) signature.asc Description: Digital signature

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-23 Thread Pantelis Antoniou
Hi Wolfram, On Apr 23, 2015, at 11:33 , Wolfram Sang w...@the-dreams.de wrote: Sorry for the non-prompt reply; but just for kicks, can you try the attached patch? I have a hunch this might be the problem. Yeah, this even makes my more complex driver work \o/ I will post it once

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-22 Thread Pantelis Antoniou
Hi Wolfram, > On Apr 14, 2015, at 16:27 , Wolfram Sang wrote: > > Hi Pantelis, > > thanks for your prompt reply. Unfortunately, I had to wait until I could > access the test system again. > [snip] Sorry for the non-prompt reply; but just for kicks, can you try the attached patch? I have a

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-22 Thread Pantelis Antoniou
Hi Wolfram, On Apr 14, 2015, at 16:27 , Wolfram Sang w...@the-dreams.de wrote: Hi Pantelis, thanks for your prompt reply. Unfortunately, I had to wait until I could access the test system again. [snip] Sorry for the non-prompt reply; but just for kicks, can you try the attached

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-14 Thread Wolfram Sang
Hi Pantelis, thanks for your prompt reply. Unfortunately, I had to wait until I could access the test system again. > > + struct property status_chg = { .name = "status", .length = 9, .value = > > "disabled" }; > > + int ret; > > + > > ^ The status_chg property is on the stack. You can’t

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-04-14 Thread Wolfram Sang
Hi Pantelis, thanks for your prompt reply. Unfortunately, I had to wait until I could access the test system again. + struct property status_chg = { .name = status, .length = 9, .value = disabled }; + int ret; + ^ The status_chg property is on the stack. You can’t do that,

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-03-31 Thread Pantelis Antoniou
Hi Wolfram, > On Mar 31, 2015, at 18:12 , Wolfram Sang wrote: > > From: Wolfram Sang > > I wanted to disable a node via OF_DYNAMIC by setting its status to disabled. > This code is the minimal testcase, the same happens in a more complex > scenario. > There is something wrong with freeing

[PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-03-31 Thread Wolfram Sang
From: Wolfram Sang I wanted to disable a node via OF_DYNAMIC by setting its status to disabled. This code is the minimal testcase, the same happens in a more complex scenario. There is something wrong with freeing resources. Is my module wrong? Or is it a bug? Crashlog without

[PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-03-31 Thread Wolfram Sang
From: Wolfram Sang wsa+rene...@sang-engineering.com I wanted to disable a node via OF_DYNAMIC by setting its status to disabled. This code is the minimal testcase, the same happens in a more complex scenario. There is something wrong with freeing resources. Is my module wrong? Or is it a bug?

Re: [PATCH] TESTCASE: of: OOPS when disabling node via OF_DYNAMIC

2015-03-31 Thread Pantelis Antoniou
Hi Wolfram, On Mar 31, 2015, at 18:12 , Wolfram Sang w...@the-dreams.de wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com I wanted to disable a node via OF_DYNAMIC by setting its status to disabled. This code is the minimal testcase, the same happens in a more complex scenario.