Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Pete Zaitcev
On Sat, 24 Feb 2007 10:41:15 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > Thanks a lot for comments and Ack the patch please. Cyrill, I forgot to mention a couple of points, sorry. > printk(KERN_INFO "driver %s built at %s on %s\n", > ftdi_elan_driver.name, > -

Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Cyrill Gorcunov
On Sat, Feb 24, 2007 at 01:46:44PM +0100, Oleg Verych wrote: | > From: Cyrill Gorcunov | > Newsgroups: gmane.linux.kernel | > Subject: bss zeroing ([PATCH] USB Elan FTDI: check for workqueue creation v2) | > Date: Sat, 24 Feb 2007 10:41:15 +0300 | [] | > Btw, Pete, you are

Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Oleg Verych
> From: Cyrill Gorcunov > Newsgroups: gmane.linux.kernel > Subject: bss zeroing ([PATCH] USB Elan FTDI: check for workqueue creation v2) > Date: Sat, 24 Feb 2007 10:41:15 +0300 [] > Btw, Pete, you are right! C99 ANSI standart says that static pointer > if it not initiali

Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Oleg Verych
From: Cyrill Gorcunov Newsgroups: gmane.linux.kernel Subject: bss zeroing ([PATCH] USB Elan FTDI: check for workqueue creation v2) Date: Sat, 24 Feb 2007 10:41:15 +0300 [] Btw, Pete, you are right! C99 ANSI standart says that static pointer if it not initialized explicitly has to be set

Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Cyrill Gorcunov
On Sat, Feb 24, 2007 at 01:46:44PM +0100, Oleg Verych wrote: | From: Cyrill Gorcunov | Newsgroups: gmane.linux.kernel | Subject: bss zeroing ([PATCH] USB Elan FTDI: check for workqueue creation v2) | Date: Sat, 24 Feb 2007 10:41:15 +0300 | [] | Btw, Pete, you are right! C99 ANSI standart

Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Pete Zaitcev
On Sat, 24 Feb 2007 10:41:15 +0300, Cyrill Gorcunov [EMAIL PROTECTED] wrote: Thanks a lot for comments and Ack the patch please. Cyrill, I forgot to mention a couple of points, sorry. printk(KERN_INFO driver %s built at %s on %s\n, ftdi_elan_driver.name, -

[PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-23 Thread Cyrill Gorcunov
This patch prevents from NULL pointer usage if workqueue creation failed. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- Btw, Pete, you are right! C99 ANSI standart says that static pointer if it not initialized explicitly has to be set to NULL by compiler ;) Thanks a lot for comments

[PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-23 Thread Cyrill Gorcunov
This patch prevents from NULL pointer usage if workqueue creation failed. Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED] --- Btw, Pete, you are right! C99 ANSI standart says that static pointer if it not initialized explicitly has to be set to NULL by compiler ;) Thanks a lot for comments and