Re: [PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread David Rientjes
On Tue, 4 Feb 2014, kosaki.motoh...@gmail.com wrote: > From: KOSAKI Motohiro > > To use spin_{un}lock_irq is dangerous if caller disabled interrupt. > During aio buffer migration, we have a possibility to see the > following call stack. > > aio_migratepage [disable interrupt] >

[PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread kosaki . motohiro
From: KOSAKI Motohiro To use spin_{un}lock_irq is dangerous if caller disabled interrupt. During aio buffer migration, we have a possibility to see the following call stack. aio_migratepage [disable interrupt] migrate_page_copy clear_page_dirty_for_io set_page_dirty

[PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread kosaki . motohiro
From: KOSAKI Motohiro To use spin_{un}lock_irq is dangerous if caller disabled interrupt. spin_lock_irqsave is a safer alternative. Luckily, now there is no caller that has such usage but it would be nice to fix. Reported-by: David Rientjes rient...@google.com> Signed-off-by: KOSAKI Motohiro

Re: [PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread KOSAKI Motohiro
On Tue, Feb 4, 2014 at 11:58 AM, wrote: > From: KOSAKI Motohiro > > To use spin_{un}lock_irq is dangerous if caller disabled interrupt. > spin_lock_irqsave is a safer alternative. Luckily, now there is no > caller that has such usage but it would be nice to fix. > > Reported-by: David Rientjes

Re: [PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread KOSAKI Motohiro
On Tue, Feb 4, 2014 at 11:58 AM, kosaki.motoh...@gmail.com wrote: From: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com To use spin_{un}lock_irq is dangerous if caller disabled interrupt. spin_lock_irqsave is a safer alternative. Luckily, now there is no caller that has such usage but it

[PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread kosaki . motohiro
From: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com To use spin_{un}lock_irq is dangerous if caller disabled interrupt. spin_lock_irqsave is a safer alternative. Luckily, now there is no caller that has such usage but it would be nice to fix. Reported-by: David Rientjes rient...@google.com

[PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread kosaki . motohiro
From: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com To use spin_{un}lock_irq is dangerous if caller disabled interrupt. During aio buffer migration, we have a possibility to see the following call stack. aio_migratepage [disable interrupt] migrate_page_copy clear_page_dirty_for_io

Re: [PATCH] __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

2014-02-04 Thread David Rientjes
On Tue, 4 Feb 2014, kosaki.motoh...@gmail.com wrote: From: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com To use spin_{un}lock_irq is dangerous if caller disabled interrupt. During aio buffer migration, we have a possibility to see the following call stack. aio_migratepage [disable