Re: [PATCH] add blockconsole version 1.1

2012-12-19 Thread Borislav Petkov
Hey Jörn, On Tue, Jul 24, 2012 at 10:28:20PM +0200, Borislav Petkov wrote: > Ok, thanks for taking the time to explain this - very interesting > stuff. > > So, as far as I'm concerned blockconsole is ready for shipping! 8-) you're probably very busy so I'll be quick: I still think that blockconso

Re: [PATCH] add blockconsole version 1.1

2012-08-14 Thread Jan Engelhardt
On Wednesday 2012-07-18 20:53, Jörn Engel wrote: > >> With the include added, it builds fine. Then I took an usb stick and I >> did: >> >> $ ./mkblockconsole /dev/sdc >> >> > >You can also run hdparm -z instead. We have too many ways of doing some things. util-linux conveniently has `blockdev

Re: [PATCH] add blockconsole version 1.1

2012-07-25 Thread Jörn Engel
On Wed, 25 July 2012 09:17:09 +0100, Tvrtko Ursulin wrote: > > As far as I know there is nothing like netpoll in the block layer so it has > to > be a lot less reliable than netconsole. Especially with delaying write out to > a workqueue. Anyway, I am not arguing, just saying in my opinion thos

Re: [PATCH] add blockconsole version 1.1

2012-07-25 Thread Tvrtko Ursulin
On Tuesday 24 Jul 2012 15:38:22 Jörn Engel wrote: > On Tue, 24 July 2012 09:01:16 +0100, Tvrtko Ursulin wrote: > > On Monday 23 Jul 2012 21:02:30 Jörn Engel wrote: > > > On Mon, 23 July 2012 15:33:16 +0100, Tvrtko Ursulin wrote: > > > > On Thursday 12 Jul 2012 18:46:34 Jörn Engel wrote: > > At the

Re: [PATCH] add blockconsole version 1.1

2012-07-24 Thread Borislav Petkov
On Tue, Jul 24, 2012 at 01:52:32PM -0400, Jörn Engel wrote: > On Tue, 24 July 2012 18:25:47 +0200, Borislav Petkov wrote: > > > The advantage should be better robustness, in particular when dealing > > > with cheap flash devices. > > > > In the sense that we flush the current sector after one seco

Re: [PATCH] add blockconsole version 1.1

2012-07-24 Thread Jörn Engel
On Tue, 24 July 2012 18:25:47 +0200, Borislav Petkov wrote: > > The advantage should be better robustness, in particular when dealing > > with cheap flash devices. > > In the sense that we flush the current sector after one second the > latest so that we can lose as small amount of data as possibl

Re: [PATCH] add blockconsole version 1.1

2012-07-24 Thread Borislav Petkov
On Tue, Jul 24, 2012 at 10:53:35AM -0400, Jörn Engel wrote: > On Tue, 24 July 2012 17:42:19 +0200, Borislav Petkov wrote: > > > > Just a minor nuisance: I have this in the log: > > > > ... > > [ 10.498422] console [bcon0] enabled > > [ 10.499899] blockconsole: now logging to /dev/sdc at 1 > >

Re: [PATCH] add blockconsole version 1.1

2012-07-24 Thread Jörn Engel
On Tue, 24 July 2012 17:42:19 +0200, Borislav Petkov wrote: > > Just a minor nuisance: I have this in the log: > > ... > [ 10.498422] console [bcon0] enabled > [ 10.499899] blockconsole: now logging to /dev/sdc at 1 > [ 10.594791] usb 5-2: new full-speed USB device number 3 using ohci_hcd >

Re: [PATCH] add blockconsole version 1.1

2012-07-24 Thread Jörn Engel
On Tue, 24 July 2012 09:01:16 +0100, Tvrtko Ursulin wrote: > On Monday 23 Jul 2012 21:02:30 Jörn Engel wrote: > > On Mon, 23 July 2012 15:33:16 +0100, Tvrtko Ursulin wrote: > > > On Thursday 12 Jul 2012 18:46:34 Jörn Engel wrote: > > At the very least block console does not work from interrupt con

Re: [PATCH] add blockconsole version 1.1

2012-07-24 Thread Borislav Petkov
On Mon, Jul 23, 2012 at 04:04:59PM -0400, Jörn Engel wrote: > On Wed, 18 July 2012 23:45:21 +0200, Borislav Petkov wrote: > > > > Something like the above, just slap it at the beginning of > > Documentation/block/blockconsole.txt for impatient people like me and > > that's it :-). > > And below i

Re: [PATCH] add blockconsole version 1.1

2012-07-24 Thread Tvrtko Ursulin
On Monday 23 Jul 2012 21:02:30 Jörn Engel wrote: > On Mon, 23 July 2012 15:33:16 +0100, Tvrtko Ursulin wrote: > > On Thursday 12 Jul 2012 18:46:34 Jörn Engel wrote: > > > Console driver similar to netconsole, except it writes to a block > > > device. Can be useful in a setup where netconsole, for

Re: [PATCH] add blockconsole version 1.1

2012-07-23 Thread Jörn Engel
On Wed, 18 July 2012 23:45:21 +0200, Borislav Petkov wrote: > > Something like the above, just slap it at the beginning of > Documentation/block/blockconsole.txt for impatient people like me and > that's it :-). And below is an updated patch with your changes folded in. I did a few minor tweaks,

Re: [PATCH] add blockconsole version 1.1

2012-07-23 Thread Jörn Engel
On Mon, 23 July 2012 15:33:16 +0100, Tvrtko Ursulin wrote: > On Thursday 12 Jul 2012 18:46:34 Jörn Engel wrote: > > Console driver similar to netconsole, except it writes to a block > > device. Can be useful in a setup where netconsole, for whatever > > reasons, is impractical. > > Perhaps you ne

Re: [PATCH] add blockconsole version 1.1

2012-07-23 Thread Tvrtko Ursulin
Hi, On Thursday 12 Jul 2012 18:46:34 Jörn Engel wrote: > Console driver similar to netconsole, except it writes to a block > device. Can be useful in a setup where netconsole, for whatever > reasons, is impractical. Perhaps you need to add a word or two about limitations compared to netconsole

Re: [PATCH] add blockconsole version 1.1

2012-07-19 Thread Borislav Petkov
On Wed, Jul 18, 2012 at 05:08:15PM -0400, Jörn Engel wrote: > On Wed, 18 July 2012 23:45:21 +0200, Borislav Petkov wrote: > > > > > > So why is that first megabyte full of zeros there? > > > > > > It gives you some scratch space to store information in. > > > > How? By me writing something in th

Re: [PATCH] add blockconsole version 1.1

2012-07-18 Thread Jörn Engel
On Wed, 18 July 2012 23:45:21 +0200, Borislav Petkov wrote: > > > > So why is that first megabyte full of zeros there? > > > > It gives you some scratch space to store information in. > > How? By me writing something in that empty line in vim? Or something > else storing stuff there? Assuming y

Re: [PATCH] add blockconsole version 1.1

2012-07-18 Thread Borislav Petkov
On Wed, Jul 18, 2012 at 02:53:35PM -0400, Jörn Engel wrote: [ … ] > > $ ./mkblockconsole /dev/sdc > > > > > > You can also run hdparm -z instead. Or replug the device. Main > danger of hdparm is that running the command twice will cause two > instances of blockconsole to use the same device

Re: [PATCH] add blockconsole version 1.1

2012-07-18 Thread Jörn Engel
On Mon, 16 July 2012 14:46:15 +0200, Borislav Petkov wrote: > On Fri, Jul 13, 2012 at 12:20:09PM -0400, Jörn Engel wrote: > > > +CANDIDATES=`lsscsi |sed 's|.*/dev|/dev|'` > > You probably want to check lsscsi presence on the system, wasn't > installed by default on my debian testing image, for ex

Re: [PATCH] add blockconsole version 1.1

2012-07-16 Thread Borislav Petkov
On Fri, Jul 13, 2012 at 12:20:09PM -0400, Jörn Engel wrote: [ … ] > diff --git a/Documentation/block/blockconsole/bcon_tail > b/Documentation/block/blockconsole/bcon_tail > new file mode 100755 > index 000..950bfd1 > --- /dev/null > +++ b/Documentation/block/blockconsole/bcon_tail > @@ -0,0

Re: [PATCH] add blockconsole version 1.1

2012-07-13 Thread Borislav Petkov
On Fri, Jul 13, 2012 at 12:20:09PM -0400, Jörn Engel wrote: > > > Logging to partitions is not supported. > > > > That could be useful though. We have a setup here where we create a > > partition on the block device and install the OS there for testing > > purposes while leaving room on the device

Re: [PATCH] add blockconsole version 1.1

2012-07-13 Thread Jörn Engel
On Fri, 13 July 2012 15:03:38 +0200, Borislav Petkov wrote: > On Thu, Jul 12, 2012 at 01:46:34PM -0400, Jörn Engel wrote: > > + > > +It can currently only be used built-in. > > If so, you need to change the tristate in Kconfig below to bool. Fair point, fixed. > > Logging to partitions is not su

Re: [PATCH] add blockconsole version 1.1

2012-07-13 Thread Borislav Petkov
On Thu, Jul 12, 2012 at 01:46:34PM -0400, Jörn Engel wrote: > Console driver similar to netconsole, except it writes to a block > device. Can be useful in a setup where netconsole, for whatever > reasons, is impractical. > > Changes since version 1.0: > - Header format overhaul, addressing severa

[PATCH] add blockconsole version 1.1

2012-07-12 Thread Jörn Engel
Console driver similar to netconsole, except it writes to a block device. Can be useful in a setup where netconsole, for whatever reasons, is impractical. Changes since version 1.0: - Header format overhaul, addressing several annoyances when actually using blockconsole for production. - Steve