Re: [PATCH] add "notime" boot option

2007-05-24 Thread Jan Engelhardt
On May 24 2007 09:24, Randy Dunlap wrote: >> >> Wonderful, now we have _three_ options to control time... >> >> time= >> printk.time= >> notime= > > Currently the middle one is "printk.printk_time". > And the first and last are just "time" and "notime", without a bool value. > > And as I wrote l

Re: [PATCH] add "notime" boot option

2007-05-24 Thread Randy Dunlap
Jan Engelhardt wrote: On May 22 2007 12:09, Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Add "notime" boot option to prevent timing data from being printed on each printk message line. We've seen a few cases of 'time' data locking problems (possibly involving netconsole or net dr

Re: [PATCH] add "notime" boot option

2007-05-24 Thread Jan Engelhardt
On May 22 2007 12:09, Randy Dunlap wrote: >From: Randy Dunlap <[EMAIL PROTECTED]> > >Add "notime" boot option to prevent timing data from being printed on >each printk message line. > >We've seen a few cases of 'time' data locking problems (possibly >involving netconsole or net drivers). If a ker

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Rene Herman
On 05/24/2007 07:11 AM, Rene Herman wrote: Okay. I would by the way not be against turning the timestamping off by default and turning it _on_ with a "timestamps" or "logtime" or whatever option. Yes I only now looked. Sorry, didn't realise that was how it already worked. CONFIG_PRINTK_TIME

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Rene Herman
On 05/24/2007 07:08 AM, Randy Dunlap wrote: Rene Herman wrote: Okay. I would by the way not be against turning the timestamping off by default and turning it _on_ with a "timestamps" or "logtime" or whatever option. The information is sometimes handy for seeing the (clustering of) event tim

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Randy Dunlap
Rene Herman wrote: On 05/23/2007 10:55 PM, Randy Dunlap wrote: That's a good source of confusion. To me, "notime" means something like "don't bother calculating time", instead of the proposed behavior. Can't it be something like 'nologts' (no log timestamps) or nots or notimestamps or nol

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Rene Herman
On 05/23/2007 10:55 PM, Randy Dunlap wrote: That's a good source of confusion. To me, "notime" means something like "don't bother calculating time", instead of the proposed behavior. Can't it be something like 'nologts' (no log timestamps) or nots or notimestamps or nologtime instead "no

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Randy Dunlap
On Wed, 23 May 2007 21:15:20 +0200 Rene Herman wrote: > On 05/23/2007 07:04 PM, Randy Dunlap wrote: > > >> That's a good source of confusion. To me, "notime" means something > >> like "don't bother calculating time", instead of the proposed > >> behavior. Can't it be something like 'nologts' (n

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Rene Herman
On 05/23/2007 07:04 PM, Randy Dunlap wrote: That's a good source of confusion. To me, "notime" means something like "don't bother calculating time", instead of the proposed behavior. Can't it be something like 'nologts' (no log timestamps) or nots or notimestamps or nologtime instead? "nolog

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Randy Dunlap
On Wed, 23 May 2007 15:03:01 +0400 Michael Tokarev wrote: > Randy Dunlap wrote: > > > > Add "notime" boot option to prevent timing data from being printed on > > each printk message line. > > That's a good source of confusion. To me, "notime" means something > like "don't bother calculating tim

Re: [PATCH] add "notime" boot option

2007-05-23 Thread Michael Tokarev
Randy Dunlap wrote: > > Add "notime" boot option to prevent timing data from being printed on > each printk message line. That's a good source of confusion. To me, "notime" means something like "don't bother calculating time", instead of the proposed behavior. Can't it be something like 'nologt

Re: [PATCH] add "notime" boot option

2007-05-22 Thread Randy Dunlap
On Tue, 22 May 2007 15:40:30 -0400 Dave Jones wrote: > Not disagreeing with the patch, but I wonder if it'd be a net win > if we had a helper that would replace the zillion instances > of "set this variable to a 0/1 depending if its prefixed with 'no'" > with 1-2 lines. I don't know about that, b

Re: [PATCH] add "notime" boot option

2007-05-22 Thread Dave Jones
On Tue, May 22, 2007 at 12:09:38PM -0700, Randy Dunlap wrote: > --- linux-2622-rc2.orig/kernel/printk.c > +++ linux-2622-rc2/kernel/printk.c > @@ -458,9 +458,17 @@ static int __init printk_time_setup(char > printk_time = 1; > return 1; > } > - > __setup("time", printk_time_setup

[PATCH] add "notime" boot option

2007-05-22 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Add "notime" boot option to prevent timing data from being printed on each printk message line. We've seen a few cases of 'time' data locking problems (possibly involving netconsole or net drivers). If a kernel is built with CONFIG_PRINTK_TIME=y, it may hav