Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit

2012-10-25 Thread Ed Cashin
On Oct 25, 2012, at 2:33 AM, Dan Carpenter wrote: > On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote: >> On Wed, 24 Oct 2012 14:26:13 -0400 >> Ed Cashin wrote: >> >>> After calling dev_queue_xmit it is no longer safe to access the >>> members of the skb. >>> >>> Reported-by: Dan Ca

Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit

2012-10-24 Thread Dan Carpenter
On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote: > On Wed, 24 Oct 2012 14:26:13 -0400 > Ed Cashin wrote: > > > After calling dev_queue_xmit it is no longer safe to access the > > members of the skb. > > > > Reported-by: Dan Carpenter > > hm, that was clever. How did Dan detect t

Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 14:26:13 -0400 Ed Cashin wrote: > After calling dev_queue_xmit it is no longer safe to access the > members of the skb. > > Reported-by: Dan Carpenter hm, that was clever. How did Dan detect this bug? > --- a/drivers/block/aoe/aoenet.c > +++ b/drivers/block/aoe/aoenet.c >

[PATCH] aoe: avoid using skb member after dev_queue_xmit

2012-10-24 Thread Ed Cashin
After calling dev_queue_xmit it is no longer safe to access the members of the skb. Reported-by: Dan Carpenter Signed-off-by: Ed Cashin --- drivers/block/aoe/aoenet.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoene