Re: [PATCH] arm: fix page faults in do_alignment

2019-09-16 Thread Eric W. Biederman
Russell King - ARM Linux admin writes: > On Fri, Sep 06, 2019 at 04:17:59PM +0100, Russell King - ARM Linux admin > wrote: >> On Mon, Sep 02, 2019 at 12:36:56PM -0500, Eric W. Biederman wrote: >> > Russell King - ARM Linux admin writes: >> > >> > > On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eri

Re: [PATCH] arm: fix page faults in do_alignment

2019-09-15 Thread Russell King - ARM Linux admin
On Fri, Sep 06, 2019 at 04:17:59PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Sep 02, 2019 at 12:36:56PM -0500, Eric W. Biederman wrote: > > Russell King - ARM Linux admin writes: > > > > > On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: > > >> Russell King - ARM Li

Re: [PATCH] arm: fix page faults in do_alignment

2019-09-06 Thread Russell King - ARM Linux admin
On Mon, Sep 02, 2019 at 12:36:56PM -0500, Eric W. Biederman wrote: > Russell King - ARM Linux admin writes: > > > On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: > >> Russell King - ARM Linux admin writes: > >> > >> > On Fri, Aug 30, 2019 at 02:45:36PM -0500, Eric W. Biederma

Re: [PATCH] arm: fix page faults in do_alignment

2019-09-03 Thread Jing Xiangfeng
On 2019/9/3 1:36, Eric W. Biederman wrote: > Russell King - ARM Linux admin writes: > >> On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: >>> Russell King - ARM Linux admin writes: >>> On Fri, Aug 30, 2019 at 02:45:36PM -0500, Eric W. Biederman wrote: > Russell King -

Re: [PATCH] arm: fix page faults in do_alignment

2019-09-02 Thread Eric W. Biederman
Russell King - ARM Linux admin writes: > On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: >> Russell King - ARM Linux admin writes: >> >> > On Fri, Aug 30, 2019 at 02:45:36PM -0500, Eric W. Biederman wrote: >> >> Russell King - ARM Linux admin writes: >> >> >> >> > On Fri, A

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-31 Thread kbuild test robot
Hi Jing, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on arm/for-next] [cannot apply to v5.3-rc6 next-20190830] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-31 Thread Jing Xiangfeng
On 2019/8/31 15:55, Russell King - ARM Linux admin wrote: > On Sat, Aug 31, 2019 at 09:49:45AM +0800, Jing Xiangfeng wrote: >> On 2019/8/30 21:35, Russell King - ARM Linux admin wrote: >>> On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: The function do_alignment can handle misa

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-31 Thread Russell King - ARM Linux admin
On Sat, Aug 31, 2019 at 09:49:45AM +0800, Jing Xiangfeng wrote: > On 2019/8/30 21:35, Russell King - ARM Linux admin wrote: > > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: > >> The function do_alignment can handle misaligned address for user and > >> kernel space. If it is a use

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Jing Xiangfeng
On 2019/8/30 21:35, Russell King - ARM Linux admin wrote: > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: >> The function do_alignment can handle misaligned address for user and >> kernel space. If it is a userspace access, do_alignment may fail on >> a low-memory situation, becau

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Russell King - ARM Linux admin
On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: > Russell King - ARM Linux admin writes: > > > On Fri, Aug 30, 2019 at 02:45:36PM -0500, Eric W. Biederman wrote: > >> Russell King - ARM Linux admin writes: > >> > >> > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng w

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Eric W. Biederman
Russell King - ARM Linux admin writes: > On Fri, Aug 30, 2019 at 02:45:36PM -0500, Eric W. Biederman wrote: >> Russell King - ARM Linux admin writes: >> >> > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: >> >> The function do_alignment can handle misaligned address for user an

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Russell King - ARM Linux admin
On Fri, Aug 30, 2019 at 02:45:36PM -0500, Eric W. Biederman wrote: > Russell King - ARM Linux admin writes: > > > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: > >> The function do_alignment can handle misaligned address for user and > >> kernel space. If it is a userspace acces

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Eric W. Biederman
Russell King - ARM Linux admin writes: > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: >> The function do_alignment can handle misaligned address for user and >> kernel space. If it is a userspace access, do_alignment may fail on >> a low-memory situation, because page faults ar

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Russell King - ARM Linux admin
Please fix your email. jingxiangf...@huawei.com host mx7.huawei.com [168.195.93.46] SMTP error from remote mail server after pipelined DATA: 554 5.7.1 spf check result is none SPF is *not* required for email. If you wish to impose such restrictions on email, then I reserve th

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Russell King - ARM Linux admin
On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: > The function do_alignment can handle misaligned address for user and > kernel space. If it is a userspace access, do_alignment may fail on > a low-memory situation, because page faults are disabled in > probe_kernel_address. > > Fix

[PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Jing Xiangfeng
The function do_alignment can handle misaligned address for user and kernel space. If it is a userspace access, do_alignment may fail on a low-memory situation, because page faults are disabled in probe_kernel_address. Fix this by using __copy_from_user stead of probe_kernel_address. Fixes: b2551