: Thursday, August 16, 2012 3:28 PM
To: Jiang Wang
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Chaitanya Lala;
Francis St. Amant
Subject: RE: [PATCH] bnx2: turn off the network statck during initialization
On Thu, 2012-08-16 at 21:48 +, Jiang Wang wrote:
> I see. I was confu
On Thu, 2012-08-16 at 21:48 +, Jiang Wang wrote:
> I see. I was confused by the name of bnx2_set_power_state() and
> I think the PHY is actually powered up by bnx2_reset_nic, right?
bnx2_init_phy() in bnx2_init_nic() will bring up the PHY if it is down.
>
>
--
To unsubscribe from
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
> Also, I have another comment related to link state.
>
> Right now, the bnx2 driver powers up the device in bnx2_init_board(),
> regardless the netif_carrier is on or off.
We actually don't power up the device. bnx2_init_board() just
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
[...]
> Also, I have another comment related to link state.
>
> Right now, the bnx2 driver powers up the device in bnx2_init_board(),
> regardless the netif_carrier is on or off. This may introduce
> following inconsistent behaviors:
> 1)
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
> Also, I have another comment related to link state.
>
> Right now, the bnx2 driver powers up the device in bnx2_init_board(),
> regardless the netif_carrier is on or off.
We actually don't power up the device. bnx2_init_board() just probes
: Michael Chan [mailto:mc...@broadcom.com]
Sent: Thursday, August 16, 2012 12:29 PM
To: Jiang Wang
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Chaitanya Lala;
Francis St. Amant
Subject: RE: [PATCH] bnx2: turn off the network statck during initialization
On Thu, 2012-08-16 at 19:15
Original Message-
> From: Michael Chan [mailto:mc...@broadcom.com]
> Sent: Thursday, August 16, 2012 11:57 AM
> To: Jiang Wang
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Chaitanya Lala;
> Francis St. Amant; Jiang Wang
> Subject: Re: [PATCH] bnx2: turn off the n
cis St. Amant; Jiang Wang
Subject: Re: [PATCH] bnx2: turn off the network statck during initialization
On Thu, 2012-08-16 at 11:21 -0700, Jiang Wang wrote:
> The initialization state of bnx2 driver is wrong. It does not turn of
> the Linux network stack using netif_carrier_off. T
On Thu, 2012-08-16 at 11:21 -0700, Jiang Wang wrote:
> The initialization state of bnx2 driver is wrong. It does not turn
> of the Linux network stack using netif_carrier_off. This may lead to
> inconsistent report from ethtool as the link is up but speed is
> unknown when the cable is not
The initialization state of bnx2 driver is wrong. It does not turn
of the Linux network stack using netif_carrier_off. This may lead to
inconsistent report from ethtool as the link is up but speed is
unknown when the cable is not plugged in.
E.g.
Speed: Unknown!
The initialization state of bnx2 driver is wrong. It does not turn
of the Linux network stack using netif_carrier_off. This may lead to
inconsistent report from ethtool as the link is up but speed is
unknown when the cable is not plugged in.
E.g.
Speed: Unknown!
On Thu, 2012-08-16 at 11:21 -0700, Jiang Wang wrote:
The initialization state of bnx2 driver is wrong. It does not turn
of the Linux network stack using netif_carrier_off. This may lead to
inconsistent report from ethtool as the link is up but speed is
unknown when the cable is not plugged
. Amant; Jiang Wang
Subject: Re: [PATCH] bnx2: turn off the network statck during initialization
On Thu, 2012-08-16 at 11:21 -0700, Jiang Wang wrote:
The initialization state of bnx2 driver is wrong. It does not turn of
the Linux network stack using netif_carrier_off. This may lead
: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Chaitanya Lala;
Francis St. Amant; Jiang Wang
Subject: Re: [PATCH] bnx2: turn off the network statck during initialization
On Thu, 2012-08-16 at 11:21 -0700, Jiang Wang wrote:
The initialization state of bnx2 driver is wrong. It does
: Michael Chan [mailto:mc...@broadcom.com]
Sent: Thursday, August 16, 2012 12:29 PM
To: Jiang Wang
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Chaitanya Lala;
Francis St. Amant
Subject: RE: [PATCH] bnx2: turn off the network statck during initialization
On Thu, 2012-08-16 at 19:15
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
Also, I have another comment related to link state.
Right now, the bnx2 driver powers up the device in bnx2_init_board(),
regardless the netif_carrier is on or off.
We actually don't power up the device. bnx2_init_board() just probes
the
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
[...]
Also, I have another comment related to link state.
Right now, the bnx2 driver powers up the device in bnx2_init_board(),
regardless the netif_carrier is on or off. This may introduce
following inconsistent behaviors:
1) suppose the
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
Also, I have another comment related to link state.
Right now, the bnx2 driver powers up the device in bnx2_init_board(),
regardless the netif_carrier is on or off.
We actually don't power up the device. bnx2_init_board() just probes
On Thu, 2012-08-16 at 21:48 +, Jiang Wang wrote:
I see. I was confused by the name of bnx2_set_power_state() and
I think the PHY is actually powered up by bnx2_reset_nic, right?
bnx2_init_phy() in bnx2_init_nic() will bring up the PHY if it is down.
--
To unsubscribe from this
: Thursday, August 16, 2012 3:28 PM
To: Jiang Wang
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Chaitanya Lala;
Francis St. Amant
Subject: RE: [PATCH] bnx2: turn off the network statck during initialization
On Thu, 2012-08-16 at 21:48 +, Jiang Wang wrote:
I see. I was confused
20 matches
Mail list logo
