Re: [PATCH] can: kvaser_usb: Add support for the Usbcan-II family

2014-12-31 Thread Olivier Sobrie
On Tue, Dec 30, 2014 at 10:33:26AM -0500, Ahmed S. Darwish wrote: > On Sun, Dec 28, 2014 at 10:51:34PM +0100, Olivier Sobrie wrote: > [...] > > > > > > > > > > + if (LEAF_PRODUCT_ID(id->idProduct)) { > > > > > + dev->family = KVASER_LEAF; > > > > > + dev->max_channels

Re: [PATCH] can: kvaser_usb: Add support for the Usbcan-II family

2014-12-30 Thread Ahmed S. Darwish
On Sun, Dec 28, 2014 at 10:51:34PM +0100, Olivier Sobrie wrote: [...] > > > > > > > > + if (LEAF_PRODUCT_ID(id->idProduct)) { > > > > + dev->family = KVASER_LEAF; > > > > + dev->max_channels = LEAF_MAX_NET_DEVICES; > > > > + } else if (USBCAN_PRODUCT_ID(id-

Re: [PATCH] can: kvaser_usb: Add support for the Usbcan-II family

2014-12-28 Thread Olivier Sobrie
Hello Ahmed, On Wed, Dec 24, 2014 at 05:04:17PM +0200, Ahmed S. Darwish wrote: > Hi Olivier, > > On Wed, Dec 24, 2014 at 01:36:27PM +0100, Olivier Sobrie wrote: > > Hello Ahmed, > > > > On Tue, Dec 23, 2014 at 05:53:11PM +0200, Ahmed S. Darwish wrote: > > > From: Ahmed S. Darwish > > > > > > C

Re: [PATCH] can: kvaser_usb: Add support for the Usbcan-II family

2014-12-24 Thread Ahmed S. Darwish
Hi Olivier, On Wed, Dec 24, 2014 at 01:36:27PM +0100, Olivier Sobrie wrote: > Hello Ahmed, > > On Tue, Dec 23, 2014 at 05:53:11PM +0200, Ahmed S. Darwish wrote: > > From: Ahmed S. Darwish > > > > CAN to USB interfaces sold by the Swedish manufacturer Kvaser are > > divided into two major famili

Re: [PATCH] can: kvaser_usb: Add support for the Usbcan-II family

2014-12-24 Thread Olivier Sobrie
Hello Ahmed, On Tue, Dec 23, 2014 at 05:53:11PM +0200, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish > > CAN to USB interfaces sold by the Swedish manufacturer Kvaser are > divided into two major families: 'Leaf', and 'UsbcanII'. From an > Operating System perspective, the firmware of both fa

[PATCH] can: kvaser_usb: Add support for the Usbcan-II family

2014-12-23 Thread Ahmed S. Darwish
From: Ahmed S. Darwish CAN to USB interfaces sold by the Swedish manufacturer Kvaser are divided into two major families: 'Leaf', and 'UsbcanII'. From an Operating System perspective, the firmware of both families behave in a not too drastically different fashion. This patch adds support for th