RE: [PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-17 Thread pankj.sharma
> From: Jeroen Hofstee > Subject: Re: [PATCH] can: m_can: fix boolreturn.cocci warnings > > Hello Simon, > > On 10/15/19 9:13 AM, Simon Horman wrote: > > On Tue, Oct 15, 2019 at 06:37:54AM +, Jeroen Hofstee wrote: > >> Hi, > >> > >> On 10/1

Re: [PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-15 Thread Jeroen Hofstee
Hello Simon, On 10/15/19 9:13 AM, Simon Horman wrote: > On Tue, Oct 15, 2019 at 06:37:54AM +, Jeroen Hofstee wrote: >> Hi, >> >> On 10/15/19 7:57 AM, Simon Horman wrote: >>> On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote: From: kbuild test robot drivers/net/c

Re: [PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-15 Thread Simon Horman
On Tue, Oct 15, 2019 at 06:37:54AM +, Jeroen Hofstee wrote: > Hi, > > On 10/15/19 7:57 AM, Simon Horman wrote: > > On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote: > >> From: kbuild test robot > >> > >> drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in functi

Re: [PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-14 Thread Jeroen Hofstee
Hi, On 10/15/19 7:57 AM, Simon Horman wrote: > On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote: >> From: kbuild test robot >> >> drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function >> 'is_protocol_err' with return type bool >> >> Return statements in fu

Re: [PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-14 Thread Simon Horman
On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function > 'is_protocol_err' with return type bool > > Return statements in functions returning bool should use > true/false inste

[PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-14 Thread kbuild test robot
From: kbuild test robot drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function 'is_protocol_err' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 4694616