Re: [PATCH] checkpatch: Add warning about submitting patches using --file

2013-09-17 Thread Andrew Morton
On Mon, 2 Sep 2013 23:37:05 +0300 Dan Carpenter wrote: > On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote: > > +WARNING: When using --file mode, do not send patches that just make > > +whitespace or formatting changes unless more significant changes are > > +also made for other reason

Re: [PATCH] checkpatch: Add warning about submitting patches using --file

2013-09-02 Thread Joe Perches
On Mon, 2013-09-02 at 23:37 +0300, Dan Carpenter wrote: > On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote: > > +WARNING: When using --file mode, do not send patches that just make > > +whitespace or formatting changes unless more significant changes are > > +also made for other reasons

Re: [PATCH] checkpatch: Add warning about submitting patches using --file

2013-09-02 Thread Dan Carpenter
On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote: > +WARNING: When using --file mode, do not send patches that just make > +whitespace or formatting changes unless more significant changes are > +also made for other reasons in another patch. > + This is a run on sentence. Also I don't

Re: [PATCH] checkpatch: Add warning about submitting patches using --file

2013-09-02 Thread Josh Triplett
On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote: > Add a message describing the lack of value in using > --file to generate patches. > > Exclude files in staging from this message. > > A similar message was removed by commit cf655043d4b > ("update checkpatch.pl to version 0.15") > >

Re: [Ksummit-2013-discuss] [PATCH] checkpatch: Add warning about submitting patches using --file

2013-09-02 Thread Mauro Carvalho Chehab
Em Mon, 02 Sep 2013 12:40:47 -0700 Joe Perches escreveu: > Add a message describing the lack of value in using > --file to generate patches. > > Exclude files in staging from this message. > > A similar message was removed by commit cf655043d4b > ("update checkpatch.pl to version 0.15") > > Si

[PATCH] checkpatch: Add warning about submitting patches using --file

2013-09-02 Thread Joe Perches
Add a message describing the lack of value in using --file to generate patches. Exclude files in staging from this message. A similar message was removed by commit cf655043d4b ("update checkpatch.pl to version 0.15") Signed-off-by: Joe Perches --- Maybe this sort of wordsmithing is valuable.