Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 05:59:23PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > > > On Wed, Oct 23, 2019 at 1

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Mark Brown
On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > > > The driver should also h

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > > > The driver should also have supported s3c6400 as well. > > > Kconfig says otherwise, unless I am

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Mark Brown
On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > The driver should also have supported s3c6400 as well. > Kconfig says otherwise, unless I am missing something. > config ARM_S3C64XX_CPUFREQ > bool "Samsun

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 08:53:02AM +0530, Viresh Kumar wrote: > > On 22-10-19, 17:09, Nathan Chancellor wrote: > > > When building with Clang + -Wtautological-pointer-compare: > > > > > > drivers/cpufreq/s3c64xx-cpufreq.c:152:6: warning

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Mark Brown
On Wed, Oct 23, 2019 at 08:53:02AM +0530, Viresh Kumar wrote: > On 22-10-19, 17:09, Nathan Chancellor wrote: > > When building with Clang + -Wtautological-pointer-compare: > > > > drivers/cpufreq/s3c64xx-cpufreq.c:152:6: warning: comparison of array > > 's3c64xx_freq_table' equal to a null pointer

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-22 Thread Viresh Kumar
On 22-10-19, 17:09, Nathan Chancellor wrote: > When building with Clang + -Wtautological-pointer-compare: > > drivers/cpufreq/s3c64xx-cpufreq.c:152:6: warning: comparison of array > 's3c64xx_freq_table' equal to a null pointer is always false > [-Wtautological-pointer-compare] > if (s3c64x

[PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-22 Thread Nathan Chancellor
When building with Clang + -Wtautological-pointer-compare: drivers/cpufreq/s3c64xx-cpufreq.c:152:6: warning: comparison of array 's3c64xx_freq_table' equal to a null pointer is always false [-Wtautological-pointer-compare] if (s3c64xx_freq_table == NULL) { ^~