Re: [PATCH] cris: don't use module_init for non-modular core eeprom.c code

2015-06-15 Thread Paul Gortmaker
On 15-06-15 03:35 AM, Jesper Nilsson wrote: > On Sun, Jun 14, 2015 at 05:05:21PM -0400, Paul Gortmaker wrote: >> The eeprom.c code is compiled based on the Kconfig setting >> ETRAX_I2C_EEPROM, which is bool. So the code is either built in >> or absent. It will never be modular, so using module_in

Re: [PATCH] cris: don't use module_init for non-modular core eeprom.c code

2015-06-15 Thread Jesper Nilsson
On Sun, Jun 14, 2015 at 05:05:21PM -0400, Paul Gortmaker wrote: > The eeprom.c code is compiled based on the Kconfig setting > ETRAX_I2C_EEPROM, which is bool. So the code is either built in > or absent. It will never be modular, so using module_init as an > alias for __initcall is rather mislead

[PATCH] cris: don't use module_init for non-modular core eeprom.c code

2015-06-14 Thread Paul Gortmaker
The eeprom.c code is compiled based on the Kconfig setting ETRAX_I2C_EEPROM, which is bool. So the code is either built in or absent. It will never be modular, so using module_init as an alias for __initcall is rather misleading. Fix this up now, so that we can relocate module_init from init.h i