Re: [PATCH] cxl: remove redundant increment of hwirq

2015-02-01 Thread Michael Ellerman
On Sun, 2015-02-01 at 21:40 +, Colin King wrote: > From: Colin Ian King > > Recent commit 80fa93fce37d3490f > ("cxl: Name interrupts in /proc/interrupt") introduced a > redundant increment of hwirq which is not used or even > initialised at the point it is incremented. Detected by > cppcheck:

[PATCH] cxl: remove redundant increment of hwirq

2015-02-01 Thread Colin King
From: Colin Ian King Recent commit 80fa93fce37d3490f ("cxl: Name interrupts in /proc/interrupt") introduced a redundant increment of hwirq which is not used or even initialised at the point it is incremented. Detected by cppcheck: [drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: h

Re: [PATCH] cxl: remove redundant increment of hwirq

2015-01-08 Thread Ian Munsie
Acked-By: Ian Munsie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] cxl: remove redundant increment of hwirq

2015-01-08 Thread Michael Neuling
On Thu, 2015-01-08 at 22:36 +, Colin King wrote: > From: Colin Ian King > > hwirq has not been initialized, however it is being incremented > and also not being referenced in a loop. This error was detected with > cppcheck: > > [drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: h

[PATCH] cxl: remove redundant increment of hwirq

2015-01-08 Thread Colin King
From: Colin Ian King hwirq has not been initialized, however it is being incremented and also not being referenced in a loop. This error was detected with cppcheck: [drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: hwirq Commit 80fa93fce37d ("cxl: Name interrupts in /proc/interrupt